Re: [PATCH 7/7]: Get cob-webs out of sparc64-ieee1275.rmk

2009-03-04 Thread Vesa Jääskeläinen
David Miller wrote:
 There is no way anyone tried to build the sparc target in
 years :-)  This updates sparc64-ieee1275.rmk with modern
 times and regenerates sparc64-ieee1275.mk as well as
 DISTLIST.
 
 2009-03-03 David S. Miller da...@davemloft.net
 
   * conf/sparc64-ieee1275.rmk: Update.
   * conf/sparc64-ieee1275.mk: Rebuilt.
   * DISTLIST: Rebuilt.

There is no need to include .mk files in patches. They just make it a
bit chaotic.

Please make sure to sync in example normal.mod to be exactly how x86 is.
This way that is much easier to maintain.

Please compare those to each other and look that they match as much as
possible. If you see it sensible to differentiate common arch stuff to
own file like in:

i386-pc.rmk
i386.rmk
common.rmk

Then please do so.


___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH 7/7]: Get cob-webs out of sparc64-ieee1275.rmk

2009-03-04 Thread David Miller
From: Vesa Jääskeläinen ch...@nic.fi
Date: Wed, 04 Mar 2009 13:50:37 +0200

 David Miller wrote:
  There is no way anyone tried to build the sparc target in
  years :-)  This updates sparc64-ieee1275.rmk with modern
  times and regenerates sparc64-ieee1275.mk as well as
  DISTLIST.
  
  2009-03-03 David S. Miller da...@davemloft.net
  
  * conf/sparc64-ieee1275.rmk: Update.
  * conf/sparc64-ieee1275.mk: Rebuilt.
  * DISTLIST: Rebuilt.
 
 There is no need to include .mk files in patches. They just make it a
 bit chaotic.

Ok, I won't include them in the future.

 Please make sure to sync in example normal.mod to be exactly how x86 is.
 This way that is much easier to maintain.
 
 Please compare those to each other and look that they match as much as
 possible. If you see it sensible to differentiate common arch stuff to
 own file like in:
 
 i386-pc.rmk
 i386.rmk
 common.rmk
 
 Then please do so.

I will work on commonization as much as possible as I do more
sparc grub work.

Are you going to apply my patches or do I have to rewrite
everything?


___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH 7/7]: Get cob-webs out of sparc64-ieee1275.rmk

2009-03-04 Thread Vincent Pelletier
Le Wednesday 04 March 2009 03:15:39 David Miller, vous avez écrit :
 There is no way anyone tried to build the sparc target in
 years :-)

Literaly years. More than 3 I think.
I gave it a try ~2 1/2 years ago, and started writing a patch... And gave up.
Thanks a lot for taking care of this. I had a very fun time discovering 
sparc64 as I wrote it, and I stopped before making anything usable. I hope 
you won't find too much bad code (sorry about that cache flush).

I guess I'll fire up my good ol' ultra 10 to celebrate this :) .

-- 
Vincent Pelletier


signature.asc
Description: This is a digitally signed message part.
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel