Re: [RFC PATCH 09/23] Fix warnings when building powerpc linux loader 64bit

2014-04-02 Thread Ram Pai 
On Tue, Apr 01, 2014 at 09:21:46PM +0400, Andrey Borzenkov wrote:
> В Wed, 26 Feb 2014 10:31:08 -0800
> Ram Pai  пишет:
> 
> > From: Anton Blanchard 
> > 
> > Fix warnings when building powerpc linux loader 64bit
> > 
> > Signed-off-by: Ram Pai 
> > From: Anton Blanchard 
> > ---
> >  grub-core/loader/powerpc/ieee1275/linux.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/grub-core/loader/powerpc/ieee1275/linux.c 
> > b/grub-core/loader/powerpc/ieee1275/linux.c
> > index 4a14f66..3d6a61e 100644
> > --- a/grub-core/loader/powerpc/ieee1275/linux.c
> > +++ b/grub-core/loader/powerpc/ieee1275/linux.c
> > @@ -141,8 +141,8 @@ grub_linux_boot (void)
> >grub_ieee1275_set_property (grub_ieee1275_chosen, "bootargs", linux_args,
> >   grub_strlen (linux_args) + 1, &actual);
> >  
> > -  grub_dprintf ("loader", "Entry point: 0x%x\n", linux_entry);
> > -  grub_dprintf ("loader", "Initrd at: 0x%x, size 0x%x\n", initrd_addr,
> > +  grub_dprintf ("loader", "Entry point: 0x%lx\n", linux_entry);
> 
> I guess using PRIxGRUB_ADDR is more consistent - it can now be both 32 and 64 
> bits.
> 
> > +  grub_dprintf ("loader", "Initrd at: 0x%lx, size 0x%lx\n", initrd_addr,
> > initrd_size);
> 
> Ditto and PRIuGRUB_SIZE.
> 
> >grub_dprintf ("loader", "Boot arguments: %s\n", linux_args);
> >grub_dprintf ("loader", "Jumping to Linux...\n");
> > @@ -360,7 +360,7 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ 
> > ((unused)),
> >if (addr == (grub_addr_t) -1)
> >   goto fail;
> >  
> > -  grub_dprintf ("loader", "Loading initrd at 0x%x, size 0x%x\n", addr, 
> > size);
> > +  grub_dprintf ("loader", "Loading initrd at 0x%lx, size 0x%lx\n", addr, 
> > size);
> >  
> 
> Ditto.
> 
> >if (grub_initrd_load (&initrd_ctx, argv, (void *) addr))
> >  goto fail;

ok. will do.
RP


___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [RFC PATCH 09/23] Fix warnings when building powerpc linux loader 64bit

2014-04-01 Thread Andrey Borzenkov 
В Wed, 26 Feb 2014 10:31:08 -0800
Ram Pai  пишет:

> From: Anton Blanchard 
> 
> Fix warnings when building powerpc linux loader 64bit
> 
> Signed-off-by: Ram Pai 
> From: Anton Blanchard 
> ---
>  grub-core/loader/powerpc/ieee1275/linux.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/grub-core/loader/powerpc/ieee1275/linux.c 
> b/grub-core/loader/powerpc/ieee1275/linux.c
> index 4a14f66..3d6a61e 100644
> --- a/grub-core/loader/powerpc/ieee1275/linux.c
> +++ b/grub-core/loader/powerpc/ieee1275/linux.c
> @@ -141,8 +141,8 @@ grub_linux_boot (void)
>grub_ieee1275_set_property (grub_ieee1275_chosen, "bootargs", linux_args,
> grub_strlen (linux_args) + 1, &actual);
>  
> -  grub_dprintf ("loader", "Entry point: 0x%x\n", linux_entry);
> -  grub_dprintf ("loader", "Initrd at: 0x%x, size 0x%x\n", initrd_addr,
> +  grub_dprintf ("loader", "Entry point: 0x%lx\n", linux_entry);

I guess using PRIxGRUB_ADDR is more consistent - it can now be both 32 and 64 
bits.

> +  grub_dprintf ("loader", "Initrd at: 0x%lx, size 0x%lx\n", initrd_addr,
>   initrd_size);

Ditto and PRIuGRUB_SIZE.

>grub_dprintf ("loader", "Boot arguments: %s\n", linux_args);
>grub_dprintf ("loader", "Jumping to Linux...\n");
> @@ -360,7 +360,7 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ 
> ((unused)),
>if (addr == (grub_addr_t) -1)
>   goto fail;
>  
> -  grub_dprintf ("loader", "Loading initrd at 0x%x, size 0x%x\n", addr, size);
> +  grub_dprintf ("loader", "Loading initrd at 0x%lx, size 0x%lx\n", addr, 
> size);
>  

Ditto.

>if (grub_initrd_load (&initrd_ctx, argv, (void *) addr))
>  goto fail;


___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

[RFC PATCH 09/23] Fix warnings when building powerpc linux loader 64bit

2014-02-26 Thread Ram Pai 
From: Anton Blanchard 

Fix warnings when building powerpc linux loader 64bit

Signed-off-by: Ram Pai 
From: Anton Blanchard 
---
 grub-core/loader/powerpc/ieee1275/linux.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/grub-core/loader/powerpc/ieee1275/linux.c 
b/grub-core/loader/powerpc/ieee1275/linux.c
index 4a14f66..3d6a61e 100644
--- a/grub-core/loader/powerpc/ieee1275/linux.c
+++ b/grub-core/loader/powerpc/ieee1275/linux.c
@@ -141,8 +141,8 @@ grub_linux_boot (void)
   grub_ieee1275_set_property (grub_ieee1275_chosen, "bootargs", linux_args,
  grub_strlen (linux_args) + 1, &actual);
 
-  grub_dprintf ("loader", "Entry point: 0x%x\n", linux_entry);
-  grub_dprintf ("loader", "Initrd at: 0x%x, size 0x%x\n", initrd_addr,
+  grub_dprintf ("loader", "Entry point: 0x%lx\n", linux_entry);
+  grub_dprintf ("loader", "Initrd at: 0x%lx, size 0x%lx\n", initrd_addr,
initrd_size);
   grub_dprintf ("loader", "Boot arguments: %s\n", linux_args);
   grub_dprintf ("loader", "Jumping to Linux...\n");
@@ -360,7 +360,7 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ 
((unused)),
   if (addr == (grub_addr_t) -1)
  goto fail;
 
-  grub_dprintf ("loader", "Loading initrd at 0x%x, size 0x%x\n", addr, size);
+  grub_dprintf ("loader", "Loading initrd at 0x%lx, size 0x%lx\n", addr, size);
 
   if (grub_initrd_load (&initrd_ctx, argv, (void *) addr))
 goto fail;
-- 
1.8.5.3


___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel