Re: Bug in multiboot_mbi2.c
On Mon, Jun 21, 2010 at 07:22:00PM -0700, Seth Goldberg wrote: The code that constructs the framebuffer info has a nasty bug where the field position and mask size for red are set to the GREEN values: tag-common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB; tag-common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB; -- tag-framebuffer_red_field_position = mode_info.green_field_pos; -- tag-framebuffer_red_mask_size = mode_info.green_mask_size; tag-framebuffer_green_field_position = mode_info.green_field_pos; tag-framebuffer_green_mask_size = mode_info.green_mask_size; tag-framebuffer_blue_field_position = mode_info.blue_field_pos; tag-framebuffer_blue_mask_size = mode_info.blue_mask_size; Fixed, thanks (as well as the redundant assignment you mentioned in a follow-up). I fixed the same bug in loader/i386/multiboot_mbi.c too. -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: Bug in multiboot_mbi2.c
What, you want to control color channels independently? Aren't monochromatic amber displays good enough any more? :) On Mon, Jun 21, 2010 at 9:22 PM, Seth Goldberg seth.goldb...@oracle.com wrote: The code that constructs the framebuffer info has a nasty bug where the field position and mask size for red are set to the GREEN values: tag-common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB; tag-common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB; -- tag-framebuffer_red_field_position = mode_info.green_field_pos; -- tag-framebuffer_red_mask_size = mode_info.green_mask_size; tag-framebuffer_green_field_position = mode_info.green_field_pos; tag-framebuffer_green_mask_size = mode_info.green_mask_size; tag-framebuffer_blue_field_position = mode_info.blue_field_pos; tag-framebuffer_blue_mask_size = mode_info.blue_mask_size; --S ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: Bug in multiboot_mbi2.c
Quoting richardvo...@gmail.com, who wrote the following on Tue, 22 Jun 2010: What, you want to control color channels independently? Aren't monochromatic amber displays good enough any more? As much as I enjoyed that amber goodness, I would like to be able to see red :). --S ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Bug in multiboot_mbi2.c
The code that constructs the framebuffer info has a nasty bug where the field position and mask size for red are set to the GREEN values: tag-common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB; tag-common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB; -- tag-framebuffer_red_field_position = mode_info.green_field_pos; -- tag-framebuffer_red_mask_size = mode_info.green_mask_size; tag-framebuffer_green_field_position = mode_info.green_field_pos; tag-framebuffer_green_mask_size = mode_info.green_mask_size; tag-framebuffer_blue_field_position = mode_info.blue_field_pos; tag-framebuffer_blue_mask_size = mode_info.blue_mask_size; --S ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: Bug in multiboot_mbi2.c
BTW, while we're at it, we can remove the redundant tag-common.framebuffer_type assignment :). --S Quoting Seth Goldberg, who wrote the following on Mon, 21 Jun 2010: The code that constructs the framebuffer info has a nasty bug where the field position and mask size for red are set to the GREEN values: tag-common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB; tag-common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB; -- tag-framebuffer_red_field_position = mode_info.green_field_pos; -- tag-framebuffer_red_mask_size = mode_info.green_mask_size; tag-framebuffer_green_field_position = mode_info.green_field_pos; tag-framebuffer_green_mask_size = mode_info.green_mask_size; tag-framebuffer_blue_field_position = mode_info.blue_field_pos; tag-framebuffer_blue_mask_size = mode_info.blue_mask_size; --S ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
