Re: GRUB Loading kernel... message

2008-07-06 Thread Robert Millan
On Sat, Jul 05, 2008 at 07:35:15PM -0400, Pavel Roskin wrote:
 On Sat, 2008-07-05 at 19:24 -0400, Isaac Dupree wrote:
 
  .  Although, looking at the files, boot/i386/pc/boot.S outputs GRUB  
  and boot/i386/pc/diskboot.S outputs Loading kernel, so the parts 
  actually mean different things: maybe it's important that it prints 
  GRUB  first in case it never prints anything else?  perhaps there are 
  other possible code-paths?  In any case, then maybe it should say
  GRUB Loading GRUB kernel, or, GRUB Loading itself :-)
 
 Considering that diskboot.img is limited to 512 bytes,

But it currently fits, and we don't gain anything by saving space in that
sector.

-- 
Robert Millan

GPLv2 I know my rights; I want my phone call!
DRM What good is a phone call… if you are unable to speak?
(as seen on /.)


___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel


Re: GRUB Loading kernel... message

2008-07-06 Thread Robert Millan
On Sat, Jul 05, 2008 at 07:24:56PM -0400, Isaac Dupree wrote:
 I thought I remembered somewhere a discussion how the message
 GRUB Loading kernel
 is confusing, because it doesn't say what kernel it's loading, and grub 
 loads lots of kernels

I think this is not accurate.  GRUB loads payloads.  It doesn't care if they're
a standalone OS like invaders.elf or the kernel part of an OS that resides on
disk/network/whatever.

-- 
Robert Millan

GPLv2 I know my rights; I want my phone call!
DRM What good is a phone call… if you are unable to speak?
(as seen on /.)


___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel


Re: GRUB Loading kernel... message

2008-07-06 Thread Robert Millan
On Sun, Jul 06, 2008 at 08:33:03PM +0200, Robert Millan wrote:
 On Sat, Jul 05, 2008 at 07:35:15PM -0400, Pavel Roskin wrote:
  On Sat, 2008-07-05 at 19:24 -0400, Isaac Dupree wrote:
  
   .  Although, looking at the files, boot/i386/pc/boot.S outputs GRUB  
   and boot/i386/pc/diskboot.S outputs Loading kernel, so the parts 
   actually mean different things: maybe it's important that it prints 
   GRUB  first in case it never prints anything else?  perhaps there are 
   other possible code-paths?  In any case, then maybe it should say
   GRUB Loading GRUB kernel, or, GRUB Loading itself :-)
  
  Considering that diskboot.img is limited to 512 bytes,
 
 But it currently fits, and we don't gain anything by saving space in that
 sector.

Anyway, GRUB loading sounds fine to me.

-- 
Robert Millan

GPLv2 I know my rights; I want my phone call!
DRM What good is a phone call… if you are unable to speak?
(as seen on /.)


___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel


GRUB Loading kernel... message

2008-07-05 Thread Isaac Dupree

I thought I remembered somewhere a discussion how the message
GRUB Loading kernel
is confusing, because it doesn't say what kernel it's loading, and grub 
loads lots of kernels (this message means that the kernel is a core 
part of GRUB, and the subject GRUB the message mentions is different: 
it's some early loading code.)  There is an argument that kernel does 
not mean the same thing as Linux kernel, which is quite right: that's 
why the message is not at all incorrect, just highly ambiguous.  It 
seems like it should be

Loading GRUB kernel
.  Although, looking at the files, boot/i386/pc/boot.S outputs GRUB  
and boot/i386/pc/diskboot.S outputs Loading kernel, so the parts 
actually mean different things: maybe it's important that it prints 
GRUB  first in case it never prints anything else?  perhaps there are 
other possible code-paths?  In any case, then maybe it should say

GRUB Loading GRUB kernel, or, GRUB Loading itself :-)
to preserve the usefulness and increase the clarity. (Albeit, someone 
who doesn't know how GRUB works might be confused by how it can be 
loading itself: it's actually one part of GRUB loading a bigger part of 
GRUB.  But we'll never be able to properly explain that to a 
nontechnical person :-)


(Am I missing something, since this is my first time looking at GRUB code?)

-Isaac


___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel


Re: GRUB Loading kernel... message

2008-07-05 Thread Pavel Roskin
On Sat, 2008-07-05 at 19:24 -0400, Isaac Dupree wrote:

 .  Although, looking at the files, boot/i386/pc/boot.S outputs GRUB  
 and boot/i386/pc/diskboot.S outputs Loading kernel, so the parts 
 actually mean different things: maybe it's important that it prints 
 GRUB  first in case it never prints anything else?  perhaps there are 
 other possible code-paths?  In any case, then maybe it should say
 GRUB Loading GRUB kernel, or, GRUB Loading itself :-)

Considering that diskboot.img is limited to 512 bytes, I'd rather go
with loading without kernel.  The result would be GRUB loading,
which would look better than your proposals.  The saved bytes could be
used for some good purpose eventually.

-- 
Regards,
Pavel Roskin


___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel


Re: GRUB Loading kernel... message

2008-07-05 Thread Isaac Dupree

Pavel Roskin wrote:

On Sat, 2008-07-05 at 19:24 -0400, Isaac Dupree wrote:

.  Although, looking at the files, boot/i386/pc/boot.S outputs GRUB  
and boot/i386/pc/diskboot.S outputs Loading kernel, so the parts 
actually mean different things: maybe it's important that it prints 
GRUB  first in case it never prints anything else?  perhaps there are 
other possible code-paths?  In any case, then maybe it should say

GRUB Loading GRUB kernel, or, GRUB Loading itself :-)


Considering that diskboot.img is limited to 512 bytes, I'd rather go
with loading without kernel.  The result would be GRUB loading,
which would look better than your proposals.  The saved bytes could be
used for some good purpose eventually.


I like that wording: concise and clear (although maybe so concise that 
it gets hard for a user having a problem, to Google for it).


By the way, currently the Loading seems to have the first letter 
capitalized (I don't care either way)


-Isaac


___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel