Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
On Thu, Aug 24, 2023 at 06:08:12PM -0400, Stéphane Fontaine wrote: > The patch had to be regenerated for grub 2.06 The GRUB 2.06 is no longer maintained by upstream maintainers due to lack of resources. The fix is in the latest master. Please send patches using "git send-email" next time. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
LGTM Le ven. 25 août 2023, 00:09, Stéphane Fontaine a écrit : > The patch had to be regenerated for grub 2.06 > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
The patch had to be regenerated for grub 2.06 Suggested-by: Eric Sandeen Suggested-by: Lukas Czerner Signed-off-by: Javier Martinez Canillas Regenerated-by: Stephane Fontaine --- diff -ur grub-2.06-orig/grub-core/fs/ext2.c grub-2.06-new/grub-core/fs/ext2.c --- grub-2.06-orig/grub-core/fs/ext2.c 2021-06-01 11:16:48.0 -0400 +++ grub-2.06-new/grub-core/fs/ext2.c 2023-08-24 16:54:31.890991253 -0400 @@ -103,6 +103,7 @@ #define EXT4_FEATURE_INCOMPAT_64BIT 0x0080 #define EXT4_FEATURE_INCOMPAT_MMP 0x0100 #define EXT4_FEATURE_INCOMPAT_FLEX_BG 0x0200 +#define EXT4_FEATURE_INCOMPAT_CSUM_SEED0x2000 #define EXT4_FEATURE_INCOMPAT_ENCRYPT 0x1 /* The set of back-incompatible features this driver DOES support. Add (OR) @@ -112,6 +113,7 @@ | EXT4_FEATURE_INCOMPAT_FLEX_BG \ | EXT2_FEATURE_INCOMPAT_META_BG \ | EXT4_FEATURE_INCOMPAT_64BIT \ + | EXT4_FEATURE_INCOMPAT_CSUM_SEED \ | EXT4_FEATURE_INCOMPAT_ENCRYPT) /* List of rationales for the ignored "incompatible" features: * needs_recovery: Not really back-incompatible - was added as such to forbid @@ -123,6 +125,12 @@ * mmp:Not really back-incompatible - was added as such to * avoid multiple read-write mounts. Safe to ignore for this * RO driver. + * checksum seed: Not really back-incompatible - was added to allow tools + * such as tune2fs to change the UUID on a mounted metadata + * checksummed filesystem. Safe to ignore for now since the + * driver doesn't support checksum verification. But it must + * be removed from this list if that support is added later. + * */ #define EXT2_DRIVER_IGNORED_INCOMPAT ( EXT3_FEATURE_INCOMPAT_RECOVER \ | EXT4_FEATURE_INCOMPAT_MMP) ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
On Fri, Jun 11, 2021 at 09:36:16PM +0200, Javier Martinez Canillas wrote: > This incompat feature is used to denote that the filesystem stored its > metadata checksum seed in the superblock. This is used to allow tune2fs > to change the UUID on a mounted metadata_csum filesystem without having > to rewrite all the disk metadata. > > But GRUB doesn't use the metadata checksum in anyway, so can just ignore > this feature if is enabled. This is consistent with GRUB filesystem code > in general which just does a best effort to access the filesystem's data. > > It may be removed from the ignored list in the future if supports to do > metadata checksumming verification is added to the read-only FS driver. > > Suggested-by: Eric Sandeen > Suggested-by: Lukas Czerner > Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
On Fri, Jun 11, 2021 at 09:36:16PM +0200, Javier Martinez Canillas wrote:
> This incompat feature is used to denote that the filesystem stored its
> metadata checksum seed in the superblock. This is used to allow tune2fs
> to change the UUID on a mounted metadata_csum filesystem without having
> to rewrite all the disk metadata.
>
> But GRUB doesn't use the metadata checksum in anyway, so can just ignore
> this feature if is enabled. This is consistent with GRUB filesystem code
> in general which just does a best effort to access the filesystem's data.
>
> It may be removed from the ignored list in the future if supports to do
> metadata checksumming verification is added to the read-only FS driver.
Thanks,
you can add
Reviewed-by: Lukas Czerner
-Lukas
>
> Suggested-by: Eric Sandeen
> Suggested-by: Lukas Czerner
> Signed-off-by: Javier Martinez Canillas
> ---
>
> grub-core/fs/ext2.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/grub-core/fs/ext2.c b/grub-core/fs/ext2.c
> index 848bf939dba..238b2d76e38 100644
> --- a/grub-core/fs/ext2.c
> +++ b/grub-core/fs/ext2.c
> @@ -103,6 +103,7 @@ GRUB_MOD_LICENSE ("GPLv3+");
> #define EXT4_FEATURE_INCOMPAT_64BIT 0x0080
> #define EXT4_FEATURE_INCOMPAT_MMP0x0100
> #define EXT4_FEATURE_INCOMPAT_FLEX_BG0x0200
> +#define EXT4_FEATURE_INCOMPAT_CSUM_SEED 0x2000
> #define EXT4_FEATURE_INCOMPAT_ENCRYPT 0x1
>
> /* The set of back-incompatible features this driver DOES support. Add (OR)
> @@ -123,9 +124,16 @@ GRUB_MOD_LICENSE ("GPLv3+");
> * mmp:Not really back-incompatible - was added as such to
> * avoid multiple read-write mounts. Safe to ignore for this
> * RO driver.
> + * checksum seed: Not really back-incompatible - was added to allow tools
> + * such as tune2fs to change the UUID on a mounted metadata
> + * checksummed filesystem. Safe to ignore for now since the
> + * driver doesn't support checksum verification. But it must
> + * be removed from this list if that support is added later.
> + *
> */
> #define EXT2_DRIVER_IGNORED_INCOMPAT ( EXT3_FEATURE_INCOMPAT_RECOVER \
> - | EXT4_FEATURE_INCOMPAT_MMP)
> + | EXT4_FEATURE_INCOMPAT_MMP \
> + | EXT4_FEATURE_INCOMPAT_CSUM_SEED)
>
>
> #define EXT3_JOURNAL_MAGIC_NUMBER0xc03b3998U
> --
> 2.31.1
>
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
* On 6/11/21 9:36 PM, Javier Martinez Canillas wrote: > This incompat feature is used to denote that the filesystem stored its > metadata checksum seed in the superblock. This is used to allow tune2fs > to change the UUID on a mounted metadata_csum filesystem without having > to rewrite all the disk metadata. > > But GRUB doesn't use the metadata checksum in anyway, so can just ignore any way > this feature if is enabled. This is consistent with GRUB filesystem code if it is > in general which just does a best effort to access the filesystem's data. > > It may be removed from the ignored list in the future if supports to do > metadata checksumming verification is added to the read-only FS driver. support or better yet: support for metadata checksum verification Mihai OpenPGP_signature Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
