Re: [RFC PATCH 11/23] Fix powerpc setjmp/longjmp 64bit issues
On Tue, Apr 01, 2014 at 09:27:19PM +0400, Andrey Borzenkov wrote: В Wed, 26 Feb 2014 10:31:10 -0800 Ram Pai linux...@us.ibm.com пишет: From: Anton Blanchard an...@samba.org Fix powerpc setjmp/longjmp 64bit issues Signed-off-by: Ram Pai linux...@us.ibm.com From: Anton Blanchard an...@samba.org --- grub-core/lib/powerpc/setjmp.S | 94 +++--- 1 file changed, 52 insertions(+), 42 deletions(-) diff --git a/grub-core/lib/powerpc/setjmp.S b/grub-core/lib/powerpc/setjmp.S index 716b563..51fcae9 100644 --- a/grub-core/lib/powerpc/setjmp.S +++ b/grub-core/lib/powerpc/setjmp.S @@ -25,33 +25,43 @@ GRUB_MOD_LICENSE GPLv3+ .text +#if defined( __powerpc64__ ) || defined( __powerpc64le__ ) Where is __powerpc64__ defined? Your previous patch adds only __powerpc64le__ and it does exist in current code as well? It is already defined even prior to this patch series. in this patch series i am just adding __powerpc64le__ . -- Ram Pai ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [RFC PATCH 11/23] Fix powerpc setjmp/longjmp 64bit issues
В Wed, 2 Apr 2014 10:06:05 -0700 Ram Pai linux...@us.ibm.com пишет: On Tue, Apr 01, 2014 at 09:27:19PM +0400, Andrey Borzenkov wrote: В Wed, 26 Feb 2014 10:31:10 -0800 Ram Pai linux...@us.ibm.com пишет: From: Anton Blanchard an...@samba.org Fix powerpc setjmp/longjmp 64bit issues Signed-off-by: Ram Pai linux...@us.ibm.com From: Anton Blanchard an...@samba.org --- grub-core/lib/powerpc/setjmp.S | 94 +++--- 1 file changed, 52 insertions(+), 42 deletions(-) diff --git a/grub-core/lib/powerpc/setjmp.S b/grub-core/lib/powerpc/setjmp.S index 716b563..51fcae9 100644 --- a/grub-core/lib/powerpc/setjmp.S +++ b/grub-core/lib/powerpc/setjmp.S @@ -25,33 +25,43 @@ GRUB_MOD_LICENSE GPLv3+ .text +#if defined( __powerpc64__ ) || defined( __powerpc64le__ ) Where is __powerpc64__ defined? Your previous patch adds only __powerpc64le__ and it does exist in current code as well? It is already defined even prior to this patch series. Where? bor@opensuse:~/src/grub grep -rw __powerpc64__ . bor@opensuse:~/src/grub in this patch series i am just adding __powerpc64le__ . ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [RFC PATCH 11/23] Fix powerpc setjmp/longjmp 64bit issues
On Wed, Apr 02, 2014 at 09:19:59PM +0400, Andrey Borzenkov wrote: В Wed, 2 Apr 2014 10:06:05 -0700 Ram Pai linux...@us.ibm.com пишет: On Tue, Apr 01, 2014 at 09:27:19PM +0400, Andrey Borzenkov wrote: В Wed, 26 Feb 2014 10:31:10 -0800 Ram Pai linux...@us.ibm.com пишет: From: Anton Blanchard an...@samba.org Fix powerpc setjmp/longjmp 64bit issues Signed-off-by: Ram Pai linux...@us.ibm.com From: Anton Blanchard an...@samba.org --- grub-core/lib/powerpc/setjmp.S | 94 +++--- 1 file changed, 52 insertions(+), 42 deletions(-) diff --git a/grub-core/lib/powerpc/setjmp.S b/grub-core/lib/powerpc/setjmp.S index 716b563..51fcae9 100644 --- a/grub-core/lib/powerpc/setjmp.S +++ b/grub-core/lib/powerpc/setjmp.S @@ -25,33 +25,43 @@ GRUB_MOD_LICENSE GPLv3+ .text +#if defined( __powerpc64__ ) || defined( __powerpc64le__ ) Where is __powerpc64__ defined? Your previous patch adds only __powerpc64le__ and it does exist in current code as well? It is already defined even prior to this patch series. Where? just checked. Looks like it is defined automatically by the compiler automatically when -m64 is specified. RP ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [RFC PATCH 11/23] Fix powerpc setjmp/longjmp 64bit issues
В Wed, 2 Apr 2014 10:48:34 -0700 Ram Pai linux...@us.ibm.com пишет: On Wed, Apr 02, 2014 at 09:19:59PM +0400, Andrey Borzenkov wrote: В Wed, 2 Apr 2014 10:06:05 -0700 Ram Pai linux...@us.ibm.com пишет: On Tue, Apr 01, 2014 at 09:27:19PM +0400, Andrey Borzenkov wrote: В Wed, 26 Feb 2014 10:31:10 -0800 Ram Pai linux...@us.ibm.com пишет: From: Anton Blanchard an...@samba.org Fix powerpc setjmp/longjmp 64bit issues Signed-off-by: Ram Pai linux...@us.ibm.com From: Anton Blanchard an...@samba.org --- grub-core/lib/powerpc/setjmp.S | 94 +++--- 1 file changed, 52 insertions(+), 42 deletions(-) diff --git a/grub-core/lib/powerpc/setjmp.S b/grub-core/lib/powerpc/setjmp.S index 716b563..51fcae9 100644 --- a/grub-core/lib/powerpc/setjmp.S +++ b/grub-core/lib/powerpc/setjmp.S @@ -25,33 +25,43 @@ GRUB_MOD_LICENSE GPLv3+ .text +#if defined( __powerpc64__ ) || defined( __powerpc64le__ ) Where is __powerpc64__ defined? Your previous patch adds only __powerpc64le__ and it does exist in current code as well? It is already defined even prior to this patch series. Where? just checked. Looks like it is defined automatically by the compiler automatically when -m64 is specified. grub does not use -m64 on powerpc. Existing target is 32 bit. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [RFC PATCH 11/23] Fix powerpc setjmp/longjmp 64bit issues
On Wed, Apr 02, 2014 at 09:56:54PM +0400, Andrey Borzenkov wrote: В Wed, 2 Apr 2014 10:48:34 -0700 Ram Pai linux...@us.ibm.com пишет: On Wed, Apr 02, 2014 at 09:19:59PM +0400, Andrey Borzenkov wrote: В Wed, 2 Apr 2014 10:06:05 -0700 Ram Pai linux...@us.ibm.com пишет: On Tue, Apr 01, 2014 at 09:27:19PM +0400, Andrey Borzenkov wrote: В Wed, 26 Feb 2014 10:31:10 -0800 Ram Pai linux...@us.ibm.com пишет: From: Anton Blanchard an...@samba.org Fix powerpc setjmp/longjmp 64bit issues Signed-off-by: Ram Pai linux...@us.ibm.com From: Anton Blanchard an...@samba.org --- grub-core/lib/powerpc/setjmp.S | 94 +++--- 1 file changed, 52 insertions(+), 42 deletions(-) diff --git a/grub-core/lib/powerpc/setjmp.S b/grub-core/lib/powerpc/setjmp.S index 716b563..51fcae9 100644 --- a/grub-core/lib/powerpc/setjmp.S +++ b/grub-core/lib/powerpc/setjmp.S @@ -25,33 +25,43 @@ GRUB_MOD_LICENSE GPLv3+ .text +#if defined( __powerpc64__ ) || defined( __powerpc64le__ ) Where is __powerpc64__ defined? Your previous patch adds only __powerpc64le__ and it does exist in current code as well? It is already defined even prior to this patch series. Where? just checked. Looks like it is defined automatically by the compiler automatically when -m64 is specified. grub does not use -m64 on powerpc. Existing target is 32 bit. Confirmed with our toolchain folks. the gcc compiler for LE targets assumes -m64 by default. -m32 is not supported for LE target. However, it does feel a little kludgy to have __powerpc64__ defined by the compiler and __powerpc64le__ by my patches. Have to figure out a way to clean it up. RP ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [RFC PATCH 11/23] Fix powerpc setjmp/longjmp 64bit issues
В Wed, 26 Feb 2014 10:31:10 -0800 Ram Pai linux...@us.ibm.com пишет: From: Anton Blanchard an...@samba.org Fix powerpc setjmp/longjmp 64bit issues Signed-off-by: Ram Pai linux...@us.ibm.com From: Anton Blanchard an...@samba.org --- grub-core/lib/powerpc/setjmp.S | 94 +++--- 1 file changed, 52 insertions(+), 42 deletions(-) diff --git a/grub-core/lib/powerpc/setjmp.S b/grub-core/lib/powerpc/setjmp.S index 716b563..51fcae9 100644 --- a/grub-core/lib/powerpc/setjmp.S +++ b/grub-core/lib/powerpc/setjmp.S @@ -25,33 +25,43 @@ GRUB_MOD_LICENSE GPLv3+ .text +#if defined( __powerpc64__ ) || defined( __powerpc64le__ ) Where is __powerpc64__ defined? Your previous patch adds only __powerpc64le__ and it does exist in current code as well? ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
