Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code
On 22/10/2018 13:16, Daniel Kiper wrote: > On Fri, Oct 19, 2018 at 05:52:44PM +0200, Juergen Gross wrote: >> On 19/10/2018 17:33, Roger Pau Monné wrote: >>> On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: Add the hooks to current code needed for Xen PVH. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 36 +++ grub-core/kern/i386/xen/startup_pvh.S | 29 grub-core/kern/xen/init.c | 6 ++ include/grub/i386/xenpvh/kernel.h | 30 + include/grub/xen.h| 6 ++ 5 files changed, 107 insertions(+) create mode 100644 grub-core/kern/i386/xen/pvh.c create mode 100644 grub-core/kern/i386/xen/startup_pvh.S create mode 100644 include/grub/i386/xenpvh/kernel.h diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c new file mode 100644 index 0..182ef95f9 --- /dev/null +++ b/grub-core/kern/i386/xen/pvh.c @@ -0,0 +1,36 @@ +/* + * GRUB -- GRand Unified Bootloader + * Copyright (C) 2011 Free Software Foundation, Inc. >>> >>> Isn't this header (and the ones below) kind of off at least year >>> wise? >> >> Hmm, only a little bit :-) >> >> Will update. > > Please do this for all headers in the patchset That was my plan :-) Juergen ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code
On Fri, Oct 19, 2018 at 05:52:44PM +0200, Juergen Gross wrote: > On 19/10/2018 17:33, Roger Pau Monné wrote: > > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > >> Add the hooks to current code needed for Xen PVH. > >> > >> Signed-off-by: Juergen Gross > >> --- > >> grub-core/kern/i386/xen/pvh.c | 36 > >> +++ > >> grub-core/kern/i386/xen/startup_pvh.S | 29 > >> grub-core/kern/xen/init.c | 6 ++ > >> include/grub/i386/xenpvh/kernel.h | 30 + > >> include/grub/xen.h| 6 ++ > >> 5 files changed, 107 insertions(+) > >> create mode 100644 grub-core/kern/i386/xen/pvh.c > >> create mode 100644 grub-core/kern/i386/xen/startup_pvh.S > >> create mode 100644 include/grub/i386/xenpvh/kernel.h > >> > >> diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c > >> new file mode 100644 > >> index 0..182ef95f9 > >> --- /dev/null > >> +++ b/grub-core/kern/i386/xen/pvh.c > >> @@ -0,0 +1,36 @@ > >> +/* > >> + * GRUB -- GRand Unified Bootloader > >> + * Copyright (C) 2011 Free Software Foundation, Inc. > > > > Isn't this header (and the ones below) kind of off at least year > > wise? > > Hmm, only a little bit :-) > > Will update. Please do this for all headers in the patchset Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code
On 19/10/2018 17:33, Roger Pau Monné wrote: > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: >> Add the hooks to current code needed for Xen PVH. >> >> Signed-off-by: Juergen Gross >> --- >> grub-core/kern/i386/xen/pvh.c | 36 >> +++ >> grub-core/kern/i386/xen/startup_pvh.S | 29 >> grub-core/kern/xen/init.c | 6 ++ >> include/grub/i386/xenpvh/kernel.h | 30 + >> include/grub/xen.h| 6 ++ >> 5 files changed, 107 insertions(+) >> create mode 100644 grub-core/kern/i386/xen/pvh.c >> create mode 100644 grub-core/kern/i386/xen/startup_pvh.S >> create mode 100644 include/grub/i386/xenpvh/kernel.h >> >> diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c >> new file mode 100644 >> index 0..182ef95f9 >> --- /dev/null >> +++ b/grub-core/kern/i386/xen/pvh.c >> @@ -0,0 +1,36 @@ >> +/* >> + * GRUB -- GRand Unified Bootloader >> + * Copyright (C) 2011 Free Software Foundation, Inc. > > Isn't this header (and the ones below) kind of off at least year > wise? Hmm, only a little bit :-) Will update. Juergen ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code
On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > Add the hooks to current code needed for Xen PVH. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 36 > +++ > grub-core/kern/i386/xen/startup_pvh.S | 29 > grub-core/kern/xen/init.c | 6 ++ > include/grub/i386/xenpvh/kernel.h | 30 + > include/grub/xen.h| 6 ++ > 5 files changed, 107 insertions(+) > create mode 100644 grub-core/kern/i386/xen/pvh.c > create mode 100644 grub-core/kern/i386/xen/startup_pvh.S > create mode 100644 include/grub/i386/xenpvh/kernel.h > > diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c > new file mode 100644 > index 0..182ef95f9 > --- /dev/null > +++ b/grub-core/kern/i386/xen/pvh.c > @@ -0,0 +1,36 @@ > +/* > + * GRUB -- GRand Unified Bootloader > + * Copyright (C) 2011 Free Software Foundation, Inc. Isn't this header (and the ones below) kind of off at least year wise? Roger. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code
On 19/10/2018 14:05, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: >> Add the hooks to current code needed for Xen PVH. > > I am not against the code itself but it would be nice to know why you > add, AIUI, just stubs here which will be filled with proper code later. You requested a split of the patch adding PVH stuff. This is the result of that request. Juergen ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
