Re: Anonymous commit (empty Author and Committer)
"Lennart Sorensen" writes: > On Sat, Oct 31, 2015 at 08:24:06AM +0300, Andrei Borzenkov wrote: >> If we decide to fix this commit it is better done now, while it is the last >> one. It is annoying but do you have suggestion how it can be done >> differently? > > Well the only options are: > > 1) Leave it alone > 2) Break the tree of anyone that already pulled. (Posting instructions on > how to fix it would at least be nice then). > > Not sure how many people regularly pull the tree. Is the discussion still require attention by Git folks for their help? If not, could you take this back to savannah specific mailing list? Thanks. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
On Sat, Oct 31, 2015 at 08:24:06AM +0300, Andrei Borzenkov wrote: > If we decide to fix this commit it is better done now, while it is the last > one. It is annoying but do you have suggestion how it can be done > differently? Well the only options are: 1) Leave it alone 2) Break the tree of anyone that already pulled. (Posting instructions on how to fix it would at least be nice then). Not sure how many people regularly pull the tree. -- Len Sorensen ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
Opened Savannah support ticket Le 31 oct. 2015 2:54 PM, "Andrei Borzenkov" a écrit : > 30.10.2015 23:19, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> >>> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>> On 30.10.2015 15:26, Andrei Borzenkov wrote: > See > > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > > > I was not even aware that this is possible. Is there anything on server > side that can prevent it? > > Would be good if commit were amended and force pushed to fix it. > > It is a bug in SGit. I'll investigate how it happened >>> >> I don't have non-fast-forward rights. Does someone from savannah-users >> have them? Could he just delete this commit? >> > > Looking at mail archives, non-fast-forward is global repository property > and disabled by default. We probably need to open Savannah ticket to get it > temporary enabled. > > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
30.10.2015 23:19, Vladimir 'φ-coder/phcoder' Serbinenko пишет: On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.10.2015 15:26, Andrei Borzenkov wrote: See http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac I was not even aware that this is possible. Is there anything on server side that can prevent it? Would be good if commit were amended and force pushed to fix it. It is a bug in SGit. I'll investigate how it happened I don't have non-fast-forward rights. Does someone from savannah-users have them? Could he just delete this commit? Looking at mail archives, non-fast-forward is global repository property and disabled by default. We probably need to open Savannah ticket to get it temporary enabled. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
30.10.2015 23:59, Lennart Sorensen пишет: On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.10.2015 15:26, Andrei Borzenkov wrote: See http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac I was not even aware that this is possible. Is there anything on server side that can prevent it? Would be good if commit were amended and force pushed to fix it. It is a bug in SGit. I'll investigate how it happened I don't have non-fast-forward rights. Does someone from savannah-users have them? Could he just delete this commit? If you do that, then anyone that already did a pull after it went in will have a broken tree. Rather annoying. If we decide to fix this commit it is better done now, while it is the last one. It is annoying but do you have suggestion how it can be done differently? ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
On 30 Oct 2015 9:06 pm, "Vladimir 'φ-coder/phcoder' Serbinenko" < phco...@gmail.com> wrote: > > On 30.10.2015 15:26, Andrei Borzenkov wrote: > > See > > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > > > > > > I was not even aware that this is possible. Is there anything on server > > side that can prevent it? > > > > Would be good if commit were amended and force pushed to fix it. > > > It is a bug in SGit. I'll investigate how it happened Turns out I didn't fill out my name and email after sgit reinstall and it happily made a commit with no name rather than bailing out like normal git does. I'll make a patch for sgit > > ___ > > Grub-devel mailing list > > Grub-devel@gnu.org > > https://lists.gnu.org/mailman/listinfo/grub-devel > > . > > > > ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > >> On 30.10.2015 15:26, Andrei Borzenkov wrote: > >>> See > >>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > >>> > >>> > >>> I was not even aware that this is possible. Is there anything on server > >>> side that can prevent it? > >>> > >>> Would be good if commit were amended and force pushed to fix it. > >>> > >> It is a bug in SGit. I'll investigate how it happened > > I don't have non-fast-forward rights. Does someone from savannah-users > have them? Could he just delete this commit? If you do that, then anyone that already did a pull after it went in will have a broken tree. Rather annoying. -- Len Sorensen ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 30.10.2015 15:26, Andrei Borzenkov wrote: >>> See >>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac >>> >>> >>> I was not even aware that this is possible. Is there anything on server >>> side that can prevent it? >>> >>> Would be good if commit were amended and force pushed to fix it. >>> >> It is a bug in SGit. I'll investigate how it happened I don't have non-fast-forward rights. Does someone from savannah-users have them? Could he just delete this commit? signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 30.10.2015 15:26, Andrei Borzenkov wrote: >> See >> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac >> >> >> I was not even aware that this is possible. Is there anything on server >> side that can prevent it? >> >> Would be good if commit were amended and force pushed to fix it. >> > It is a bug in SGit. I'll investigate how it happened >> ___ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >> . >> > > signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
On 30.10.2015 15:26, Andrei Borzenkov wrote: > See > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > > > I was not even aware that this is possible. Is there anything on server > side that can prevent it? > > Would be good if commit were amended and force pushed to fix it. > It is a bug in SGit. I'll investigate how it happened > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > . > signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
On Fri, Oct 30, 2015 at 05:26:00PM +0300, Andrei Borzenkov wrote: > See > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > > I was not even aware that this is possible. Is there anything on server side > that can prevent it? I would have thought that receive.fsckObjects would reject it, but seems that git-fsck does not complain about it at all, as it is otherwise syntactically valid (a space separating the zero-length name from the email, and <> surrounding the empty email). We do complain during "git commit" about an empty name. We don't seem to do so for blank emails, though. The only discussion I could find mentions that should probably disallow both[1]. I wonder how this commit was created in the first place (through git-commit, and we have an empty-name case that is not covered, or using a lower-level tool that bypasses the checks). -Peff [1] http://article.gmane.org/gmane.comp.version-control.git/261237 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: Anonymous commit (empty Author and Committer)
On Fri, 30 Oct 2015 17:26:00 +0300 Andrei Borzenkov wrote: > See > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > > I was not even aware that this is possible. Is there anything on > server side that can prevent it? A hook running on "update" event could check the commits being pushed and reject the update if some commit among those does not pass the necessary checks. Please see the githooks(5) manual page. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
