mips/*/time.h
Hi, In mips branch grub_cpu_idle() is provided by grub/mips/yeeloong/time.h and grub/mips/qemu-mips/time.h, but there's no grub/mips/time.h. This breaks mipsel-emu port, which lacks this definition. Why not merge mips/yeeloong/time.h and mips/qemu-mips/time.h into mips/time.h ? Both files are identical. -- Robert Millan The DRM opt-in fallacy: Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all. ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: mips/*/time.h
Robert Millan wrote: Hi, In mips branch grub_cpu_idle() is provided by grub/mips/yeeloong/time.h and grub/mips/qemu-mips/time.h, but there's no grub/mips/time.h. This breaks mipsel-emu port, which lacks this definition. Why not merge mips/yeeloong/time.h and mips/qemu-mips/time.h into mips/time.h ? Both files are identical. Both are stubs actually. Why does *-emu needs these files at all? *-emu doesn't see this type of machine info. It should just use host function for both cpu_idle and get_rtc -- Regards Vladimir 'φ-coder/phcoder' Serbinenko signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: mips/*/time.h
On Fri, Dec 04, 2009 at 05:24:02PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Robert Millan wrote: Hi, In mips branch grub_cpu_idle() is provided by grub/mips/yeeloong/time.h and grub/mips/qemu-mips/time.h, but there's no grub/mips/time.h. This breaks mipsel-emu port, which lacks this definition. Why not merge mips/yeeloong/time.h and mips/qemu-mips/time.h into mips/time.h ? Both files are identical. Both are stubs actually. Why does *-emu needs these files at all? *-emu doesn't see this type of machine info. It should just use host function for both cpu_idle and get_rtc grub_cpu_idle is implemented as an inline stub, which resides in time.h. -- Robert Millan The DRM opt-in fallacy: Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all. ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel