Re: opening new context (was: [PATCH] allow user-configurable menucolor)
On Sat, Jan 05, 2008 at 01:03:41PM +0100, Yoshinori K. Okuji wrote: > > Anyway, I wouldn't want to spend much time discussing this. I assume my > > proposed change (propagating read/write hooks for global/exported > > variables) sounds fine? > > Yes. Ok, committed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.) ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: opening new context (was: [PATCH] allow user-configurable menucolor)
On Saturday 05 January 2008 12:49, Robert Millan wrote: > On Sat, Jan 05, 2008 at 02:34:38AM +0100, Yoshinori K. Okuji wrote: > > On Friday 04 January 2008 09:02, Robert Millan wrote: > > > On Thu, Jan 03, 2008 at 06:04:59PM +0200, Vesa Jääskeläinen wrote: > > > > About new context: > > > > > > > > Shouldn't new context have clone of it's parent contexts settings? > > > > > > I wouldn't want to change that without having some input from whoever > > > designed (or understands) grub_env_export(). There's probably a reason > > > for it, although I can't see it. > > > > It is analogous to bash. If you invoke another bash from bash, that won't > > inherit variables, unless they are exported. > > It's not exactly analogous. bash doesn't commonly use variable hooks (if > they even exist). It has internally. > Anyway, I wouldn't want to spend much time discussing this. I assume my > proposed change (propagating read/write hooks for global/exported > variables) sounds fine? Yes. Okuji ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: opening new context (was: [PATCH] allow user-configurable menucolor)
On Sat, Jan 05, 2008 at 02:34:38AM +0100, Yoshinori K. Okuji wrote: > On Friday 04 January 2008 09:02, Robert Millan wrote: > > On Thu, Jan 03, 2008 at 06:04:59PM +0200, Vesa Jääskeläinen wrote: > > > About new context: > > > > > > Shouldn't new context have clone of it's parent contexts settings? > > > > I wouldn't want to change that without having some input from whoever > > designed (or understands) grub_env_export(). There's probably a reason for > > it, although I can't see it. > > It is analogous to bash. If you invoke another bash from bash, that won't > inherit variables, unless they are exported. It's not exactly analogous. bash doesn't commonly use variable hooks (if they even exist). Anyway, I wouldn't want to spend much time discussing this. I assume my proposed change (propagating read/write hooks for global/exported variables) sounds fine? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.) ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: opening new context (was: [PATCH] allow user-configurable menucolor)
On Friday 04 January 2008 09:02, Robert Millan wrote: > On Thu, Jan 03, 2008 at 06:04:59PM +0200, Vesa Jääskeläinen wrote: > > About new context: > > > > Shouldn't new context have clone of it's parent contexts settings? > > I wouldn't want to change that without having some input from whoever > designed (or understands) grub_env_export(). There's probably a reason for > it, although I can't see it. It is analogous to bash. If you invoke another bash from bash, that won't inherit variables, unless they are exported. Besides that, I think it is a good thing that some kind of "clean room" or "sandbox" is guaranteed. Okuji ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
opening new context (was: [PATCH] allow user-configurable menucolor)
On Thu, Jan 03, 2008 at 06:04:59PM +0200, Vesa Jääskeläinen wrote: > > About new context: > > Shouldn't new context have clone of it's parent contexts settings? I wouldn't want to change that without having some input from whoever designed (or understands) grub_env_export(). There's probably a reason for it, although I can't see it. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.) ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
