Patch biohazard report, 29 Jul
Hey GTK+ people, it's that time of the week again, nothing has changed since last week[0], so guess what... I'm reposting the easy ones from last week!: [api] Bug 65818 – rename gtk_window_set_default() and add getter for it http://bugzilla.gnome.org/show_bug.cgi?id=65818 [docs] Bug 351247 – GtkScrolledWindow is mis documented http://bugzilla.gnome.org/show_bug.cgi?id=351247 [docs] Bug 526575 – Missing return type in gtk_ui_manager_get_toplevels documentation http://bugzilla.gnome.org/show_bug.cgi?id=526575 [docs] Bug 523950 – GtkTreeModelFilter's visible function may get an empty row http://bugzilla.gnome.org/show_bug.cgi?id=523950 Plus, a new bonus easy bug: [build] Bug 536767 – gtksignal.h includes gtk.h http://bugzilla.gnome.org/show_bug.cgi?id=536767 And for the ones not that lazy: [gtkentry] Bug 83935 – GtkEntry's default invisible char should be U+25CF http://bugzilla.gnome.org/show_bug.cgi?id=83935 Go ahead, reject and accept patches, have fun. greetings 0 - http://mail.gnome.org/archives/gtk-devel-list/2008-July/msg00186.html ___ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list
Re: Justifying the GTK+ 3.0 ABI break
On Mon, Jul 14, 2008 at 11:30 AM, Murray Cumming <[EMAIL PROTECTED]> wrote: > Every time that a parallel-installable GTK+ 3.0 has been proposed, and > now that it has been decided, I have asked for a list of actual useful > features that it will make possible. I've had no luck so far. > > We need to offer people a future with some specific advantages so it > doesn't just look like the GTK+ developers are making their own lives a > little easier and scratching an unimportant itch. People don't care if > maintenance is hard for us, but they do care about new features and > particular bug fixes. > > If the code cleanup is really necessary then there should be some things > we can list that it will make possible. It would be best to have that > list soon rather than after the slashdot shitstorm hits. I just wanted to jump in and say thankyou to the team for finally standing up and making this decision, in fact, Ive been crying about this for a while and would even consider it overdue. Its been my (mis-?)perception that gtk+ has been under pressure by so called ISVs for a long time to not break abi, fair. and the Gtk+ team has made IMO extraordinary efforts to have a clean abi and way of tracking what is new/deprecated and all. I think this is not so much of a technical discussion, the point is that alot of the communal code is contributed by various sources, some completely volunteer work, other significant portions are sponsored projects - sponsored projects will always have big features as goals. I believe that for basic survival of gtk+ codebase (technical reasons outlined by Behdad and Sven in this thread) - the community has to be allowed after some time and blow the whistle and do some refactoring. This refactoring will slim to never be a sponsored work, so all the thankful users of free and good gtk+ I'm afraid dont get the "right" to a new feature with an abi break - its not to be mean, we just have to be understanding of how the resources work (some will undoubtedly not understand, for gtk+ codebase to survive and evolve, we need to just ignore those people and prove them wrong with 3.2). 3.0++ Cheers, -Tristan ___ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list
Re: setting up a gtk dev environment
On Mon, 2008-07-28 at 10:48 -0400, Patrick Hallinan wrote: > I ignored that and tried "jhbuild gtk+' but the first package > (fontconfig-2.6.0) failed to build. I think that this is the first > error: > > In file included from ../fontconfig/fcfreetype.h:27, > from fcftint.h:26, > from fcfreetype.c:48: > /usr/include/ft2build.h:56:38: error: freetype/config/ftheader.h: > No such file or directory ft* is FreeType, not FontConfig. Currently, jhbuild doesn't install FT or FC because, presumably, it assumes that are part of the X11 environment. This is not true on every platform. --p ___ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list
Re: setting up a gtk dev environment
Patrick Hallinan wrote: > I ignored that and tried "jhbuild gtk+' but the first package > (fontconfig-2.6.0) failed to build. I think that this is the first > error: > > In file included from ../fontconfig/fcfreetype.h:27, > from fcftint.h:26, > from fcfreetype.c:48: > /usr/include/ft2build.h:56:38: error: freetype/config/ftheader.h: > No such file or directory > > Fedora 9 has fontconfig-2.5.0-2. I guess I will file a bug against > jhbuild if I can figure out how to. bugzilla.gnome.org has a "jhbuild" product. Note that build failures are most often caused by the modules, not jhbuild, so I would advise you to report your bug against fontconfig. Frederic ___ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list
Re: setting up a gtk dev environment
Patrick Hallinan wrote: On Mon, 2008-07-28 at 10:06 -0400, Owen Taylor wrote: On Sun, 2008-07-27 at 14:40 -0400, Patrick Hallinan wrote: On Sun, 2008-07-27 at 14:24 -0400, Paul Davis wrote: On Sun, 2008-07-27 at 14:08 -0400, Patrick Hallinan wrote: Hi, I wish to help with the development of gtk+ but I'm not having any fun trying to setup a build environment for gtk+. I've looked for help at www.gtk.org/development.html and developer.gnome.org. I have tried using jhbuild from http://svn.gnome.org/svn/jhbuild/trunk. No dice. "no dice" doesn't really add up to a bug report on jhbuild. hundreds, perhaps thousands, of people use that as a way to build and maintain the GTK stack from svn. what was your problem with it? I guess you are saying that I should be using jhbuild to get a gtk+ build environment? I'm using the subversion trunk for jhbuild which I didn't assume was stable. I get the output below when I try "jhbuild bootstrap" In general, I'd strongly recommend against jhbuild bootstrap. It: - May install older versions of components than your system versions, causing weird problems - Increases the total amount of things you are building, giving more possibilities for failure. It is definitely a bad idea for Fedora 9, which has nice shiny new versions of everything. So blow away your install directory and start over without the bootstrap, and you'll be happier. http://live.gnome.org/JhbuildDependencies/FedoraCore Has information about what packages you need to install for Fedora. I had ignored the FedoraCore link on the jhbuild page because it indicated FedoraCore and not Fedora. I thought that it was old. I installed the missing dependencies and jhbuild sanitycheck gives this: [EMAIL PROTECTED] fontconfig-2.6.0]$ jhbuild sanitycheck automake-1.8 not found automake-1.9 not found Just install them! I ignored that and tried "jhbuild gtk+' but the first package (fontconfig-2.6.0) failed to build. I think that this is the first error: In file included from ../fontconfig/fcfreetype.h:27, from fcftint.h:26, from fcfreetype.c:48: /usr/include/ft2build.h:56:38: error: freetype/config/ftheader.h: No such file or directory Fedora 9 has fontconfig-2.5.0-2. I guess I will file a bug against jhbuild if I can figure out how to. You also need to install the freetype headers which are found in the freetype development package on fedora. Johan ___ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list
Re: setting up a gtk dev environment
On Mon, 2008-07-28 at 10:06 -0400, Owen Taylor wrote: > On Sun, 2008-07-27 at 14:40 -0400, Patrick Hallinan wrote: > > On Sun, 2008-07-27 at 14:24 -0400, Paul Davis wrote: > > > On Sun, 2008-07-27 at 14:08 -0400, Patrick Hallinan wrote: > > > > Hi, > > > > > > > > I wish to help with the development of gtk+ but I'm not having any fun > > > > trying to setup a build environment for gtk+. I've looked for help at > > > > www.gtk.org/development.html and developer.gnome.org. I have tried using > > > > jhbuild from http://svn.gnome.org/svn/jhbuild/trunk. No dice. > > > > > > "no dice" doesn't really add up to a bug report on jhbuild. hundreds, > > > perhaps thousands, of people use that as a way to build and maintain the > > > GTK stack from svn. what was your problem with it? > > > > > > > I guess you are saying that I should be using jhbuild to get a gtk+ > > build environment? > > > > I'm using the subversion trunk for jhbuild which I didn't assume was > > stable. I get the output below when I try "jhbuild bootstrap" > > In general, I'd strongly recommend against jhbuild bootstrap. It: > > - May install older versions of components than your system versions, >causing weird problems > - Increases the total amount of things you are building, giving >more possibilities for failure. > > It is definitely a bad idea for Fedora 9, which has nice shiny new > versions of everything. So blow away your install directory and > start over without the bootstrap, and you'll be happier. > > http://live.gnome.org/JhbuildDependencies/FedoraCore > > Has information about what packages you need to install for Fedora. > I had ignored the FedoraCore link on the jhbuild page because it indicated FedoraCore and not Fedora. I thought that it was old. I installed the missing dependencies and jhbuild sanitycheck gives this: [EMAIL PROTECTED] fontconfig-2.6.0]$ jhbuild sanitycheck automake-1.8 not found automake-1.9 not found I ignored that and tried "jhbuild gtk+' but the first package (fontconfig-2.6.0) failed to build. I think that this is the first error: In file included from ../fontconfig/fcfreetype.h:27, from fcftint.h:26, from fcfreetype.c:48: /usr/include/ft2build.h:56:38: error: freetype/config/ftheader.h: No such file or directory Fedora 9 has fontconfig-2.5.0-2. I guess I will file a bug against jhbuild if I can figure out how to. ___ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list
Re: setting up a gtk dev environment
Owen Taylor wrote: > > I'm using the subversion trunk for jhbuild which I didn't assume was > > stable. I get the output below when I try "jhbuild bootstrap" > > In general, I'd strongly recommend against jhbuild bootstrap. It: It is already written down in the manual; but it is obvisouly not enough (especially since other documents will ask the user to do jhbuild bootstrap) so I will probably add a note the first time the command is used, pointing that on a modern distribution, it is way easier and safer to use packages. Frederic ___ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list
Re: setting up a gtk dev environment
On Sun, 2008-07-27 at 14:40 -0400, Patrick Hallinan wrote: > On Sun, 2008-07-27 at 14:24 -0400, Paul Davis wrote: > > On Sun, 2008-07-27 at 14:08 -0400, Patrick Hallinan wrote: > > > Hi, > > > > > > I wish to help with the development of gtk+ but I'm not having any fun > > > trying to setup a build environment for gtk+. I've looked for help at > > > www.gtk.org/development.html and developer.gnome.org. I have tried using > > > jhbuild from http://svn.gnome.org/svn/jhbuild/trunk. No dice. > > > > "no dice" doesn't really add up to a bug report on jhbuild. hundreds, > > perhaps thousands, of people use that as a way to build and maintain the > > GTK stack from svn. what was your problem with it? > > > > I guess you are saying that I should be using jhbuild to get a gtk+ > build environment? > > I'm using the subversion trunk for jhbuild which I didn't assume was > stable. I get the output below when I try "jhbuild bootstrap" In general, I'd strongly recommend against jhbuild bootstrap. It: - May install older versions of components than your system versions, causing weird problems - Increases the total amount of things you are building, giving more possibilities for failure. It is definitely a bad idea for Fedora 9, which has nice shiny new versions of everything. So blow away your install directory and start over without the bootstrap, and you'll be happier. http://live.gnome.org/JhbuildDependencies/FedoraCore Has information about what packages you need to install for Fedora. - Owen ___ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list
Re: Justifying the GTK+ 3.0 ABI break
On Mon, 2008-07-14 at 17:30 +0200, Murray Cumming wrote: > Every time that a parallel-installable GTK+ 3.0 has been proposed, and > now that it has been decided, I have asked for a list of actual useful > features that it will make possible. I've had no luck so far. > > We need to offer people a future with some specific advantages so it > doesn't just look like the GTK+ developers are making their own lives a > little easier and scratching an unimportant itch. People don't care if > maintenance is hard for us, but they do care about new features and > particular bug fixes. > > If the code cleanup is really necessary then there should be some things > we can list that it will make possible. The closest thing I've seen to this so far is some items on Tim Janik's blog: http://blogs.gnome.org/timj/2008/07/16/16072008-guadec-2008-wrapup/ (search for "User visible gains are post-3.0 feature") Could you please decide on some official list and put it somewhere official. If there's no list of things that this break makes possible then it's very hard for anyone to believe that the break is necessary. If we get sick of asking and getting no answer then you can't just claim that there are no objections. > It would be best to have that > list soon rather than after the slashdot shitstorm hits. > -- [EMAIL PROTECTED] www.murrayc.com www.openismus.com ___ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list
va_list *
Hello. void print (va_list *ap) { printf ("%d\n", va_arg (*ap, int)); } void test (int num, ...) { va_list ap; int i; va_start (ap, num); for (i = 0; i < num; i++) print (&ap); va_end (ap); } int main (void) { test (3, 1, 2, 3); return 0; } ISO C99 (footnote 215, §7.15) says that this program is valid and should print out 1, 2, 3... "" 215) It is permitted to create a pointer to a va_list and pass that pointer to another function, in which case the original function may make further use of the original list after the other function returns. "" At the same time, though, GObject goes out of its way to avoid passing a va_list pointer to functions and there was some talk on mailing lists in the past about this being because not all C implementations are sane with respect to the above functionality. See also http://library.gnome.org/devel/gobject/unstable/gobject-Varargs-Value-Collection.html#G-VALUE-COLLECT:CAPS "" Collects a variable argument value from a va_list. We have to implement the varargs collection as a macro, because on some systems va_list variables cannot be passed by reference. "" Can anyone please weigh in on whether or not these "some systems" have gotten their act together yet? Is it still necessary to go out of our way like this in glib? Thanks in advance. Cheers ___ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list