GtkAppChooser custom command patch

[tarnyko]

Hi folks, 

Could someone please review the following patch/suggestion : 

https://bugzilla.gnome.org/show_bug.cgi?id=650284#c36 

It adds a "Use custom command" on the lower part of the GtkAppChooser 
window, so users can specify an unlisted application (case of uncomplete 
mimetypes or .desktop associations). 

Screenshots are available in the comment. 

The patch itself is unfinished, I'm mostly asking for feedback about the 
general idea and design. 


Regards,
Tarnyko
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: GtkAppChooser custom command patch

[tarnyko]

Thank you Bernard ! 

I've written the change due to recurring requests from my local user group 
(and other people, too).
Any feedback is welcome. 


Regards,
Tarnyko 

Bernhard Schuster writes: 


I did not look at your implementation, but the screenshots look very
promising - in fact I think that is a highly desirable feature and your
implementation is (imho) how it should be done! 

 



2013/4/8  


Hi folks,
Could someone please review the following patch/suggestion :
https://bugzilla.gnome.org/**show_bug.cgi?id=650284#c36
It adds a "Use custom command" on the lower part of the GtkAppChooser
window, so users can specify an unlisted application (case of uncomplete
mimetypes or .desktop associations).
Screenshots are available in the comment.
The patch itself is unfinished, I'm mostly asking for feedback about the
general idea and design.
Regards,
Tarnyko
__**_
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/**mailman/listinfo/gtk-devel-**list 


___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: GtkAppChooser custom command patch

[Matthias Clasen]

I don't think we want that in the app chooser, I'm afraid.
Applications need to be installed properly, which will make them show
up in the list of application.  Turning the app chooser into a
fix-up-your-os tool is not the right answer.

On Mon, Apr 8, 2013 at 7:13 AM,   wrote:
> Thank you Bernard !
> I've written the change due to recurring requests from my local user group
> (and other people, too).
> Any feedback is welcome.
> Regards,
> Tarnyko
> Bernhard Schuster writes:
>>
>> I did not look at your implementation, but the screenshots look very
>> promising - in fact I think that is a highly desirable feature and your
>> implementation is (imho) how it should be done!
>>
>>
>> 2013/4/8 
>>>
>>> Hi folks,
>>> Could someone please review the following patch/suggestion :
>>>
>>> https://bugzilla.gnome.org/**show_bug.cgi?id=650284#c36
>>>
>>> It adds a "Use custom command" on the lower part of the GtkAppChooser
>>> window, so users can specify an unlisted application (case of uncomplete
>>> mimetypes or .desktop associations).
>>> Screenshots are available in the comment.
>>> The patch itself is unfinished, I'm mostly asking for feedback about the
>>> general idea and design.
>>> Regards,
>>> Tarnyko
>>> __**_
>>> gtk-devel-list mailing list
>>> gtk-devel-list@gnome.org
>>>
>>> https://mail.gnome.org/**mailman/listinfo/gtk-devel-**list
>
> ___
> gtk-devel-list mailing list
> gtk-devel-list@gnome.org
> https://mail.gnome.org/mailman/listinfo/gtk-devel-list
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: GtkAppChooser custom command patch

[tarnyko]

Hi Matthias, 

It was that kind of answer that I was asking for. 

So what you're telling me is that I shouldn't try to develop the patch any 
further, because it will never be integrated upstream, right ? 

If that's the case, I will come back to my user group with this answer. 

I think you (not personally, but taken more widely) are wrong, and that it 
does some harm here, but fair enough, it is definitely your project. 

I won't debate this again, points have already been widely made before 
(Bernhard does have some here). Personally, what I regret the most is having 
spent time writing a useless patch. It does imply something for my past and 
future-planned contributions, too. 


Regards,
Tarnyko 

Matthias Clasen writes: 


I don't think we want that in the app chooser, I'm afraid.
Applications need to be installed properly, which will make them show
up in the list of application.  Turning the app chooser into a
fix-up-your-os tool is not the right answer. 


On Mon, Apr 8, 2013 at 7:13 AM,   wrote:

Thank you Bernard !
I've written the change due to recurring requests from my local user group
(and other people, too).
Any feedback is welcome.
Regards,
Tarnyko
Bernhard Schuster writes:


I did not look at your implementation, but the screenshots look very
promising - in fact I think that is a highly desirable feature and your
implementation is (imho) how it should be done! 



2013/4/8 


Hi folks,
Could someone please review the following patch/suggestion : 

https://bugzilla.gnome.org/**show_bug.cgi?id=650284#c36 


It adds a "Use custom command" on the lower part of the GtkAppChooser
window, so users can specify an unlisted application (case of uncomplete
mimetypes or .desktop associations).
Screenshots are available in the comment.
The patch itself is unfinished, I'm mostly asking for feedback about the
general idea and design.
Regards,
Tarnyko
__**_
gtk-devel-list mailing list
gtk-devel-list@gnome.org 


https://mail.gnome.org/**mailman/listinfo/gtk-devel-**list


___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: GtkAppChooser custom command patch

[Matthias Clasen]

On Mon, Apr 8, 2013 at 7:48 AM, Bernhard Schuster
 wrote:
> There will always be the case that some application will not do it properly.
> Instead of annoying the end-user, give him/her the option to fix it
> him/herself. It is not that it would hurt, it's rather a salvation for the
> daily highcups and struggle with beta/commercial applications.

But selecting 'custom command' doesn't fix it in any way. Fixing it
would involved editing the desktop file, adding the necessary mime
type, and sending a patch to the application author.

I don't doubt that 'custom command' functionality is useful. But I
don't think it should live in the app chooser dialog.
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Fwd: GtkAppChooser custom command patch

[Andreas Tunek]

Where do you think it should live? In a nautilus extension ("Open with
custom" or something)?

/Andreas


2013/4/8 Matthias Clasen 

> On Mon, Apr 8, 2013 at 7:48 AM, Bernhard Schuster
>  wrote:
> > There will always be the case that some application will not do it
> properly.
> > Instead of annoying the end-user, give him/her the option to fix it
> > him/herself. It is not that it would hurt, it's rather a salvation for
> the
> > daily highcups and struggle with beta/commercial applications.
>
> But selecting 'custom command' doesn't fix it in any way. Fixing it
> would involved editing the desktop file, adding the necessary mime
> type, and sending a patch to the application author.
>
> I don't doubt that 'custom command' functionality is useful. But I
> don't think it should live in the app chooser dialog.
> ___
> gtk-devel-list mailing list
> gtk-devel-list@gnome.org
> https://mail.gnome.org/mailman/listinfo/gtk-devel-list
>
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: GtkAppChooser custom command patch

[tarnyko]

Andreas, 

If it could be an *integrated* Nautilus feature, that would be great. 

Actually, it's all my users are asking for. Having the ability to run 
"custom command" in Nautilus. 

But it should *not* be an additional package -which you might not have 
installed on some systems - but definitely an integrated one. Should come 
with vanilla GNOME. 

I didn't hack Nautilus because I didn't know anything about it, and am more 
a GTK+ guy. 


Regards,
Tarnyko 

Andreas Tunek writes: 


Where do you think it should live? In a nautilus extension ("Open with
custom" or something)? 

/Andreas 



2013/4/8 Matthias Clasen  


On Mon, Apr 8, 2013 at 7:48 AM, Bernhard Schuster
 wrote:
> There will always be the case that some application will not do it
properly.
> Instead of annoying the end-user, give him/her the option to fix it
> him/herself. It is not that it would hurt, it's rather a salvation for
the
> daily highcups and struggle with beta/commercial applications. 


But selecting 'custom command' doesn't fix it in any way. Fixing it
would involved editing the desktop file, adding the necessary mime
type, and sending a patch to the application author. 


I don't doubt that 'custom command' functionality is useful. But I
don't think it should live in the app chooser dialog.
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list 


___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: GtkAppChooser custom command patch

[tarnyko]

Matthias, 

Would it be possible to have it Nautilus, then ? 

But not as an additional package or script. In vanilla Nautilus (= vanilla 
GNOME). 

Because that's all my users are asking for. 


Regards,
Matthias 

Matthias Clasen writes: 


On Mon, Apr 8, 2013 at 7:48 AM, Bernhard Schuster
 wrote:

There will always be the case that some application will not do it properly.
Instead of annoying the end-user, give him/her the option to fix it
him/herself. It is not that it would hurt, it's rather a salvation for the
daily highcups and struggle with beta/commercial applications.


But selecting 'custom command' doesn't fix it in any way. Fixing it
would involved editing the desktop file, adding the necessary mime
type, and sending a patch to the application author. 


I don't doubt that 'custom command' functionality is useful. But I
don't think it should live in the app chooser dialog.

___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: GtkAppChooser custom command patch

[Bernhard Schuster]

I did not look at your implementation, but the screenshots look very
promising - in fact I think that is a highly desirable feature and your
implementation is (imho) how it should be done!




2013/4/8 

> Hi folks,
> Could someone please review the following patch/suggestion :
> https://bugzilla.gnome.org/**show_bug.cgi?id=650284#c36
> It adds a "Use custom command" on the lower part of the GtkAppChooser
> window, so users can specify an unlisted application (case of uncomplete
> mimetypes or .desktop associations).
> Screenshots are available in the comment.
> The patch itself is unfinished, I'm mostly asking for feedback about the
> general idea and design.
> Regards,
> Tarnyko
> __**_
> gtk-devel-list mailing list
> gtk-devel-list@gnome.org
> https://mail.gnome.org/**mailman/listinfo/gtk-devel-**list
>
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: GtkAppChooser custom command patch

[Bernhard Schuster]

There will always be the case that some application will not do it
properly. Instead of annoying the end-user, give him/her the option to fix
it him/herself. It is not that it would hurt, it's rather a salvation for
the daily highcups and struggle with beta/commercial applications.

Best

Bernhard


2013/4/8 Matthias Clasen 

> I don't think we want that in the app chooser, I'm afraid.
> Applications need to be installed properly, which will make them show
> up in the list of application.  Turning the app chooser into a
> fix-up-your-os tool is not the right answer.
>
> On Mon, Apr 8, 2013 at 7:13 AM,   wrote:
> > Thank you Bernard !
> > I've written the change due to recurring requests from my local user
> group
> > (and other people, too).
> > Any feedback is welcome.
> > Regards,
> > Tarnyko
> > Bernhard Schuster writes:
> >>
> >> I did not look at your implementation, but the screenshots look very
> >> promising - in fact I think that is a highly desirable feature and your
> >> implementation is (imho) how it should be done!
> >>
> >>
> >> 2013/4/8 
> >>>
> >>> Hi folks,
> >>> Could someone please review the following patch/suggestion :
> >>>
> >>> https://bugzilla.gnome.org/**show_bug.cgi?id=650284#c36<
> https://bugzilla.gnome.org/show_bug.cgi?id=650284#c36>
> >>>
> >>> It adds a "Use custom command" on the lower part of the GtkAppChooser
> >>> window, so users can specify an unlisted application (case of
> uncomplete
> >>> mimetypes or .desktop associations).
> >>> Screenshots are available in the comment.
> >>> The patch itself is unfinished, I'm mostly asking for feedback about
> the
> >>> general idea and design.
> >>> Regards,
> >>> Tarnyko
> >>> __**_
> >>> gtk-devel-list mailing list
> >>> gtk-devel-list@gnome.org
> >>>
> >>> https://mail.gnome.org/**mailman/listinfo/gtk-devel-**list<
> https://mail.gnome.org/mailman/listinfo/gtk-devel-list>
> >
> > ___
> > gtk-devel-list mailing list
> > gtk-devel-list@gnome.org
> > https://mail.gnome.org/mailman/listinfo/gtk-devel-list
> ___
> gtk-devel-list mailing list
> gtk-devel-list@gnome.org
> https://mail.gnome.org/mailman/listinfo/gtk-devel-list
>
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: GtkAppChooser custom command patch

[Bernhard Schuster]

It does not fix the issue on a permanent basis nor does it fix the issue
for other users. But the single user can fix it _instantly_ himself without
having to read the .desktop file specification. And I think that is an
actual advantage. An alternative would be to create an application to write
.desktop files (a bunch of entries with suggestions), probably "linked"
from the application chooser dialog - that would be a viable solution, but
on the other hand side, this is more nasty for the end-user.

Best


2013/4/8 Matthias Clasen 

> On Mon, Apr 8, 2013 at 7:48 AM, Bernhard Schuster
>  wrote:
> > There will always be the case that some application will not do it
> properly.
> > Instead of annoying the end-user, give him/her the option to fix it
> > him/herself. It is not that it would hurt, it's rather a salvation for
> the
> > daily highcups and struggle with beta/commercial applications.
>
> But selecting 'custom command' doesn't fix it in any way. Fixing it
> would involved editing the desktop file, adding the necessary mime
> type, and sending a patch to the application author.
>
> I don't doubt that 'custom command' functionality is useful. But I
> don't think it should live in the app chooser dialog.
>
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: GtkAppChooser custom command patch

[Olav Vitters]

On Mon, Apr 08, 2013 at 01:53:37PM +0200, tarn...@tarnyko.net wrote:
> I won't debate this again, points have already been widely made
> before (Bernhard does have some here). Personally, what I regret the
> most is having spent time writing a useless patch. It does imply
> something for my past and future-planned contributions, too.

It is good that you're trying to help, and I can understand you think a
"custom command" is helpful. But what you really need is a desktop file.
A desktop file ensures that things work correctly (correct mime types,
startup notification, etc). There are programs which already allow you
to create such desktop files, e.g. alacarte (though it had some issues).

Note that some time will always be wasted. E.g. Mattias probably looks
at various patches which have bugs in them. Pretty much wasted time
because he wouldn't have to spend time if people did exactly what he
visioned.
Or in other words: accepting patches because you spend time on the patch
is not how things are or should be done.

-- 
Regards,
Olav
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: GtkAppChooser custom command patch

[tarnyko]

Hi Olav, 

Olav Vitters writes: 


It is good that you're trying to help, and I can understand you think a
"custom command" is helpful. But what you really need is a desktop file.
A desktop file ensures that things work correctly (correct mime types,
startup notification, etc). There are programs which already allow you
to create such desktop files, e.g. alacarte (though it had some issues). 


Note that some time will always be wasted. E.g. Mattias probably looks
at various patches which have bugs in them. Pretty much wasted time
because he wouldn't have to spend time if people did exactly what he
visioned.
Or in other words: accepting patches because you spend time on the patch
is not how things are or should be done. 



Of course not ; I wouldn't do so on my own projects either. But maybe the 
tone of my mail - a bit dramatic - made it look otherwise. 


--
Regards,
Olav
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list


Regards,
Tarnyko
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list