Publically exposing GtkFileChooserIface

2006-12-13 Thread Kristian Rietveld 
Hi Federico,

It has come to our attention that important pieces needed to implement a
third-party file chooser dialog outside of GTK+ are not installed.  As far as
I can see implementing your own file chooser dialog involves implementing the
GtkFileChooserIface and then plugging it into GTK+.  The main problem is that
the definition of this interface is in gtkfilechooserprivate.h, which is
obviously not installed.  A second problem is that the definition uses types
defined in the semi-public gtkfilesystem.h (especially GtkFilePath).

The easiest way to solve this is probably to:
 * Move GtkFileChooserIface into it's own, new, header file.
   gtkfilechooserprivate.h also contains some data structures internal to
   the implementation of the default file chooser which don't make sense
   to install.
 * Add GTK_FILE_SYSTEM_ENABLE_UNSUPPORTED defines like in gtkfilesystem.h.
 * Get GTK+ to install it.


I would really like to get this into 2.12.  Objections?  Suggestions?


thanks,

-kris.
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: Publically exposing GtkFileChooserIface

2006-12-19 Thread Federico Mena Quintero 
El mié, 13-12-2006 a las 11:28 +0100, Kristian Rietveld escribió:

> The easiest way to solve this is probably to:
>  * Move GtkFileChooserIface into it's own, new, header file.
>gtkfilechooserprivate.h also contains some data structures internal to
>the implementation of the default file chooser which don't make sense
>to install.
>  * Add GTK_FILE_SYSTEM_ENABLE_UNSUPPORTED defines like in gtkfilesystem.h.
>  * Get GTK+ to install it.
>
> I would really like to get this into 2.12.  Objections?  Suggestions?

The bug for this is http://bugzilla.gnome.org/show_bug.cgi?id=382528

It's a good idea, and something that we wanted to do for 2.10, but it
just fell through the cracks.

However, the file chooser at this point is really buggy.  I don't want
to do any API work on it until the bugs are fixed.

Making the Iface public is more or less orthogonal to fixing the bugs,
but making it public would require documenting it, polishing the bits of
the interface that are really too specific to the current
implementation, etc.  All that would take resources away from fixing the
bugs in the default implementation.

  Federico

___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list