Re: Some comments on the StyleContext stuff

2010-12-06 Thread Matthias Clasen 
On Mon, Dec 6, 2010 at 6:52 AM, Benjamin Otte  wrote:

> Can we just remove GtkStyle, please? And deal with the fallout?

No, we can't 'just' do that. It is deprecated now. Once all of gnome
is building against it with -DGTK_DISABLE_DEPRECATED, we can talk
about removing it, not before.
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: Some comments on the StyleContext stuff

2010-12-06 Thread Owen Taylor 
On Mon, 2010-12-06 at 12:52 +0100, Benjamin Otte wrote:
> - If all style properties are rgba, everything that uses GdkColor is
> fail. Widgets using GtkStyle will suddenly look wrong when we use
> translucency for background colors. Can we just remove GtkStyle,
> please? And deal with the fallout? It's not like people don't have to
> rewrite their draw functions anyway for GTK2 => GTK3 ...

This probably makes sense, but to point out the obvious, if this is
done, patches for every core GNOME module have to be landing within
minutes after the GtkStyle removal.

I'm going back to harping on this because 48 hours after the
deprecation of GtkStyle, there are still modules in core GNOME that
are failing to build - e.g. gnome-power-manager, because they have
the combination of GTK_DISABLE_DEPRECATED and -Werror 
and other modules that are building but likely miscompiling - 
e.g. gnome-control-center- because they have GTK_DISABLE_DEPRECATED
without -Werror.

- Owen


___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list