Re: Refactoring out old code, missing things for debug builds

2010-09-27 Thread Sven Neumann
On Mon, 2010-09-27 at 14:43 +0900, Tristan Van Berkom wrote:
 Guys, 
I'm just raising this because it's been the third time now
 that I have to fix people's refactor commits locally just to get
 through a build.
 
 Today it was:
 gdkvisual-x11.c: In function ‘_gdk_visual_init’:
 gdkvisual-x11.c:283: error: ‘GdkVisual’ has no member named ‘visual’
 gdkvisual-x11.c:283: error: ‘GdkVisual’ has no member named ‘visual’
 
 Due to some code inside #ifdef G_ENABLE_DEBUG
 
 Please; when doing mass commits to GTK+ that change API, please make
 sure you have configured with --enable-debug.

cppcheck is also quite good at catching such errors. It makes sure that
code in #ifdef branches will at least compile.


Regards,
Sven


___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list


Refactoring out old code, missing things for debug builds

2010-09-26 Thread Tristan Van Berkom
Guys, 
   I'm just raising this because it's been the third time now
that I have to fix people's refactor commits locally just to get
through a build.

Today it was:
gdkvisual-x11.c: In function ‘_gdk_visual_init’:
gdkvisual-x11.c:283: error: ‘GdkVisual’ has no member named ‘visual’
gdkvisual-x11.c:283: error: ‘GdkVisual’ has no member named ‘visual’

Due to some code inside #ifdef G_ENABLE_DEBUG

Please; when doing mass commits to GTK+ that change API, please make
sure you have configured with --enable-debug.

Thanks,
-Tristan



___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list