Re: configure.in changes

2005-08-15 Thread Owen Taylor
On Mon, 2005-08-15 at 07:33 +0200, Jonas Bonn wrote:
 Sorry for the late reply.  I missed this post and was wondering if
 someone had intentionally changed something... I think this is what
 has broken the CVS build on my machine.
 
 I had to modify the Makefile in the 'gdk' directory by adding
 -L/usr/X11R6/lib -lXext to the defintion of GDK_DEP_LIBS in order to
 get the build to work.  I'm not good enough at autotools to know what
 to change to get automake to do this automatically.
 
 The build was failing with 'undefined symbol XShmDetach' (etc etc etc)
 in libgdk-x11-2.0.la during the linking of gtk-query-immodules-2.0.
 
 I'm building on Ubuntu Hoary with X11R6.8 so your warning about
 non-recent X.org probably applies.

Well, 6.8 is definitely recent from my perspective

Can you try changing the one instance of 'have_base_pc' in configure.in
to 'have_base_x_pc' and see if that fixes the problem for you?

Thanks,
Owen



signature.asc
Description: This is a digitally signed message part
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list


Re: configure.in changes

2005-08-15 Thread Jonas Bonn
 Try:
 
   if $have_base_x_pc ; then
 GDK_EXTRA_LIBS=$x_extra_libs
   else
 -GDK_EXTRA_LIBS=$X_LIBS $x_extra_libs -lX11 $GDK_EXTRA_LIBS
 +GDK_EXTRA_LIBS=$X_LIBS $x_extra_libs -lXext $GDK_EXTRA_LIBS
   fi

That did the trick.  With this modification, the build passes.
Thanks.
Jonas
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list


Re: configure.in changes

2005-08-14 Thread Jonas Bonn
Sorry for the late reply.  I missed this post and was wondering if
someone had intentionally changed something... I think this is what
has broken the CVS build on my machine.

I had to modify the Makefile in the 'gdk' directory by adding
-L/usr/X11R6/lib -lXext to the defintion of GDK_DEP_LIBS in order to
get the build to work.  I'm not good enough at autotools to know what
to change to get automake to do this automatically.

The build was failing with 'undefined symbol XShmDetach' (etc etc etc)
in libgdk-x11-2.0.la during the linking of gtk-query-immodules-2.0.

I'm building on Ubuntu Hoary with X11R6.8 so your warning about
non-recent X.org probably applies.

Regards,
Jonas

On 8/10/05, Owen Taylor [EMAIL PROTECTED] wrote:
 I just rewrote large chunks of the X checks in configure.in ... there
 were a couple of points of this:
 
  - Remove the entanglements with pangoxft, which I've removed as a
dependency of GTK+.
 
  - Use pkg-config as much as possible rather than older heuristics.
With X11R7 .pc files for the X libraries will become a lot more
common.
 
  - General simplification
 
 In general I think what's there now is quite a bit cleaner and simpler,
 but since I can't test most of the cases, there certainly is some
 possibility that I broke something.
 
 So, if people want to test out what is in CVS now I'd appreciate it,
 especially for those deviating from the central stream of
 Linux+recent X.org.
 
 Regards,
 Owen
 
 
 
 -BEGIN PGP SIGNATURE-
 Version: GnuPG v1.2.6 (GNU/Linux)
 
 iD8DBQBC+W6BS+2LB0B90LERAn0PAJ4kQE4L6byeECkpyu/OIuYq1PDUqQCgqpn+
 hzS60c3ly0/FDJPfqgooehU=
 =YWCG
 -END PGP SIGNATURE-
 
 
 ___
 gtk-devel-list mailing list
 gtk-devel-list@gnome.org
 http://mail.gnome.org/mailman/listinfo/gtk-devel-list
 
 
 


-- 
Jonas Bonn
Stockholm, Sweden
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list


Re: configure.in changes

2005-08-14 Thread Glynn Foster
Hey,

I'm also seeing this, or something like this FWIW -

http://bugzilla.gnome.org/show_bug.cgi?id=313503


Glynn

On Mon, 2005-08-15 at 07:33 +0200, Jonas Bonn wrote:
 Sorry for the late reply.  I missed this post and was wondering if
 someone had intentionally changed something... I think this is what
 has broken the CVS build on my machine.
 
 I had to modify the Makefile in the 'gdk' directory by adding
 -L/usr/X11R6/lib -lXext to the defintion of GDK_DEP_LIBS in order to
 get the build to work.  I'm not good enough at autotools to know what
 to change to get automake to do this automatically.
 
 The build was failing with 'undefined symbol XShmDetach' (etc etc etc)
 in libgdk-x11-2.0.la during the linking of gtk-query-immodules-2.0.
 
 I'm building on Ubuntu Hoary with X11R6.8 so your warning about
 non-recent X.org probably applies.

___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list


Re: configure.in changes

2005-08-10 Thread J. Ali Harlow


On 10/08/05 04:03:29, Owen Taylor wrote:


So, if people want to test out what is in CVS now I'd appreciate it,
especially for those deviating from the central stream of
Linux+recent X.org.


The changes to configure.in seem fine, but the changes to gdkfont- 
win32.c that were checked in at the same time seem to need a little  
more tweaking. I've commited a fix-up for gdkfont-win32.c itself, but  
that still leaves the following which I don't know how to fix:


Creating library file: .libs/im-ime.dll.a
.libs/gtkimcontextime.o(.text+0x1ac7): In function  
`gtk_im_context_ime_set_preedit_font':
/home/avrc/external/gtk/build/mingw32/modules/input/ 
gtkimcontextime.c:882: undefined reference to  
`_pango_win32_font_logfont'

collect2: ld returned 1 exit status

Cheers,

--
Ali Harlow  Email: [EMAIL PROTECTED]
Senior Research Officer Tel:   (020) 7040 4348
Applied Vision Research Centre  Intl: +44 20 7040 4348
City University Fax:   (020) 7040 5515
London  Intl: +44 20 7040 5515


___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list


Re: configure.in changes

2005-08-10 Thread Owen Taylor
On Wed, 2005-08-10 at 11:06 +, J. Ali Harlow wrote:
 On 10/08/05 04:03:29, Owen Taylor wrote:
 
  So, if people want to test out what is in CVS now I'd appreciate it,
  especially for those deviating from the central stream of
  Linux+recent X.org.
 
 The changes to configure.in seem fine, but the changes to gdkfont- 
 win32.c that were checked in at the same time seem to need a little  
 more tweaking. I've commited a fix-up for gdkfont-win32.c itself, but  
 that still leaves the following which I don't know how to fix:

Always a problem writing code you can't compile at the moment. Thanks
for fixing up.

 Creating library file: .libs/im-ime.dll.a
 .libs/gtkimcontextime.o(.text+0x1ac7): In function  
 `gtk_im_context_ime_set_preedit_font':
 /home/avrc/external/gtk/build/mingw32/modules/input/ 
 gtkimcontextime.c:882: undefined reference to  
 `_pango_win32_font_logfont'
 collect2: ld returned 1 exit status

Hmm, that usage of PangoWin32 should still be OK with the cairo changes;
(PangoCairoWin32Font inherits from PangoWin32Font).

while it wouldn't be that hard to get GTK+ building on Windows with
using only FreeType fonts (just change a few checks in Pango's
configure) I don't think anybody would do it.

You could either add pangowin32 back to PANGO_PACCKAGES for win32, or 
you could use a separate set of CFLAGS/LDFLAGS for gtkimcontextime.
The first is probably simpler - go back to:

 if test x$gdktarget = xwin32; then
PANGO_PACKAGES=pangowin32 pangocairo
 else
PANGO_PACKAGES=pango pangocairo
 fi

Since pangocairo pulls in pangowin32 on Windows, there is no added
inefficiency, really.

Regards,
Owen



signature.asc
Description: This is a digitally signed message part
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list


Re: configure.in changes

2005-08-10 Thread J. Ali Harlow


On 10/08/05 12:43:51, Owen Taylor wrote:


The first is probably simpler - go back to:

 if test x$gdktarget = xwin32; then
PANGO_PACKAGES=pangowin32 pangocairo
 else
PANGO_PACKAGES=pango pangocairo
 fi

Since pangocairo pulls in pangowin32 on Windows, there is no added
inefficiency, really.


I'll run my build over this. It takes about 3 hours, so you might not  
want to wait for the result :-)


Cheers,

--
Ali Harlow  Email: [EMAIL PROTECTED]
Senior Research Officer Tel:   (020) 7040 4348
Applied Vision Research Centre  Intl: +44 20 7040 4348
City University Fax:   (020) 7040 5515
London  Intl: +44 20 7040 5515


___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list


Re: configure.in changes

2005-08-10 Thread J. Ali Harlow


On 10/08/05 12:43:51, Owen Taylor wrote:


The first is probably simpler - go back to:

 if test x$gdktarget = xwin32; then
PANGO_PACKAGES=pangowin32 pangocairo
 else
PANGO_PACKAGES=pango pangocairo
 fi


Works for me - committed. Thanks, Owen.

--
Ali Harlow  Email: [EMAIL PROTECTED]
Senior Research Officer Tel:   (020) 7040 4348
Applied Vision Research Centre  Intl: +44 20 7040 4348
City University Fax:   (020) 7040 5515
London  Intl: +44 20 7040 5515


___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list


configure.in changes

2005-08-09 Thread Owen Taylor
I just rewrote large chunks of the X checks in configure.in ... there
were a couple of points of this:

 - Remove the entanglements with pangoxft, which I've removed as a
   dependency of GTK+.

 - Use pkg-config as much as possible rather than older heuristics.
   With X11R7 .pc files for the X libraries will become a lot more
   common.

 - General simplification

In general I think what's there now is quite a bit cleaner and simpler,
but since I can't test most of the cases, there certainly is some
possibility that I broke something.

So, if people want to test out what is in CVS now I'd appreciate it, 
especially for those deviating from the central stream of 
Linux+recent X.org.

Regards,
Owen



signature.asc
Description: This is a digitally signed message part
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list