stdout output from colorselection

[Iago Rubio]

Hi all,

I realized that lately there have been some output to stdout when
selecting an item on the color selection's palette.

Looks like the culprit is palette_paint at gtkcolorsel.c:607,
http://cvs.gnome.org/viewcvs/gtk%
2B/gtk/gtkcolorsel.c?rev=1.147&view=markup

// 
625   set_focus_line_attributes (drawing_area, cr, &focus_width);
626   g_print ("%g %g %g %g\n",
627focus_width / 2., focus_width / 2.,
628(double)drawing_area->allocation.width - focus_width,
629(double)drawing_area->allocation.height - focus_width);
// ...

Is that intentional ?

It's somewhat polluting the application's output. It will confuse users
of those applications that use g_set_print_handler to log output to a
file.

-- 
Iago Rubio

___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: stdout output from colorselection

[Emmanuele Bassi]

Hi Iago,

On Sat, 2006-08-05 at 16:17 +0200, Iago Rubio wrote:

> Looks like the culprit is palette_paint at gtkcolorsel.c:607,
> http://cvs.gnome.org/viewcvs/gtk%
> 2B/gtk/gtkcolorsel.c?rev=1.147&view=markup
> 
> // 
> 625   set_focus_line_attributes (drawing_area, cr, &focus_width);
> 626   g_print ("%g %g %g %g\n",
> 627focus_width / 2., focus_width / 2.,
> 628(double)drawing_area->allocation.width - focus_width,
> 629(double)drawing_area->allocation.height - focus_width);
> // ...
> 
> Is that intentional ?

Probably not: seems like the remainder of some debug code.

> It's somewhat polluting the application's output. It will confuse users
> of those applications that use g_set_print_handler to log output to a
> file.

You should file a bug about it on the gtk+ product of GNOME's Bugzilla;
you can also attach a patch removing the g_print call.

Ciao,
 Emmanuele.

-- 
Emmanuele Bassi,  E: [EMAIL PROTECTED]
W: http://www.emmanuelebassi.net
B: http://log.emmanuelebassi.net

___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: stdout output from colorselection

[Iago Rubio]

On Sat, 2006-08-05 at 15:25 +0100, Emmanuele Bassi wrote:
> You should file a bug about it on the gtk+ product of GNOME's Bugzilla;
> you can also attach a patch removing the g_print call.

Done.
http://bugzilla.gnome.org/show_bug.cgi?id=350072

-- 
Iago Rubio

___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list