Re: Avoid warning about alloca in read.c

2016-07-24 Thread Eli Zaretskii 
> From: Andy Wingo 
> Cc: guile-devel@gnu.org
> Date: Sun, 24 Jul 2016 15:35:08 +0200
> 
> >> > +#ifdef __MINGW32__
> >> > +#include 
> >> > +#endif
> >> > +
> >> 
> >> OK to commit but please remove the ifdef -- just include  in all
> >> cases.
> >
> > Is that header available on all supported platforms?
> 
> Yes, we use a Gnulib module to ensure that some workable version is
> present.

Thanks, pushed.

Re: Avoid warning about alloca in read.c

2016-07-24 Thread Andy Wingo 
On Sun 24 Jul 2016 04:39, Eli Zaretskii  writes:

>> From: Andy Wingo 
>> Cc: guile-devel@gnu.org
>> Date: Sat, 23 Jul 2016 22:57:02 +0200
>> 
>> > +#ifdef __MINGW32__
>> > +#include 
>> > +#endif
>> > +
>> 
>> OK to commit but please remove the ifdef -- just include  in all
>> cases.
>
> Is that header available on all supported platforms?

Yes, we use a Gnulib module to ensure that some workable version is
present.

Andy

Re: Avoid warning about alloca in read.c

2016-07-23 Thread Andy Wingo 
On Sat 16 Jul 2016 19:18, Eli Zaretskii  writes:

>CC   libguile_2.0_la-read.lo
>  read.c: In function 'try_read_ci_chars':
>  read.c:983:3: warning: implicit declaration of function 'alloca' 
> [-Wimplicit-function-declaration]
>  read.c:983:22: warning: incompatible implicit declaration of built-in 
> function 'alloca' [enabled by default]
>
> The patch to avoid this warning is below.  OK to commit?
>
> --- libguile/read.c~0 2016-01-02 16:24:55.0 +0200
> +++ libguile/read.c   2016-07-15 12:38:42.195125000 +0300
> @@ -33,6 +33,10 @@
>  #include 
>  #include 
>  
> +#ifdef __MINGW32__
> +#include 
> +#endif
> +

OK to commit but please remove the ifdef -- just include  in all
cases.

Thanks!

Andy

Re: Avoid warning about alloca in read.c

2016-07-22 Thread Eli Zaretskii 
Ping!

> Date: Sat, 16 Jul 2016 20:18:26 +0300
> From: Eli Zaretskii 
> 
>CC   libguile_2.0_la-read.lo
>  read.c: In function 'try_read_ci_chars':
>  read.c:983:3: warning: implicit declaration of function 'alloca' 
> [-Wimplicit-function-declaration]
>  read.c:983:22: warning: incompatible implicit declaration of built-in 
> function 'alloca' [enabled by default]
> 
> The patch to avoid this warning is below.  OK to commit?
> 
> --- libguile/read.c~0 2016-01-02 16:24:55.0 +0200
> +++ libguile/read.c   2016-07-15 12:38:42.195125000 +0300
> @@ -33,6 +33,10 @@
>  #include 
>  #include 
>  
> +#ifdef __MINGW32__
> +#include 
> +#endif
> +
>  #include "libguile/_scm.h"
>  #include "libguile/bytevectors.h"
>  #include "libguile/chars.h"
> 
>

Avoid warning about alloca in read.c

2016-07-16 Thread Eli Zaretskii 
   CC   libguile_2.0_la-read.lo
 read.c: In function 'try_read_ci_chars':
 read.c:983:3: warning: implicit declaration of function 'alloca' 
[-Wimplicit-function-declaration]
 read.c:983:22: warning: incompatible implicit declaration of built-in 
function 'alloca' [enabled by default]

The patch to avoid this warning is below.  OK to commit?

--- libguile/read.c~0   2016-01-02 16:24:55.0 +0200
+++ libguile/read.c 2016-07-15 12:38:42.195125000 +0300
@@ -33,6 +33,10 @@
 #include 
 #include 
 
+#ifdef __MINGW32__
+#include 
+#endif
+
 #include "libguile/_scm.h"
 #include "libguile/bytevectors.h"
 #include "libguile/chars.h"