Re: luajit recipe

2014-02-05 Thread Raimon Grau
Cyril Roelandt  writes:
>
> Please add a comment explaining why you disabled the tests.
>

Luajit just doesn't come with any tests in the distribution, and 'make
test' doesn't exist.  Added a comment in the code.

>From 922d9b5e0e4d8332e3f742d1e7954feb93dbdabe Mon Sep 17 00:00:00 2001
From: Raimon Grau 
Date: Thu, 6 Feb 2014 01:43:31 +0100
Subject: [PATCH] gnu: Add luajit

---
 gnu/packages/lua.scm | 25 +
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
index 14fc28c..81caa26 100644
--- a/gnu/packages/lua.scm
+++ b/gnu/packages/lua.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013 Cyril Roelandt 
+;;; Copyright © 2014 Raimon Grau 
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -61,3 +62,27 @@ runs by interpreting bytecode for a register-based virtual machine, and has
 automatic memory management with incremental garbage collection, making it ideal
 for configuration, scripting, and rapid prototyping.")
 (license x11)))
+
+(define-public luajit
+  (package
+(name "luajit")
+(version "2.0.2")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "http://luajit.org/download/LuaJIT-";
+  version ".tar.gz"))
+  (sha256
+   (base32 "0f3cykihfdn3gi6na9p0xjd4jnv26z18m441n5vyg42q9abh4ln0"
+(build-system gnu-build-system)
+(arguments
+ '(#:tests? #f  ;luajit is distributed without tests
+   #:phases (alist-delete 'configure %standard-phases)
+   #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")
+(home-page "http://www.luajit.org/";)
+(synopsis "Just in time compiler for Lua programming language version 5.1")
+(description
+ "LuaJIT is a Just-In-Time Compiler (JIT) for the Lua
+programming language.  Lua is a powerful, dynamic and light-weight programming
+language.  It may be embedded or used as a general-purpose, stand-alone
+language.")
+(license x11)))
-- 
1.8.3.2



Re: luajit recipe

2014-02-05 Thread Cyril Roelandt

On 02/06/2014 01:47 AM, Raimon Grau wrote:

Here's the luajit package inside lua.scm .

I hope everything is ok:)

PS: I'm not used to send patches through mail, and gnus is suggesting
text/x-diff mime type and inline (instead of attachment). Which is the
prefered way?



Have you tried using git send-email ?



0001-gnu-Add-luajit.patch


 From bf7c2156e8bdcbaf9f6c66b74eae6c58de3870d7 Mon Sep 17 00:00:00 2001
From: Raimon Grau
Date: Thu, 6 Feb 2014 01:43:31 +0100
Subject: [PATCH] gnu: Add luajit

---
  gnu/packages/lua.scm | 25 +
  1 file changed, 25 insertions(+)

diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
index 14fc28c..b523fe3 100644
--- a/gnu/packages/lua.scm
+++ b/gnu/packages/lua.scm
@@ -1,5 +1,6 @@
  ;;; GNU Guix --- Functional package management for GNU
  ;;; Copyright © 2013 Cyril Roelandt
+;;; Copyright © 2014 Raimon Grau
  ;;;
  ;;; This file is part of GNU Guix.
  ;;;
@@ -61,3 +62,27 @@ runs by interpreting bytecode for a register-based virtual 
machine, and has
  automatic memory management with incremental garbage collection, making it 
ideal
  for configuration, scripting, and rapid prototyping.")
  (license x11)))
+
+(define-public luajit
+  (package
+(name "luajit")
+(version "2.0.2")
+(source (origin
+  (method url-fetch)
+  (uri (string-append"http://luajit.org/download/LuaJIT-";
+  version ".tar.gz"))
+  (sha256
+   (base32 
"0f3cykihfdn3gi6na9p0xjd4jnv26z18m441n5vyg42q9abh4ln0"
+(build-system gnu-build-system)
+(arguments
+ '(#:tests? #f


Please add a comment explaining why you disabled the tests.


+   #:phases (alist-delete 'configure %standard-phases)
+   #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs 
"out")
+(home-page"http://www.luajit.org/";)
+(synopsis "Just in time compiler for Lua programming language version 5.1")
+(description
+ "LuaJIT is a Just-In-Time Compiler (JIT) for the Lua
+programming language. Lua is a powerful, dynamic and light-weight programming
+language.  It may be embedded or used as a general-purpose, stand-alone
+language.")
+(license x11)))
-- 1.8.3.2



Cyril.



Re: luajit recipe

2014-02-05 Thread Raimon Grau
Here's the luajit package inside lua.scm .

I hope everything is ok :)

PS: I'm not used to send patches through mail, and gnus is suggesting
text/x-diff mime type and inline (instead of attachment). Which is the
prefered way?

>From bf7c2156e8bdcbaf9f6c66b74eae6c58de3870d7 Mon Sep 17 00:00:00 2001
From: Raimon Grau 
Date: Thu, 6 Feb 2014 01:43:31 +0100
Subject: [PATCH] gnu: Add luajit

---
 gnu/packages/lua.scm | 25 +
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
index 14fc28c..b523fe3 100644
--- a/gnu/packages/lua.scm
+++ b/gnu/packages/lua.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013 Cyril Roelandt 
+;;; Copyright © 2014 Raimon Grau 
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -61,3 +62,27 @@ runs by interpreting bytecode for a register-based virtual machine, and has
 automatic memory management with incremental garbage collection, making it ideal
 for configuration, scripting, and rapid prototyping.")
 (license x11)))
+
+(define-public luajit
+  (package
+(name "luajit")
+(version "2.0.2")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "http://luajit.org/download/LuaJIT-";
+  version ".tar.gz"))
+  (sha256
+   (base32 "0f3cykihfdn3gi6na9p0xjd4jnv26z18m441n5vyg42q9abh4ln0"
+(build-system gnu-build-system)
+(arguments
+ '(#:tests? #f
+   #:phases (alist-delete 'configure %standard-phases)
+   #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")
+(home-page "http://www.luajit.org/";)
+(synopsis "Just in time compiler for Lua programming language version 5.1")
+(description
+ "LuaJIT is a Just-In-Time Compiler (JIT) for the Lua
+programming language. Lua is a powerful, dynamic and light-weight programming
+language.  It may be embedded or used as a general-purpose, stand-alone
+language.")
+(license x11)))
-- 
1.8.3.2



Re: luajit recipe

2014-02-05 Thread Cyril Roelandt

On 02/06/2014 01:11 AM, Raimon Grau wrote:

l...@gnu.org (Ludovic Courtès) writes:


Cyril Roelandt  skribis:


I think you should add this package to gnu/packages/lua.scm rather
than creating a new file.


Indeed, I had forgotten about that file.

Raimon: could you post an updated patch that does that?

Ludo’.


The releases of one or the other are not synched at all, and there's
fewer and fewer relation between both implementations, but it probably
makes sense to have them in the same file (as in scheme.scm).



Yes. For instance, we have a file named 'version_control.scm' in which 
we put VCS that have nothing in common :)


Cyril Roelandt.




Re: luajit recipe

2014-02-05 Thread Raimon Grau
l...@gnu.org (Ludovic Courtès) writes:

> Cyril Roelandt  skribis:
>
>> I think you should add this package to gnu/packages/lua.scm rather
>> than creating a new file.
>
> Indeed, I had forgotten about that file.
>
> Raimon: could you post an updated patch that does that?
>
> Ludo’.

The releases of one or the other are not synched at all, and there's
fewer and fewer relation between both implementations, but it probably
makes sense to have them in the same file (as in scheme.scm).

Will do the modifications and send the patch.

Thanks for your inputs!




Re: university group willing to contribute to GUIX

2014-02-05 Thread Quiliro Ordóñez Baca
ping

El lun 03 feb 2014 13:10:41 ECT, Quiliro Ordóñez Baca escribió:
>
>> Depending on what you really want to do, it might be that students
>> would be better off contributing to a well-established distro like
>> Trisquel.
>
> The university must present a result. What result will the students
> present? I must propose that so that they get interest in contributing.
> --
> Saludos libres,
> Quiliro Ordóñez
> 600 8579

--
Saludos libres,
Quiliro Ordóñez
600 8579



signature.asc
Description: OpenPGP digital signature


[PATCH] gnu: gnu-pw-mgr: Upgrade to 1.1

2014-02-05 Thread Eric Bavier
* gnu/packages/gnu-pw-mgr.scm (gnu-pw-mgr): Upgrade to 1.1
---
 gnu/packages/gnu-pw-mgr.scm |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnu-pw-mgr.scm b/gnu/packages/gnu-pw-mgr.scm
index d8340d6..3b66cde 100644
--- a/gnu/packages/gnu-pw-mgr.scm
+++ b/gnu/packages/gnu-pw-mgr.scm
@@ -27,15 +27,16 @@
 (define-public gnu-pw-mgr
   (package
 (name "gnu-pw-mgr")
-(version "1.0")
+(version "1.1")
 (source
  (origin
   (method url-fetch)
-  (uri (string-append "mirror://gnu/gnu-pw-mgr/gnu-pw-mgr-"
+  (uri (string-append "mirror://gnu/gnu-pw-mgr/gpw-"
+  version "/gnu-pw-mgr-"
   version ".tar.gz"))
   (sha256
(base32
-"0sn9gzngqkrv74iwxzn5ldqx3w73w9paldcdh8rsv9yvgarv2bm4"
+"1nqkwjsdcif51d1s4dizr1ifx0qpmkjzvi375vc27dwbav4dwalx"
 (build-system gnu-build-system)
 (inputs `(("which" ,which)))
 (home-page "http://www.gnu.org/software/gnu-pw-mgr/";)
-- 
1.7.9.5




[PATCH] gnu: glade New variable

2014-02-05 Thread John Darrington
* gnu/packages/gnome.scm (glade): New variable.
---
 gnu/packages/gnome.scm |   28 
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index cadea72..35417ea 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -530,3 +530,31 @@ API add-ons to make GTK+ widgets OpenGL-capable.")
 (description
  "ekiga is a gobject-based plugins engine, and is targetted at giving nthe 
API")
 (license lgpl2.0+)))
+
+
+
+(define-public glade3
+  (package
+(name "glade")
+(version "3.8.4")
+(source
+ (origin
+  (method url-fetch)
+  (uri (string-append "mirror://gnome/sources/" name "/"
+  (substring version 0 (string-rindex version #\.)) "/"
+  name "3-" version ".tar.xz"))
+  (sha256
+   (base32 
"021xgq2l18w3rvwms9aq2idm0fk66vwb4f777gs0qh3ap5shgbn7"
+(build-system gnu-build-system)
+(inputs
+ `(("gtk+" ,gtk+-2)
+   ("libxml2" ,libxml2)))
+(native-inputs
+ `(("intltool" ,intltool)
+   ("python" ,python)
+   ("pkg-config" ,pkg-config)))
+(home-page "https://glade.gnome.org";)
+(synopsis "GTK+ RAD tool")
+(description "Glade is a RAD tool to enable quick & easy development of
+user interfaces for the GTK+ toolkit and the GNOME desktop environment.") 
+(license lgpl2.0+)))
-- 
1.7.10.4




Re: [PATCH 2/2] dmd: Make config file if necessary when not run as root.

2014-02-05 Thread Ludovic Courtès
Alex Sassmannshausen  skribis:

> Ludovic Courtès writes:

[...]

>>> + (register-services)
>>^
>>> +;; Send dmd into the background
>>> + (action 'dmd 'daemonize)
>>^
>>> + (for-each start '())
>>^
>>
>> Extra space here.
>
> The extra spaces were there to stop emacs (maybe Scheme mode?) from
> going nutty because of the open parens within a string at column 0.

Oh, right, I forgot that.

[...]

>>>  (let ((config-file (string-append user-dmddir "/init.scm")))
>>>(cond ((not (file-exists? user-dmddir))
>>>   (mkdir user-dmddir)
>>> + (make-bare-init-file config-file)
>>>   config-file)
>>> +((not (file-exists? config-file))
>>> + (make-bare-init-file config-file))
>>>  (else config-file))
>>
>> So I guess this should be changed to:
>>
>>   (catch 'system-error
>> (lambda ()
>>   (mkdir user-dmddir)
>>   (make-bare-init-file config-file))
>> (const #f))
>
> I've changed this to :
>
>  (catch-system-error (mkdir user-dmddir))
>  (if (not (file-exists? config-file))
>  (make-bare-init-file config-file))
>  config-file)))

[...]

> I also think the race condition should not be a problem for the config
> file: if the config file is added after the check, then we simply
> override it. If the config file is removed after the check then guix
> crashes when it tries to load it, as it always would do before this
> patch.

Right.  Hopefully it’s not a problem with the test suite because tests
use ‘-c’ anyway.

> Hope this works now. You should find the patch inline.

Yep.  Pushed, thanks!

Ludo’.



Re: Neon and reverse address lookup

2014-02-05 Thread Ludovic Courtès
Andreas Enge  skribis:

> On Sun, Jan 19, 2014 at 04:40:43PM +0100, Ludovic Courtès wrote:
>> The issue is that the default config for the ‘hosts’ database when
>> resolv.conf is missing is (see nss/hosts-lookup.c):
>>   dns [!UNAVAIL=return] files
>> When doing a host name lookup, ‘dns’ is unavailable, so we go on with
>> ‘files’ and /etc/hosts is honored as expected.
>> However, when doing a reverse lookup, the DNS resolver
>> (__libc_res_nquery) returns ‘notfound’, and so ‘gethostbyaddr’ returns
>> immediately.
>> Changing the ‘hosts’ config to “dns files” solves this particular.
>> I’ll ask for advice on libc-help.
>
> Did anything come out of this?

Well, this has been reported:

  http://sourceware.org/ml/libc-alpha/2014-01/msg00351.html
  https://sourceware.org/bugzilla/show_bug.cgi?id=16475

I was hoping it would be fixed in time for 2.19, but it seems it won’t
happen.

> How should I proceed for the neon package?

If it’s not too difficult to skip just those tests that require reverse
lookup, that’s the best thing.  Otherwise just #:tests? #f.  (Either
way, with a comment pointing to the report above.)

Thanks,
Ludo’.



Re: none

2014-02-05 Thread Ludovic Courtès
John Darrington  skribis:

> I don't object to the spending time of writing changelogs.  I just think the 
> information that the GCS suggests is not helpful.  It is not usefull to say 
> changed file foo.scm, because using git show that is obvious.  There is even 
> a 
> perl script out in the wild somewhere to generate exactly that.  Typing it 
> in is redundant. 
>
> What would be  useful (but in general) we don't put in the changelogs is WHY a
> developer changed foo.scm

I disagree.  90% of the time, if something needs explanation, then the
explanation belongs as comments in the code.  Well, I’m just
paraphrasing the GCS.

If you would like to propose amendments to the GCS, please use
bug-standa...@gnu.org.

(Though I would instead recommend keeping up the good packaging work. ;-))

Thanks,
Ludo’.



Re: [PATCH 2/2] dmd: Make config file if necessary when not run as root.

2014-02-05 Thread Alex Sassmannshausen
Hello,

Thanks for the review.

Ludovic Courtès writes:

>> +(define (make-bare-init-file target)
>> […]
>
> I think the skeleton file should not include a copyright notice.

I've now removed this.

>> +;; Services known to dmd:
>> +;; Add new services to dmd here by providing them through the
>> +;; MAKE-SERVICE procedure to REGISTER SERVICES.
>
> IMO this should be ‘make-service’ and ‘register-services’ (lower-case,
> quoted.)

Done.

>> + (register-services)
>^
>> +;; Send dmd into the background
>> + (action 'dmd 'daemonize)
>^
>> + (for-each start '())
>^
>
> Extra space here.

The extra spaces were there to stop emacs (maybe Scheme mode?) from
going nutty because of the open parens within a string at column 0.

I've removed the spacing, but you may find when editing the file in
Emacs that syntax highlighting doesn't work properly after the above
definition.

Don't know if there is a solution to this or whether this is a bug in
Scheme mode.

>>  (let ((config-file (string-append user-dmddir "/init.scm")))
>>(cond ((not (file-exists? user-dmddir))
>>   (mkdir user-dmddir)
>> + (make-bare-init-file config-file)
>>   config-file)
>> +((not (file-exists? config-file))
>> + (make-bare-init-file config-file))
>>  (else config-file))
>
> So I guess this should be changed to:
>
>   (catch 'system-error
> (lambda ()
>   (mkdir user-dmddir)
>   (make-bare-init-file config-file))
> (const #f))

I've changed this to :

 (catch-system-error (mkdir user-dmddir))
 (if (not (file-exists? config-file))
 (make-bare-init-file config-file))
 config-file)))

I think you may have a situation where your configuration directory
exists, but where no config file exists. In this case I think we should
simply create the new file.

I also think the race condition should not be a problem for the config
file: if the config file is added after the check, then we simply
override it. If the config file is removed after the check then guix
crashes when it tries to load it, as it always would do before this
patch.

Hope this works now. You should find the patch inline.

Best wishes,

Alex

>From 860f97179991fde8fa0f8a0a2e7400c0cd14ec6e Mon Sep 17 00:00:00 2001
From: Alex Sassmannshausen 
Date: Sun, 2 Feb 2014 17:07:50 +0100
Subject: [PATCH] dmd: Make config file if necessary when not run as root.

* modules/dmd/support.scm (make-bare-init-file): new procedure to
  generate basic init file.
  (default-logfile): Check for init file, create it if necessary.
---
 modules/dmd/support.scm |   26 +-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/modules/dmd/support.scm b/modules/dmd/support.scm
index 16be9a7..f95e8e8 100644
--- a/modules/dmd/support.scm
+++ b/modules/dmd/support.scm
@@ -162,6 +162,29 @@ There is NO WARRANTY, to the extent permitted by law.")))
 ;; dmd default subdirectory if dmd is run as a normal user.
 (define user-dmddir (string-append user-homedir "/.dmd.d"))
 
+(define (make-bare-init-file target)
+  "Return #t if a bare init file was created at TARGET; #f otherwise.
+
+TARGET should be a string representing a filepath + name."
+  (with-output-to-file target
+(lambda ()
+  (format #t
+  ";; init.scm -- default dmd configuration file.
+
+;; Services known to dmd:
+;; Add new services (defined using 'make ') to dmd here by
+;; providing them as arguments to 'register-services'.
+(register-services)
+
+;; Send dmd into the background
+(action 'dmd 'daemonize)
+
+;; Services to start when dmd starts:
+;; Add the name of each service that should be started to the list
+;; below passed to 'for-each'.
+(for-each start '())
+"
+
 ;; Logfile.
 (define default-logfile
   (if (zero? (getuid))
@@ -174,6 +197,8 @@ There is NO WARRANTY, to the extent permitted by law.")))
   (string-append Prefix-dir "/etc/dmdconf.scm")
   (let ((config-file (string-append user-dmddir "/init.scm")))
 (catch-system-error (mkdir user-dmddir))
+(if (not (file-exists? config-file))
+(make-bare-init-file config-file))
 config-file)))
 
 ;; The directory where the socket resides.
@@ -231,4 +256,3 @@ which has essential bindings pulled in."
 	 (begin
 	   (local-output "Socket directory setup is insecure.")
 	   (quit 1))
-
-- 
1.7.9.5



Re: none

2014-02-05 Thread John Darrington
On Wed, Feb 05, 2014 at 11:17:25AM -0500, Mark H Weaver wrote:
 l...@gnu.org (Ludovic Court??s) writes:
 
 > John Darrington  skribis:
 >
 >> In my opinion the changelog conventions are achronistic, unintuitive,
 >> and bring benefit neither to developers nor users.
 >
 > Well, opinions may vary.
 >
 > It benefits me when I review other people???s patches, because it helps 
me
 > understand the structure of the change.  And it benefits me before I
 > commit something, because it forces me to review all of my patch, make
 > sure it???s consistent, make sure there???s no leftover, and giving me an
 > opportunity to add comments to code that appears non-obvious in
 > hindsight.
 
 I also find them very useful when digging through (possibly ancient)
 commit history.  Although all the information is in the actual patch,
 when looking through many commits it is much more convenient to read a
 summary of the changes.  One summary line is not enough detail.
 
 Of course, it's extra work to write these summaries, but IMO it's
 worthwhile.

I don't object to the spending time of writing changelogs.  I just think the 
information that the GCS suggests is not helpful.  It is not usefull to say 
changed file foo.scm, because using git show that is obvious.  There is even a 
perl script out in the wild somewhere to generate exactly that.  Typing it 
in is redundant. 

What would be  useful (but in general) we don't put in the changelogs is WHY a
developer changed foo.scm  Put yourself in the shoes of a person investigating a
problem in 3 years' time.  He can see that developer fred did X.  He doesn't
need fred to tell him that.  What he needs is fred to explain his reasoning for 
doing X not a statement that he has done it.  That way he can make an informed
decision about which way to take the code now.
 
J'
 

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.



signature.asc
Description: Digital signature


Re: Neon and reverse address lookup

2014-02-05 Thread Andreas Enge
On Sun, Jan 19, 2014 at 04:40:43PM +0100, Ludovic Courtès wrote:
> The issue is that the default config for the ‘hosts’ database when
> resolv.conf is missing is (see nss/hosts-lookup.c):
>   dns [!UNAVAIL=return] files
> When doing a host name lookup, ‘dns’ is unavailable, so we go on with
> ‘files’ and /etc/hosts is honored as expected.
> However, when doing a reverse lookup, the DNS resolver
> (__libc_res_nquery) returns ‘notfound’, and so ‘gethostbyaddr’ returns
> immediately.
> Changing the ‘hosts’ config to “dns files” solves this particular.
> I’ll ask for advice on libc-help.

Did anything come out of this? How should I proceed for the neon package?

Andreas




Re: Gnunet-0.10.0 recipe

2014-02-05 Thread Andreas Enge
On Tue, Feb 04, 2014 at 12:00:39AM +0100, Ludovic Courtès wrote:
> For the record, patches for pkgblurbs.txt (the file containing those
> descriptions in GNU Womb) should go to bug-w...@gnu.org.

Good to know. I could submit a small patch concerning this last sentence,
but as the gnunet developers wish to make more changes, I will let them
do so.

Currently, I cannot compile gnunet because the input gnurl fails with:
   TESTFAIL: These test cases failed: 172 
The same holds for recent builds of curl, see
   http://hydra.gnu.org/build/37634
If someone more knowledgeable could look into this, it would be very helpful.
If one can believe hydra, then Commit 2a72eee still worked, and adding
inkscape broke everything. Quite unbelievable indeed.

Meanwhile, I am holding the gnunet patch back.

Andreas




Re: none

2014-02-05 Thread Mark H Weaver
l...@gnu.org (Ludovic Courtès) writes:

> John Darrington  skribis:
>
>> In my opinion the changelog conventions are achronistic, unintuitive,
>> and bring benefit neither to developers nor users.
>
> Well, opinions may vary.
>
> It benefits me when I review other people’s patches, because it helps me
> understand the structure of the change.  And it benefits me before I
> commit something, because it forces me to review all of my patch, make
> sure it’s consistent, make sure there’s no leftover, and giving me an
> opportunity to add comments to code that appears non-obvious in
> hindsight.

I also find them very useful when digging through (possibly ancient)
commit history.  Although all the information is in the actual patch,
when looking through many commits it is much more convenient to read a
summary of the changes.  One summary line is not enough detail.

Of course, it's extra work to write these summaries, but IMO it's
worthwhile.

  Mark

> I think the rationale at
>  still
> holds.
>
> Ludo’.



Re: [PATCH 2/3] gnu: inkscape: New module

2014-02-05 Thread John Darrington
On Wed, Feb 05, 2014 at 02:49:17PM +0100, Ludovic Court??s wrote:
 GPLv2 reads:
 
   If the Program does not specify a version number of this License, you
   may choose any version ever published by the Free Software Foundation.
 
Yes. I know.  - And in this case, the program DOES (indirectly) specify a 
version 
number, by refering to a file which contains a specific version.   But if you 
want
to interpret this differently, I won't argue.

J'


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.




Re: luajit recipe

2014-02-05 Thread Ludovic Courtès
Cyril Roelandt  skribis:

> I think you should add this package to gnu/packages/lua.scm rather
> than creating a new file.

Indeed, I had forgotten about that file.

Raimon: could you post an updated patch that does that?

Ludo’.



Re: [PATCH 2/3] gnu: inkscape: New module

2014-02-05 Thread Ludovic Courtès
John Darrington  skribis:

> On Wed, Feb 05, 2014 at 12:09:02AM +0100, Ludovic Court??s wrote:

[...]

>  > +(description "Inkscape is a free vector graphics editor similar to
>  > +proprietary competitors. What sets Inkscape apart is its use of 
> Scalable
>  > +Vector Graphics (SVG), an open XML-based W3C standard, as the native 
> format.")   
>  
>  I removed the ???free??? and the reference to proprietary competitors.
>
> Fair enough.  The blurb on the website mentions them by name. I decided to 
> drop
> the names.  If you want to omit any mention altogether, I don't have any 
> objection.

Yeah, what we agreed on long ago was to not mention “free” in
descriptions (or similar), because everything is free in the distro.
Also the GCS have long recommended against referring to non-free
software, and it clearly doesn’t bring much here (the situation may be
different for software that aims for interoperability with non-free
software, like LibreDWG or Octave.)

>  > +(license license:gpl2))) ;; Somewhat ambiguous whether v2 or v2+ 
> is intended
>  
>  It???s actually GPLv2+ since the source files do not specify the version.
>
> It kind of does indirectly. It says "Under GPL - See the file COPYING" and
> COPYING contains the text for v2.   I thought it safer to assume v2 only.

GPLv2 reads:

  If the Program does not specify a version number of this License, you
  may choose any version ever published by the Free Software Foundation.

Thanks,
Ludo’.