gnu-build-system should set DESTDIR
Per recent discussions: I think the make install target in gnu-build-system should set DESTDIR to / (or /.) Rationale: Many upstream makefiles (eg: https://git.gnome.org/browse/gnome-themes-standard/tree/themes/HighContrast/icons/Makefile.am) assume that when DESTDIR is unset (or is ) then the package is being installed in a live system: if test -z $(DESTDIR); then \ echo Updating Gtk icon cache.; \ $(gtk_update_icon_cache); \ else \ echo *** Icon cache not updated. After (un)install, run this:; \ echo *** $(gtk_update_icon_cache); \ fi I have noticed that a number of packages in /nix/store/ have their own version of icon-theme.cache leading to warnings when doing guix package --install So we need to set DESTDIR to *something* and to arrange for some kind of post-install hook to update the cache. The same goes for top level info nodes. J' -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key.
Re: gnu-build-system should set DESTDIR
John Darrington j...@darrington.wattle.id.au skribis: I think the make install target in gnu-build-system should set DESTDIR to / (or /.) Rationale: Many upstream makefiles (eg: https://git.gnome.org/browse/gnome-themes-standard/tree/themes/HighContrast/icons/Makefile.am) We’re talking about GNOME makefiles only, I think. The snippet below is clearly a hack IMO. assume that when DESTDIR is unset (or is ) then the package is being installed in a live system: if test -z $(DESTDIR); then \ echo Updating Gtk icon cache.; \ $(gtk_update_icon_cache); \ else \ echo *** Icon cache not updated. After (un)install, run this:; \ echo *** $(gtk_update_icon_cache); \ fi I have noticed that a number of packages in /nix/store/ have their own version of icon-theme.cache leading to warnings when doing guix package --install So we need to set DESTDIR to *something* and to arrange for some kind of post-install hook to update the cache. The same goes for top level info nodes. What about this: we add a GNOME build system doing a few things, such as handling schemas [0] and setting DESTDIR if that’s a common idiom. WDYT? The post-install hook is definitely on the to-do list, but it needs a bit of thought. Thanks, Ludo’. [0] http://lists.gnu.org/archive/html/guix-devel/2013-10/msg00171.html
Re: gnu-build-system should set DESTDIR
On 02/10/2014 09:19 AM, John Darrington wrote: I think the make install target in gnu-build-system should set DESTDIR to / (or /.) Rationale: Setting DESTDIR will then make the install target to install files in the chroot dir (most likely to /usr/local/ or the prefix dir inside chroot) inside the chroot. But the intention is to install into a directory given by the --prefix variable to `configure'. Sree
Re: gnu-build-system should set DESTDIR
On Mon, Feb 10, 2014 at 01:58:35PM +0100, Sree Harsha Totakura wrote: On 02/10/2014 09:19 AM, John Darrington wrote: I think the make install target in gnu-build-system should set DESTDIR to / (or /.) Setting DESTDIR will then make the install target to install files in the chroot dir (most likely to /usr/local/ or the prefix dir inside chroot) inside the chroot. But the intention is to install into a directory given by the --prefix variable to `configure'. Sree Files are installed into $DESTDIR$prefix so setting DESTDIR to / will not break this. J' -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key.
Re: gnu-build-system should set DESTDIR
On Mon, Feb 10, 2014 at 01:56:49PM +0100, Ludovic Court??s wrote: We???re talking about GNOME makefiles only, I think. The snippet below is clearly a hack IMO. Two non-gnome packages which also do this include gnubik and pspp J' -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. signature.asc Description: Digital signature
Re: [PATCH] gnu: texinfo: Make version 4.13a available
Mark H Weaver m...@netris.org skribis: This patch adds texinfo-4.13a back to Guix, as an alternative to texinfo-5.2. The motivation is that building Guile's manual using texinfo-4.13a takes about 6 seconds on my Yeeloong, compared with about 12 *minutes* using texinfo-5.2. Ouch. My laptop is faster, but yeah, I sympathize. :-) I wonder about the environmental footprint of the switch to Texinfo 5. From ea307b2af2d995b4f37c27e52f5d259131d27fe8 Mon Sep 17 00:00:00 2001 From: Mark H Weaver m...@netris.org Date: Mon, 10 Feb 2014 02:04:38 -0500 Subject: [PATCH] gnu: texinfo: Make version 4.13a available. * gnu/packages/texinfo.scm (texinfo-4): New variable. OK to commit. Thanks, Ludo’.
Re: gnu-build-system should set DESTDIR
On Mon, Feb 10, 2014 at 05:09:10PM +0100, Ludovic Court??s wrote: John Darrington j...@darrington.wattle.id.au skribis: On Mon, Feb 10, 2014 at 01:56:49PM +0100, Ludovic Court??s wrote: We???re talking about GNOME makefiles only, I think. The snippet below is clearly a hack IMO. Two non-gnome packages which also do this include gnubik and pspp They do what? Their recipes don???t fiddle with DESTDIR, do they? No. No package should ever change the value of DESTDIR. They simply update the icon cache iff $DESTDIR = J' -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. signature.asc Description: Digital signature
Re: [PATCH 1/2] gnu: gnunet: Remove Gstreamer dependency.
I’ve reported the bug at https://bugzilla.gnome.org/show_bug.cgi?id=724073 and temporarily disabled tests in the meantime. Ludo’.
Re: [PATCH] gnu: gnunet: Add GNUnet-0.10.0.
Sree Harsha Totakura sreehar...@totakura.in skribis: * gnunet/packages/gnunet.scm (gnunet): New variable. * gnu/package/patches/gnunet-fix-scheduler.patch: New file. * gnu/package/patches/gnunet-fix-tests.patch: New file. * gnu-system.am (dist_patch_DATA): Add the above two patch files. Co-authored-by: Andreas Enge andr...@enge.fr Applied. However, gnurl fails to build for me: --8---cut here---start-8--- TESTDONE: 365 tests out of 366 reported OK: 99% TESTFAIL: These test cases failed: 172 TESTDONE: 911 tests were considered during 140 seconds. Makefile:723: recipe for target 'quiet-test' failed make[1]: *** [quiet-test] Error 1 make[1]: Leaving directory '/tmp/nix-build-gnurl-7.34.0.drv-0/gnurl-7.34.0/tests' Makefile:1069: recipe for target 'test' failed --8---cut here---end---8--- Ideas? Thanks, Ludo’.
Re: [PATCH] gnu: gnunet: Add GNUnet-0.10.0.
Hello, On Mon, Feb 10, 2014 at 11:15:30PM +0100, Ludovic Courtès wrote: Sree Harsha Totakura sreehar...@totakura.in skribis: * gnunet/packages/gnunet.scm (gnunet): New variable. * gnu/package/patches/gnunet-fix-scheduler.patch: New file. * gnu/package/patches/gnunet-fix-tests.patch: New file. * gnu-system.am (dist_patch_DATA): Add the above two patch files. Co-authored-by: Andreas Enge andr...@enge.fr Applied. However, gnurl fails to build for me: see my message from February 5: https://lists.gnu.org/archive/html/guix-devel/2014-02/msg00057.html To summarise, I do not know what happens. Please do not push the patch yet, as said in that message, I have the patch in a branch with a few small modifications. Andreas
