Re: [PATCH] gnu: Add ola

[John J Foerch]

l...@gnu.org (Ludovic Courtès) writes:

> John J Foerch <jjfoe...@earthlink.net> skribis:
>
>> l...@gnu.org (Ludovic Courtès) writes:
>>
>>> Hi,
>>>
>>> Marius Bakke <mba...@fastmail.com> skribis:
>>>
>>>>> 2 files changed, 4 insertions(+), 6 deletions(-)
>>>>> gnu/local.mk | 1 +
>>>>> gnu/packages/ola.scm | 9 +++--
>>>>
>>>> Perhaps this could be added to something like automation.scm?
>>>
>>> Makes sense to me, unless there are many other OLA-related packages.
>>>
>>> John: could you send an updated patch incorporating suggestions from
>>> Alex and Marius?  The rest LGTM.
>>>
>>> Thanks!
>>>
>>> Ludo’.
>>
>> How about lighting.scm?  There are a few other lighting programs that
>> could potentially be packaged.
>
> Sure, fine with me!
>
> Ludo’.

Here it is!

>From d4738938d325dcf0452346f48f0bf02c020bd6d2 Mon Sep 17 00:00:00 2001
From: "John J. Foerch" <jjfoe...@earthlink.net>
Date: Wed, 3 Aug 2016 21:36:52 -0500
Subject: [PATCH] gnu: Add ola.

* gnu/packages/ola.scm (ola): New variable.
---
 gnu/local.mk  |  1 +
 gnu/packages/lighting.scm | 75 +++
 2 files changed, 76 insertions(+)
 create mode 100644 gnu/packages/lighting.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index efb00b9..9c27e11 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -213,6 +213,7 @@ GNU_SYSTEM_MODULES =\
   %D%/packages/libusb.scm			\
   %D%/packages/libunwind.scm			\
   %D%/packages/libupnp.scm			\
+  %D%/packages/lighting.scm \
   %D%/packages/links.scm			\
   %D%/packages/linux.scm			\
   %D%/packages/lirc.scm				\
diff --git a/gnu/packages/lighting.scm b/gnu/packages/lighting.scm
new file mode 100644
index 000..5101fba
--- /dev/null
+++ b/gnu/packages/lighting.scm
@@ -0,0 +1,75 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 John J. Foerch <jjfoe...@earthlink.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages lighting)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages check)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages gnunet)
+  #:use-module (gnu packages flex)
+  #:use-module (gnu packages libftdi)
+  #:use-module (gnu packages libusb)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages protobuf))
+
+(define-public ola
+  (package
+(name "ola")
+(version "0.10.2")
+(source (origin
+  (method url-fetch)
+  (uri (string-append
+"https://github.com/OpenLightingProject/ola/releases/download/;
+version "/ola-" version ".tar.gz"))
+  (sha256
+   (base32
+"09zx1c8nkj29shfdzkahrh9397m3mwnsy0gj7jrb63f89f3n2vlq"
+(build-system gnu-build-system)
+(native-inputs
+ `(("bison" ,bison)
+   ("cppunit" ,cppunit)
+   ("flex" ,flex)
+   ("pkg-config" ,pkg-config)))
+(inputs
+ `(("libftdi" ,libftdi)
+   ("libmicrohttpd" ,libmicrohttpd)
+   ("libusb" ,libusb)
+   ("libuuid" ,util-linux)
+   ("zlib" ,zlib)))
+(propagated-inputs
+ `(("protobuf" ,protobuf))) ;; for pkg-config --libs libola
+(arguments
+ `(;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing
+   ;; build to fail on low memory systems.  We disable that with the
+   ;; following configure flags.
+   #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")))
+(synopsis "Framework for controlling entertainment lighting equipment")
+(description "The Open Lighting Architecture is a framework for lighting
+control information.  It supports a range of protocols and over a dozen USB
+devices.  It can run as a standalone service, which is useful for converting
+signals between protocols, or alternatively using the OLA API, it can be used
+as the backend for lighting control software.  OLA runs on many different
+platforms including ARM, which makes it a perfect fit for low cost Ethernet to
+DMX gateways.")
+(home-page "https://www.openlighting.org/ola;)
+(license license:lgpl2.1+)))
-- 
2.9.3

Re: [PATCH] gnu: Add ola

[John J Foerch]

l...@gnu.org (Ludovic Courtès) writes:

> Hi,
>
> Marius Bakke  skribis:
>
>>> 2 files changed, 4 insertions(+), 6 deletions(-)
>>> gnu/local.mk | 1 +
>>> gnu/packages/ola.scm | 9 +++--
>>
>> Perhaps this could be added to something like automation.scm?
>
> Makes sense to me, unless there are many other OLA-related packages.
>
> John: could you send an updated patch incorporating suggestions from
> Alex and Marius?  The rest LGTM.
>
> Thanks!
>
> Ludo’.

How about lighting.scm?  There are a few other lighting programs that
could potentially be packaged.

--
John Foerch

Re: [PATCH] gnu: Add ola

[John J Foerch]

Alex Vong  writes:

> Hi,
>
> The patch builds on my machine and lgtm. I make some minor changes (in
> diff format):
>
> 1. Add ola.scm to gnu/local.mk, so that the build system knows the
>presence of gnu/package/ola.scm. The commit message should say this
>as well.
>
> 2. Move protobuf from propagated-inputs to inputs. I don't know if this
>is right. But usually library depedencies don't need to be propagated
>(?), only command line tools needed at run-time need to be
>propagated, right?
>
> 3. Remove make-flags and phases. %standard-phases is the implicit
>phases, so there is no need to specify it. I think PREFIX is already
>handled by gnu-build-system. So it is not needed.
>
>
> 2 files changed, 4 insertions(+), 6 deletions(-)
> gnu/local.mk | 1 +
> gnu/packages/ola.scm | 9 +++--
>
> modified   gnu/local.mk
> @@ -261,6 +261,7 @@ GNU_SYSTEM_MODULES =  \
>%D%/packages/nvi.scm   \
>%D%/packages/ocaml.scm \
>%D%/packages/ocr.scm   \
> +  %D%/packages/ola.scm   \
>%D%/packages/onc-rpc.scm   \
>%D%/packages/openbox.scm   \
>%D%/packages/openldap.scm  \
> modified   gnu/packages/ola.scm
> @@ -55,16 +55,13 @@
> ("libmicrohttpd" ,libmicrohttpd)
> ("libusb" ,libusb)
> ("libuuid" ,util-linux)
> -   ("zlib" ,zlib)))
> -(propagated-inputs
> - `(("protobuf" ,protobuf)))
> +   ("zlib" ,zlib)
> +   ("protobuf" ,protobuf)))
>  (arguments
>   `(;; G++ >= 4.8 macro expansion tracking requires lots of memory, 
> causing
> ;; build to fail on low memory systems.  We disable that with the
> ;; following configure flags.
> -   #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")
> -   #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs 
> "out")))
> -   #:phases %standard-phases))
> +   #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")))
>  (synopsis "Framework for controlling entertainment lighting equipment")
>  (description "The Open Lighting Architecture is a framework for lighting
>  control information.  It supports a range of protocols and over a dozen USB
>
>
> Thanks for the patch. How do the others think?
>
> Cheers,
> Alex


Hello,

Thank you for taking a look and for catching those details.  Protobuf as
a propagated input is correct however - it is needed for 'pkg-config
--libs libola'.

--
John Foerch

[PATCH] gnu: Add ola

[John J Foerch]

Hello,

Here is a package definition for ola (Open Lighting Architecture).  I
was having trouble getting ola's python bindings to build, as detailed
in an earlier message, so this patch does not include them.  I intend to
add them when I figure out how, but since they're not essential to the
function of the library, I think they need not block adding the basic
package.  Ola also provides bindings for java, but they depend on Apache
maven, which we don't seem to have a package for yet, so here again, I
think that this can be added later.

Please let me know of anything that should be changed.

Thank you,

--
John Foerch

>From f600e8a43997efecb9587a9c39579a7d6f3291f4 Mon Sep 17 00:00:00 2001
From: "John J. Foerch" <jjfoe...@earthlink.net>
Date: Wed, 3 Aug 2016 21:36:52 -0500
Subject: [PATCH] gnu: Add ola.

* gnu/packages/ola.scm (ola): New variable.
---
 gnu/packages/ola.scm | 77 
 1 file changed, 77 insertions(+)
 create mode 100644 gnu/packages/ola.scm

diff --git a/gnu/packages/ola.scm b/gnu/packages/ola.scm
new file mode 100644
index 000..f47c029
--- /dev/null
+++ b/gnu/packages/ola.scm
@@ -0,0 +1,77 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 John J. Foerch <jjfoe...@earthlink.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages ola)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages check)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages gnunet)
+  #:use-module (gnu packages flex)
+  #:use-module (gnu packages libftdi)
+  #:use-module (gnu packages libusb)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages protobuf))
+
+(define-public ola
+  (package
+(name "ola")
+(version "0.10.2")
+(source (origin
+  (method url-fetch)
+  (uri (string-append
+"https://github.com/OpenLightingProject/ola/releases/download/;
+version "/ola-" version ".tar.gz"))
+  (sha256
+   (base32
+"09zx1c8nkj29shfdzkahrh9397m3mwnsy0gj7jrb63f89f3n2vlq"
+(build-system gnu-build-system)
+(native-inputs
+ `(("bison" ,bison)
+   ("cppunit" ,cppunit)
+   ("flex" ,flex)
+   ("pkg-config" ,pkg-config)))
+(inputs
+ `(("libftdi" ,libftdi)
+   ("libmicrohttpd" ,libmicrohttpd)
+   ("libusb" ,libusb)
+   ("libuuid" ,util-linux)
+   ("zlib" ,zlib)))
+(propagated-inputs
+ `(("protobuf" ,protobuf)))
+(arguments
+ `(;; G++ >= 4.8 macro expansion tracking requires lots of memory, causing
+   ;; build to fail on low memory systems.  We disable that with the
+   ;; following configure flags.
+   #:configure-flags (list "CXXFLAGS=-ftrack-macro-expansion=0")
+   #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+   #:phases %standard-phases))
+(synopsis "Framework for controlling entertainment lighting equipment")
+(description "The Open Lighting Architecture is a framework for lighting
+control information.  It supports a range of protocols and over a dozen USB
+devices.  It can run as a standalone service, which is useful for converting
+signals between protocols, or alternatively using the OLA API, it can be used
+as the backend for lighting control software.  OLA runs on many different
+platforms including ARM, which makes it a perfect fit for low cost Ethernet to
+DMX gateways.")
+(home-page "https://www.openlighting.org/ola;)
+(license license:lgpl2.1+)))
-- 
2.9.0

hackage importer problem

[John J Foerch]

Hello,

I'm seeing a problem with the hackage importer with the git-annex
package:

  $ guix import hackage git-annex
  Syntax error: unexpected token : custom-setup (at line 316, column 0)
  Syntax error: unexpected end of input
  guix import: error: failed to download cabal file for package 'git-annex'

git-annex.cabal is here:

  http://hackage.haskell.org/package/git-annex-6.20160808/git-annex.cabal

Is it a bug in the importer?

Thank you,

--
John Foerch

Re: [PATCH] gnu: Add ola.

[John J Foerch]

Hi all,

I have made some progress with the ola package, but have run into
difficulty related to python used in its test phase.  Relevant code and
logs can be found here:

  The package definition: http://retroj.net/scratch/ola-guix/ola.scm

  The build log: http://retroj.net/scratch/ola-guix/ola-guix-build.log

  OLA's config.log: http://retroj.net/scratch/ola-guix/config.log

  Log of the test suite errors:
  http://retroj.net/scratch/ola-guix/test-suite.log

The ./configure argument --enable-rdm-tests turns on some tests that use
python.  These tests require the python-protobuf package.  Config.log
shows that protobuf was found, by whatever means autoconf uses to find
it, but the tests fail with this:

  File "/tmp/guix-build-ola-0.10.2.drv-0/ola-0.10.2/python/ola/PidStore.py",
 line 27, in  from google.protobuf import text_format
  ImportError: No module named 'google'

  ...

  File 
"/tmp/guix-build-ola-0.10.2.drv-0/ola-0.10.2/python/ola/rpc/SimpleRpcController.py",
line 18, in  from google.protobuf import service
  ImportError: No module named 'google'

(For the complete messages, see links above.)

My best guess is that when the rdm tests run, PYTHONPATH does not
include whatever directory the google.protobuf module is in.  Anybody
know what's going on here?

Thank you,

--
John Foerch

Re: [PATCH] gnu: Add ola.

[John J Foerch]

John J Foerch <jjfoe...@earthlink.net> writes:

> ren...@openmailbox.org writes:
>
>> John,
>>
>>> Thank you so much for doing this.  If 'make check' succeeds, those are
>>> the main tests, but to check installation, I would look for the
>>> following programs being installed:
>>>
>>> ola   ola_e131ola_plugin_state   ola_rdm_set
>>> ola_set_priority  ola_trigger ola_uni_name   ola_artnet
>>> ola_dmxconsoleola_patch   ola_rdm_discover
>>> ola_recorder
>>> ola_streaming_client  ola_uni_infoola_uni_stats  olad
>>> ola_dmxmonitorola_plugin_info ola_rdm_getola_set_dmx
>>> ola_timecode  ola_uni_merge   ola_usbpro
>>> ola_dev_info
>>>
>>
>> I see only the following programs:
>>
>> ola_artnetola_plugin_state  ola_set_priority
>> ola_uni_name
>> olad  ola_rdm_discover  ola_streaming_client
>> ola_uni_stats
>> ola_dev_info  ola_rdm_get   ola_timecode
>> ola_usbpro
>> ola_e131  ola_rdm_set   ola_trigger
>> ola_patch ola_recorder  ola_uni_info
>> ola_plugin_info   ola_set_dmx   ola_uni_merge
>>
>
> That seems fine.  I don't know what every single one of them does, but
> all of the main ones are present.
>
>>
>>> These are the programs installed by the Debian ola package, and I don't
>>> know what packaging options might have affected which were installed,
>>> but the list should be more or less the same.
>>>
>>> To start the ola daemon and generate a config:
>>>
>>> olad -c ~/my-ola
>>
>> when the command is run, it displays message:
>>
>> $ olad -c ~/my-ola
>>
>> common/io/IOUtils.cpp:39: open(/dev/dmx0): No such file or directory
>> plugins/opendmx/OpenDmxPlugin.cpp:80: Could not open /dev/dmx0 No such
>> file or directory
>> common/network/IPV4Address.cpp:89: Could not convert address 677966233
>> common/io/IOUtils.cpp:39: open(/dev/kldmx0): No such file or directory
>> plugins/karate/KaratePlugin.cpp:79: Could not open /dev/kldmx0 No such
>> file or directory
>>
>
> The ones complaining about missing /dev entries are nothing to worry
> about - those are plugins just looking for hardware that isn't there.
> They can be disabled in files in ~/my-ola, but by default, it will
> search for every kind of device.
>
> The one that I don't know the meaning of is the IPV4Address.cpp:89
> error.  I will ask about that.
>
>>
>>
>>> This should start a web service on port 9090, so you can point a web
>>> browser to localhost:9090 and see if anything comes up.
>>
>> the service is not responding. Any ideas?
>>
>> Thanks.
>
> According to this page, http support is an optional build option.  I
> wasn't aware of that, but it would be convenient to enable.
>
>   
> https://www.openlighting.org/ola/getting-started/using-ola/#How_to_setup_an_interface
>
> To enable it, it needs libmicrohttpd.  It looks like guix has a package
> for that - nice!
>
> Thank you,
>
> --
> John Foerch

I found this to solve the memory issue, so I can build the package now:
https://github.com/OpenLightingProject/ola/issues/1103

Thank you for your help.  I am now working on some other issues with the
package and hope to post a patch soon.

--
John Foerch

Re: ola

[John J Foerch]

l...@gnu.org (Ludovic Courtès) writes:

> John J Foerch <jjfoe...@earthlink.net> skribis:
>
>> Alex Vong <alexvong1...@gmail.com> writes:
>>
>>> Hi John,
>>>
>>> John J Foerch <jjfoe...@earthlink.net> writes:
>>>
>>>> Hello,
>>>>
>>>> I'm trying to build OLA (Open Lighting Architecture) and I ran into some
>>>> difficulty.  Ola is often used as a service, but at this point all I'm
>>>> interested in is making an ordinary package.  The build times out after
>>>> a certain point:
>>>>
>>> I try to build it on my machine using your recipe (I copy the package
>>> definition into entertainment.scm and add the required imports) and it
>>> works.
>>>
>>> @ build-succeeded 
>>> /gnu/store/m0qkm9zwjaaynnn8pl0r1m6avbv0lhs0-ola-0.10.2.drv -
>>> /gnu/store/16y19wwciazzrnw4if8g1d5b8i1piaw9-ola-0.10.2
>>>
>>> Does you machine has very little ram?
>>>
>>> Build log:
>>>
>>>
>>> Cheers,
>>> Alex
>>
>> Okay, that is encouraging.  Yes, I'm building this on a 2GHz Intel Core2
>> Duo laptop with 1GB of memory.
>
> Compiling C++ code can be memory-intensive, so it may be that your
> machine was swapping.
>
> Ludo’.

Hi, I have a favor to ask of anybody in the guix community - is there
anybody who would be willing to finish this package for me, since I
can't build and test it?  This is a library that I need to use, but
maybe the only way that I can use it (until I upgrade my computer) will
be to install it as a substitute.

Or are there any other suggestions for how I can build this myself?

Thank you,

--
John Foerch

Re: ola

[John J Foerch]

Alex Vong <alexvong1...@gmail.com> writes:

> Hi John,
>
> John J Foerch <jjfoe...@earthlink.net> writes:
>
>> Hello,
>>
>> I'm trying to build OLA (Open Lighting Architecture) and I ran into some
>> difficulty.  Ola is often used as a service, but at this point all I'm
>> interested in is making an ordinary package.  The build times out after
>> a certain point:
>>
> I try to build it on my machine using your recipe (I copy the package
> definition into entertainment.scm and add the required imports) and it
> works.
>
> @ build-succeeded /gnu/store/m0qkm9zwjaaynnn8pl0r1m6avbv0lhs0-ola-0.10.2.drv -
> /gnu/store/16y19wwciazzrnw4if8g1d5b8i1piaw9-ola-0.10.2
>
> Does you machine has very little ram?
>
> Build log:
>
>
> Cheers,
> Alex

Okay, that is encouraging.  Yes, I'm building this on a 2GHz Intel Core2
Duo laptop with 1GB of memory.

--
John Foerch

Re: [PATCH] gnu: Add di.

[John J Foerch]

Leo Famulari <l...@famulari.name> writes:

> On Thu, Jul 07, 2016 at 12:30:11PM -0400, John J Foerch wrote:
>> Any remaining blocking issues on this?
>
> Pushed as 614023981!

Many thanks.

--
John Foerch

ola

[John J Foerch]

Hello,

I'm trying to build OLA (Open Lighting Architecture) and I ran into some
difficulty.  Ola is often used as a service, but at this point all I'm
interested in is making an ordinary package.  The build times out after
a certain point:

g++ -DHAVE_CONFIG_H -I.-I./include -I./include -Wall -Wformat -W 
-fvisibility-inlines-hidden -pthread -Werror  -DTEST_SRC_DIR=\".\" 
-DTEST_BUILD_DIR=\".\" -g -O2 -pthread -MT 
common/messaging/common_messaging_DescriptorTester-SchemaPrinterTest.o -MD -MP 
-MF 
common/messaging/.deps/common_messaging_DescriptorTester-SchemaPrinterTest.Tpo 
-c -o common/messaging/common_messaging_DescriptorTester-SchemaPrinterTest.o 
`test -f 'common/messaging/SchemaPrinterTest.cpp' || echo 
'./'`common/messaging/SchemaPrinterTest.cpp
building of `/gnu/store/m0qkm9zwjaaynnn8pl0r1m6avbv0lhs0-ola-0.10.2.drv' 
timed out after 3600 seconds of silence
@ build-failed /gnu/store/m0qkm9zwjaaynnn8pl0r1m6avbv0lhs0-ola-0.10.2.drv - 
timeout
guix build: error: build failed: build of 
`/gnu/store/m0qkm9zwjaaynnn8pl0r1m6avbv0lhs0-ola-0.10.2.drv' failed

Full build log here:
http://retroj.net/scratch/20160707-ola-build-on-guix.log

Attached is the package definition so far.

>From 1ec078f6293596d4f00c4f96bde7780ef14a750f Mon Sep 17 00:00:00 2001
From: "John J. Foerch" <jjfoe...@earthlink.net>
Date: Thu, 7 Jul 2016 22:31:04 -0400
Subject: [PATCH] gnu: Add ola.


diff --git a/gnu/packages/ola.scm b/gnu/packages/ola.scm
new file mode 100644
index 000..10e64f8
--- /dev/null
+++ b/gnu/packages/ola.scm
@@ -0,0 +1,65 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 John J. Foerch <jjfoe...@earthlink.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages ola)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages flex)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages check)
+  #:use-module (gnu packages protobuf)
+  #:use-module (gnu packages compression))
+
+(define-public ola
+  (package
+   (name "ola")
+   (version "0.10.2")
+   (source (origin
+(method url-fetch)
+(uri (string-append
+  "https://github.com/OpenLightingProject/ola/releases/download/;
+  version "/ola-" version ".tar.gz"))
+(sha256
+ (base32
+  "09zx1c8nkj29shfdzkahrh9397m3mwnsy0gj7jrb63f89f3n2vlq"
+   (build-system gnu-build-system)
+   (native-inputs
+`(("bison" ,bison)
+  ("flex" ,flex)
+  ("pkg-config" ,pkg-config)
+  ("libuuid" ,util-linux)
+  ("cppunit" ,cppunit)
+  ("protobuf" ,protobuf)
+  ("zlib" ,zlib)))
+   (arguments
+`(#:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+  #:phases %standard-phases))
+   (synopsis "Framework for controlling entertainment lighting equipment")
+   (description "The Open Lighting Architecture is a framework for lighting
+control information.  It supports a range of protocols and over a dozen USB
+devices.  It can run as a standalone service, which is useful for converting
+signals between protocols, or alternatively using the OLA API, it can be used
+as the backend for lighting control software.  OLA runs on many different
+platforms including ARM, which makes it a perfect fit for low cost Ethernet to
+DMX gateways.")
+   (home-page "https://www.openlighting.org/ola/;)
+   (license license:lgpl2.1+)))
-- 
2.9.0


--
John Foerch

Re: [PATCH] gnu: Add di.

[John J Foerch]

John J Foerch <jjfoe...@earthlink.net> writes:

> Leo Famulari <l...@famulari.name> writes:
>
>> On Mon, Jul 04, 2016 at 11:18:50AM -0400, John J Foerch wrote:
>>> * gnu/packages/admin.scm (di): New variable.
>>
>> A few final nitpicks before others make a decision about the test suite
>> ;)
>>
>>> +(arguments
>>> + `(#:phases
>>> +   (modify-phases %standard-phases
>>> + (delete 'configure)
>>> + (delete 'check)
>>
>> We prefer to use #:tests? #f instead of deleting the check phase.
>>
>>> + (add-before 'build 'setup-environment
>>> +   (lambda* (#:key outputs #:allow-other-keys)
>>> + (setenv "CC" "gcc")
>>> + (setenv "prefix" (assoc-ref outputs "out"))
>>> + #t)))
>>> +   #:make-flags (list "-e")))
>>
>> I would like for '-e' to be expanded to '--environment-overrides'. It
>> seems that Schemers abhor abbreviations.
>>
>> Sorry for not mentioning these before. I can do them myself when pushing
>> if there are no other changes to be made.
>
> Sounds good.  Thanks.

Any remaining blocking issues on this?

--
John Foerch

Re: [PATCH] gnu: Add di.

[John J Foerch]

Leo Famulari <l...@famulari.name> writes:

> On Mon, Jul 04, 2016 at 09:43:55AM +0300, Alex Kost wrote:
>> John J Foerch (2016-07-04 06:47 +0300) wrote:
>> > A test relating to an included perl module Filesys::di fails.  I hadn't
>> > intended to include that module in the package, as all I'm interested in
>> > is the 'di' binary.  Given that, I would suggest that we bypass the
>> > tests.
>> 
>> As for me, I would also disable the tests.  All these handmade Makefiles
>> in all sub-directories are a nightmare.  I think trying to figure out
>> what is needed to run the tests doesn't worth it.
>
> I agree that hand-carved Makefiles are difficult to work with.
>
> The failing Perl-related test runs successfully if Perl is added to the
> environment. However, there is another failure later on:
>

I would favor leaving perl out of the package for the di binary
entirely, and if people want the perl module, use another package for
that.

-- 
John Foerch

Re: [PATCH] gnu: Add di.

[John J Foerch]

Leo Famulari <l...@famulari.name> writes:

> On Mon, Jul 04, 2016 at 11:18:50AM -0400, John J Foerch wrote:
>> * gnu/packages/admin.scm (di): New variable.
>
> A few final nitpicks before others make a decision about the test suite
> ;)
>
>> +(arguments
>> + `(#:phases
>> +   (modify-phases %standard-phases
>> + (delete 'configure)
>> + (delete 'check)
>
> We prefer to use #:tests? #f instead of deleting the check phase.
>
>> + (add-before 'build 'setup-environment
>> +   (lambda* (#:key outputs #:allow-other-keys)
>> + (setenv "CC" "gcc")
>> + (setenv "prefix" (assoc-ref outputs "out"))
>> + #t)))
>> +   #:make-flags (list "-e")))
>
> I would like for '-e' to be expanded to '--environment-overrides'. It
> seems that Schemers abhor abbreviations.
>
> Sorry for not mentioning these before. I can do them myself when pushing
> if there are no other changes to be made.

Sounds good.  Thanks.

--
John Foerch

Re: [PATCH] gnu: Add di.

[John J Foerch]

Alex Kost <alez...@gmail.com> writes:

> John J Foerch (2016-07-04 06:47 +0300) wrote:
>
>> John J Foerch <jjfoe...@earthlink.net> writes:
>>
>>> Leo Famulari <l...@famulari.name> writes:
>>>
>>>> On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote:
>>>>> * gnu/packages/admin.scm (di): New variable.
>>>>
>>>> Thanks!
>>>>
>>>>> +(arguments
>>>>> + `(#:phases
>>>>> +   (modify-phases %standard-phases
>>>>> + (delete 'configure)
>>>>> + (delete 'check)
>>>>
>>>> Did you try setting `#:test-target "test"` in the arguments? The
>>>> Makefile has a test target.
>>>>
>>>
>>> I didn't know about that.  I'll try it out.
>>>
>> A test relating to an included perl module Filesys::di fails.  I hadn't
>> intended to include that module in the package, as all I'm interested in
>> is the 'di' binary.  Given that, I would suggest that we bypass the
>> tests.
>
> As for me, I would also disable the tests.  All these handmade Makefiles
> in all sub-directories are a nightmare.  I think trying to figure out
> what is needed to run the tests doesn't worth it.
>
> Also don't forget to add a copyright line for yourself in the beginning
> of "admin.scm".

Here is an updated patch:

>From 05098e58a85149c96597bbacec5f0f9ef200d299 Mon Sep 17 00:00:00 2001
From: "John J. Foerch" <jjfoe...@earthlink.net>
Date: Sat, 2 Jul 2016 15:08:30 -0400
Subject: [PATCH] gnu: Add di.

* gnu/packages/admin.scm (di): New variable.
---
 gnu/packages/admin.scm | 32 
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 415a35a..0fd2c87 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2016 Ricardo Wurmus <rek...@elephly.net>
 ;;; Copyright © 2016 Efraim Flashner <efr...@flashner.co.il>
 ;;; Copyright © 2016 Peter Feigl <peter.fe...@nexoid.at>
+;;; Copyright © 2016 John J. Foerch <jjfoe...@earthlink.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1708,3 +1709,34 @@ throughput (in the same interval).")
  "The Fuck tries to match a rule for a previous, mistyped command, creates
 a new command using the matched rule, and runs it.")
 (license license:x11)))
+
+(define-public di
+  (package
+(name "di")
+(version "4.42")
+(source
+ (origin
+   (method url-fetch)
+   (uri (string-append "https://gentoo.com/di/di-; version ".tar.gz"))
+   (sha256
+(base32 "1i6m9zdnidn8268q1lz9fd8payk7s4pgwh5zlam9rr4dy6h6a67n"
+(build-system gnu-build-system)
+(arguments
+ `(#:phases
+   (modify-phases %standard-phases
+ (delete 'configure)
+ (delete 'check)
+ (add-before 'build 'setup-environment
+   (lambda* (#:key outputs #:allow-other-keys)
+ (setenv "CC" "gcc")
+ (setenv "prefix" (assoc-ref outputs "out"))
+ #t)))
+   #:make-flags (list "-e")))
+(home-page "https://www.gentoo.com/di/;)
+(synopsis "Advanced df like disk information utility")
+(description
+ "'di' is a disk information utility, displaying everything
+(and more) that your @code{df} command does.  It features the ability to
+display your disk usage in whatever format you prefer.  It is designed to be
+highly portable.  Great for heterogenous networks.")
+(license license:zlib)))
-- 
2.9.0

Re: [PATCH] gnu: conkeror: Update to 1.0.3

[John J Foerch]

l...@gnu.org (Ludovic Courtès) writes:

> Alex Kost <alez...@gmail.com> skribis:
>
>> John J Foerch (2016-07-03 18:50 +0300) wrote:
>>
>>> From 71dd8a5b721a952dbe583922caef0a91b1a559cf Mon Sep 17 00:00:00 2001
>>> From: "John J. Foerch" <jjfoe...@earthlink.net>
>>> Date: Sun, 3 Jul 2016 11:46:20 -0400
>>> Subject: [PATCH] gnu: conkeror: Update to 1.0.3.
>>>
>>> * gnu/packages/conkeror.scm (conkeror): Update to 1.0.3.
>>
>> Just to mention: John is one of the main conkeror contributors :-)
>
> Didn’t know that, nice!
>
> Ludo’, a happy Conkeror user.  :-)

Nice :-)  I first heard about GuixSD in part because someone mentioned
Conkeror was used in a FOSDEM talk.  I thought that was pretty cool.

--
John Foerch

Re: [PATCH] gnu: Add di.

[John J Foerch]

John J Foerch <jjfoe...@earthlink.net> writes:

> Leo Famulari <l...@famulari.name> writes:
>
>> On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote:
>>> * gnu/packages/admin.scm (di): New variable.
>>
>> Thanks!
>>
>>> +(arguments
>>> + `(#:phases
>>> +   (modify-phases %standard-phases
>>> + (delete 'configure)
>>> + (delete 'check)
>>
>> Did you try setting `#:test-target "test"` in the arguments? The
>> Makefile has a test target.
>>
>
> I didn't know about that.  I'll try it out.
>

A test relating to an included perl module Filesys::di fails.  I hadn't
intended to include that module in the package, as all I'm interested in
is the 'di' binary.  Given that, I would suggest that we bypass the
tests.

--
John Foerch

Re: [PATCH] gnu: conkeror: Update to 1.0.3

[John J Foerch]

Efraim Flashner <efr...@flashner.co.il> writes:

> On Sun, Jul 03, 2016 at 11:50:37AM -0400, John J Foerch wrote:
>> From 71dd8a5b721a952dbe583922caef0a91b1a559cf Mon Sep 17 00:00:00 2001
>> From: "John J. Foerch" <jjfoe...@earthlink.net>
>> Date: Sun, 3 Jul 2016 11:46:20 -0400
>> Subject: [PATCH] gnu: conkeror: Update to 1.0.3.
>> 
>> * gnu/packages/conkeror.scm (conkeror): Update to 1.0.3.
>> ---
>>  gnu/packages/conkeror.scm | 9 -
>>  1 file changed, 4 insertions(+), 5 deletions(-)
>> 
>> diff --git a/gnu/packages/conkeror.scm b/gnu/packages/conkeror.scm
>> index cfeb22e..0c247e8 100644
>> --- a/gnu/packages/conkeror.scm
>> +++ b/gnu/packages/conkeror.scm
>> @@ -28,16 +28,15 @@
>>  (define-public conkeror
>>(package
>>  (name "conkeror")
>> -(version "1.0pre1.20150730")
>> +(version "1.0.3")
>>  (source (origin
>>(method url-fetch)
>>(uri
>> -   (string-append "http://repo.or.cz/w/conkeror.git/snapshot/;
>> -  "a1f7e879b129df5cf14ea4ce80a9c1407380ed58"
>> -  ".tar.gz")) ; tag: 
>> debian-1.0--pre-1+git150730-1
>> +   (string-append "http://repo.or.cz/conkeror.git/snapshot/;
>> +  version ".tar.gz"))
>>(sha256
>> (base32
>> -"1q45hc30733gz3ca2ixvw0rzzcbi7rlay7gx7kvzjv17a030nyk0"
>> +"0ybmincxw3msnrfpby9gnckbq2x94c7fra2m66zham54cjc7mav3"
>>  (build-system gnu-build-system)
>>  (inputs `(("icecat" ,icecat)))
>>  (arguments
>> -- 
>> 2.9.0
>> 
>
> Looks good! I added a copyright line for you at the top and a (file-name
> for the source.

Thank you

--
John Foerch

Re: [PATCH] gnu: Add di.

[John J Foerch]

Leo Famulari <l...@famulari.name> writes:

> On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote:
>> * gnu/packages/admin.scm (di): New variable.
>
> Thanks!
>
>> +(arguments
>> + `(#:phases
>> +   (modify-phases %standard-phases
>> + (delete 'configure)
>> + (delete 'check)
>
> Did you try setting `#:test-target "test"` in the arguments? The
> Makefile has a test target.
>

I didn't know about that.  I'll try it out.

>> + (add-before 'build 'setup-environment
>> +   (lambda* (#:key outputs #:allow-other-keys)
>> + (setenv "CC" "gcc")
>> + (setenv "prefix" (assoc-ref outputs "out"))
>> + #t)))
>
> Can you move these variables into #:make-flags?
>
>> +   #:make-flags (list "-e")))

I don't think so.  The main Makefile calls make in the 'C' directory,
which has its own Makefile, so for the variables to be visible in that
second make process, they need to be environment variables.

>
>> +(description
>> + "'di' is a disk information utility, displaying everything
>> +(and more) that your 'df' command does.  It features the ability to display
>
> How about wrapping 'df' in texinfo like this? @code{df}

Okay, will do.

Thank you,

--
John Foerch

[PATCH] gnu: conkeror: Update to 1.0.3

[John J Foerch]

>From 71dd8a5b721a952dbe583922caef0a91b1a559cf Mon Sep 17 00:00:00 2001
From: "John J. Foerch" <jjfoe...@earthlink.net>
Date: Sun, 3 Jul 2016 11:46:20 -0400
Subject: [PATCH] gnu: conkeror: Update to 1.0.3.

* gnu/packages/conkeror.scm (conkeror): Update to 1.0.3.
---
 gnu/packages/conkeror.scm | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/conkeror.scm b/gnu/packages/conkeror.scm
index cfeb22e..0c247e8 100644
--- a/gnu/packages/conkeror.scm
+++ b/gnu/packages/conkeror.scm
@@ -28,16 +28,15 @@
 (define-public conkeror
   (package
 (name "conkeror")
-(version "1.0pre1.20150730")
+(version "1.0.3")
 (source (origin
   (method url-fetch)
   (uri
-   (string-append "http://repo.or.cz/w/conkeror.git/snapshot/;
-  "a1f7e879b129df5cf14ea4ce80a9c1407380ed58"
-  ".tar.gz")) ; tag: debian-1.0--pre-1+git150730-1
+   (string-append "http://repo.or.cz/conkeror.git/snapshot/;
+  version ".tar.gz"))
   (sha256
(base32
-"1q45hc30733gz3ca2ixvw0rzzcbi7rlay7gx7kvzjv17a030nyk0"
+"0ybmincxw3msnrfpby9gnckbq2x94c7fra2m66zham54cjc7mav3"
 (build-system gnu-build-system)
 (inputs `(("icecat" ,icecat)))
 (arguments
-- 
2.9.0

[PATCH] gnu: Add di.

[John J Foerch]

Hello,

Here is a package for the program 'di' (df alternative).  Let me know if
anything is amiss, cheers!

John Foerch

>From 4ef5a6edba2e10a59865a6aba134d2f0532c7503 Mon Sep 17 00:00:00 2001
From: "John J. Foerch" <jjfoe...@earthlink.net>
Date: Sat, 2 Jul 2016 15:08:30 -0400
Subject: [PATCH] gnu: Add di.

* gnu/packages/admin.scm (di): New variable.
---
 gnu/packages/admin.scm | 31 +++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 415a35a..f128f68 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -1708,3 +1708,34 @@ throughput (in the same interval).")
  "The Fuck tries to match a rule for a previous, mistyped command, creates
 a new command using the matched rule, and runs it.")
 (license license:x11)))
+
+(define-public di
+  (package
+(name "di")
+(version "4.42")
+(source
+ (origin
+   (method url-fetch)
+   (uri (string-append "https://gentoo.com/di/di-; version ".tar.gz"))
+   (sha256
+(base32 "1i6m9zdnidn8268q1lz9fd8payk7s4pgwh5zlam9rr4dy6h6a67n"
+(build-system gnu-build-system)
+(arguments
+ `(#:phases
+   (modify-phases %standard-phases
+ (delete 'configure)
+ (delete 'check)
+ (add-before 'build 'setup-environment
+   (lambda* (#:key outputs #:allow-other-keys)
+ (setenv "CC" "gcc")
+ (setenv "prefix" (assoc-ref outputs "out"))
+ #t)))
+   #:make-flags (list "-e")))
+(home-page "https://www.gentoo.com/di/;)
+(synopsis "Advanced df like disk information utility")
+(description
+ "'di' is a disk information utility, displaying everything
+(and more) that your 'df' command does.  It features the ability to display
+your disk usage in whatever format you prefer.  It is designed to be highly
+portable.  Great for heterogenous networks.")
+(license license:zlib)))
-- 
2.9.0

Re: [PATCH] midicsv: new package

[John J Foerch]

l...@gnu.org (Ludovic Courtès) writes:

> Hi,
>
> John J Foerch <jjfoe...@earthlink.net> skribis:
>
>> From 15e6c06398fa8d340b70da391f90e6c69e613f70 Mon Sep 17 00:00:00 2001
>> From: "John J. Foerch" <jjfoe...@earthlink.net>
>> Date: Fri, 1 Jul 2016 21:26:55 -0400
>> Subject: [PATCH] gnu: midicsv: new package
>>
>> ---
>>  gnu/packages/music.scm | 28 
>>  1 file changed, 28 insertions(+)
>
> I committed it with a GNU-style commit log, and added a copyright line
> for yourself (let me know if I got it wrong).
>
>> +(synopsis "convert MIDI files to and from CSV")
>   ^
> I also capitalized this.
>
> These are all cosmetic details; you can read about these and other
> conventions at
> <https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>.
>
> Thank you for this patch and welcome!  :-)
>
> Ludo’.

Thanks a lot!

--
John Foerch

[PATCH] midicsv: new package

[John J Foerch]

Hello,

Here is my first attempt at a package, midicsv.  Please let me know what
changes may need to be made.

>From 15e6c06398fa8d340b70da391f90e6c69e613f70 Mon Sep 17 00:00:00 2001
From: "John J. Foerch" <jjfoe...@earthlink.net>
Date: Fri, 1 Jul 2016 21:26:55 -0400
Subject: [PATCH] gnu: midicsv: new package

---
 gnu/packages/music.scm | 28 
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index dfc21cc..0013819 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1594,3 +1594,31 @@ for improved Amiga ProTracker 2/3 compatibility.")
 formats, including most audio formats recognized by FFMpeg.")
 (home-page "http://moc.daper.net;)
 (license license:gpl2+)))
+
+(define-public midicsv
+  (package
+(name "midicsv")
+(version "1.1")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "http://www.fourmilab.ch/webtools/midicsv/;
+  name "-" version ".tar.gz"))
+  (sha256
+   (base32
+"1vvhk2nf9ilfw0wchmxy8l13hbw9cnpz079nsx5srsy4nnd78nkw"
+(build-system gnu-build-system)
+(arguments
+ `(#:phases (modify-phases %standard-phases (delete 'configure))
+   #:make-flags (list "CC=gcc" (string-append "INSTALL_DEST=" %output
+(synopsis "convert MIDI files to and from CSV")
+(description
+ "midicsv reads a standard MIDI file and decodes it into a CSV
+(Comma-Separated Value) file which preserves all the information in
+the MIDI file.  The ASCII CSV file may be loaded into a spreadsheet
+or database application, or processed by a program to transform the
+MIDI data (for example, to key transpose a composition or extract a
+track from a multi-track sequence).  A CSV file in the format
+created by midicsv may be converted back into a standard MIDI file
+with the csvmidi program.")
+(home-page "http://www.fourmilab.ch/webtools/midicsv/;)
+(license license:public-domain)))
-- 
2.9.0