Re: [PATCH] gnu: Add lmms
Qt 4 is no longer supported by the Qt project, but security vulnerabilities continue to be discovered in it, and so we should not add new packages that depend on it. Apparently, LMMS can be built with Qt 5: https://github.com/LMMS/lmms/wiki/Compiling-lmms#using-qt5 Can you try it and let us know how it goes? Ok, I looked into this. Qt5 is supported only in the newest development version of lmms, but what I packaged is the latest stable release. I will make a note of this for when I update the package, but what can we do for the mean time? Accept this as is? Package the release candidiate? Or just wait for the next stable release of lmms before adding this to guix? To be honest, the RC looks like it has some cool new features, so I will probably be building it for myself either way. Also, lmms is on a pretty slow release cycle. The last stable was 2015, RC-1 was early 2016, and RC-2 was Jan 2017. So maybe if it seems stable enough when I build it I can package the RC-2. I could do one for each if that makes sense, kind of like the guile and guile-next packages. What do you think? lmms and lmms-rc? -Rodger
Re: [PATCH] gnu: Add lmms
Sorry for the delay. I got the rpath issue fixed on this.
It should be ready to apply now.
-Rodger FoxFrom 70f155cd4bde3060b87c0834f12f71886c1e0f3f Mon Sep 17 00:00:00 2001
From: Rodger Fox <thylak...@openmailbox.org>
Date: Wed, 8 Mar 2017 20:28:10 -0800
Subject: [PATCH] gnu: Add lmms.
* gnu/packages/music.scm (lmms): New variable.
---
gnu/packages/music.scm | 53 ++
1 file changed, 53 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 87b6d5b9b..07f30cfdd 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -9,6 +9,7 @@
;;; Copyright © 2016 John J. Foerch <jjfoe...@earthlink.net>
;;; Copyright © 2016 Alex Griffin <a...@ajgrf.com>
;;; Copyright © 2017 ng0 <contact@cryptolab.net>
+;;; Copyright © 2017 Rodger Fox <thylak...@openmailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2820,3 +2821,55 @@ collections and wantlists, inventory, and orders.")
conversions between time and pulses, tempo map handling and more. The only dependencies
are a C compiler and glib. Full API documentation and examples are included.")
(license license:bsd-2)))
+
+(define-public lmms
+ (package
+(name "lmms")
+(version "1.1.3")
+(source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/LMMS/lmms/archive/v;
+ version ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+(base32
+ "1g76z7ha3hd53vbqaq9n1qg6s3lw8zzaw51iny6y2bz0j1xqwcsr"
+(build-system cmake-build-system)
+(arguments
+ `(#:tests? #f ; no tests
+ #:phases
+ (modify-phases %standard-phases
+ (add-before
+ 'configure 'set-ldflags
+ (lambda* (#:key outputs #:allow-other-keys)
+(setenv "LDFLAGS"
+(string-append
+ "-Wl,-rpath=\""
+ (assoc-ref outputs "out") "/lib/lmms"
+ ":"
+ (assoc-ref outputs "out") "/lib/lmms/ladspa"
+ "\"")))
+(native-inputs
+ `(("pkg-config" ,pkg-config)))
+(inputs
+ `(("sdl" ,sdl)
+ ("qt" ,qt-4)
+ ("fltk" ,fltk)
+ ("libogg" ,libogg)
+ ("libsamplerate" ,libsamplerate)
+ ("fluidsynth" ,fluidsynth)
+ ("libvorbis" ,libvorbis)
+ ("alsa-lib" ,alsa-lib)
+ ("portaudio" ,portaudio)
+ ("ladspa" ,ladspa)
+ ("libsndfile1" ,libsndfile)
+ ("libxft" ,libxft)
+ ("freetype2" ,freetype)
+ ("fftw3f" ,fftwf)))
+(home-page "https://lmms.io/;)
+(synopsis "Music composition tool")
+(description "LMMS is a digital audio workstation. It includes tools for sequencing
+melodies and beats and for mixing and arranging songs. LMMS includes instruments based on
+audio samples and various soft sythesizers. It can receive input from a MIDI keyboard.")
+(license license:gpl2+)))
--
2.12.0
Re: Memory Usage
Thanks for the feedback on this. I think it was just my mistake. This is what I was looking at: GiB Mem : 16.6/2.929 After using 'free', which gives more reasonable output, I think top is reporting a percentage. I never realized that, and it seems unintuitive, given the units it displays, but this is not a Guix issue, just my own mistake in what I was reading.
Re: [PATCH] gnu: Add lmms
It's a good idea to run "./pre-inst-env guix lint PACKAGENAME" which
will pick up long lines for example.
I have a ruler/colored line at character 83 in vim, but I'm not yet
ready with the setup to write correct code again in vim. There's
a similar thing for emacs.
I would replace the third or second "It" with @code{LMMS} or simply
LMMS.
Thanks for pointing that out. I missed that pre-inst-env tool in
the manual until you just mentioned it here. That helps a lot.
My corrected patch is attached. It passes the linter this time.
-Rodger FoxFrom a40d4032431d5a22809c25d81ecdc8ed370e989c Mon Sep 17 00:00:00 2001
From: Rodger Fox <thylak...@openmailbox.org>
Date: Wed, 22 Feb 2017 15:08:30 -0800
Subject: [PATCH] gnu: Add lmms.
* gnu/packages/music.scm (lmms): New variable.
---
gnu/packages/music.scm | 43 +++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 730d981e6..fe24c94f6 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -9,6 +9,7 @@
;;; Copyright © 2016 John J. Foerch <jjfoe...@earthlink.net>
;;; Copyright © 2016 Alex Griffin <a...@ajgrf.com>
;;; Copyright © 2017 ng0 <contact....@cryptolab.net>
+;;; Copyright © 2017 Rodger Fox <thylak...@openmailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2818,3 +2819,45 @@ collections and wantlists, inventory, and orders.")
conversions between time and pulses, tempo map handling and more. The only dependencies
are a C compiler and glib. Full API documentation and examples are included.")
(license license:bsd-2)))
+
+(define-public lmms
+ (package
+(name "lmms")
+(version "1.1.3")
+(source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/LMMS/lmms/archive/v;
+ version ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+(base32
+ "1g76z7ha3hd53vbqaq9n1qg6s3lw8zzaw51iny6y2bz0j1xqwcsr"
+(build-system cmake-build-system)
+(arguments
+ `(#:tests? #f ; No tests to run.
+ #:validate-runpath? #f)) ; Binaries in subdirectories of /lib are dependent.
+; It fails the runpath validation, but still works.
+(native-inputs
+ `(("pkg-config" ,pkg-config)))
+(inputs
+ `(("sdl" ,sdl)
+ ("qt" ,qt-4)
+ ("fltk" ,fltk)
+ ("libogg" ,libogg)
+ ("libsamplerate" ,libsamplerate)
+ ("fluidsynth" ,fluidsynth)
+ ("libvorbis" ,libvorbis)
+ ("alsa-lib" ,alsa-lib)
+ ("portaudio" ,portaudio)
+ ("ladspa" ,ladspa)
+ ("libsndfile1" ,libsndfile)
+ ("libxft" ,libxft)
+ ("freetype2" ,freetype)
+ ("fftw3f" ,fftwf)))
+(home-page "https://lmms.io/;)
+(synopsis "Music composition tool")
+(description "LMMS is a digital audio workstation. It includes tools for sequencing
+melodies and beats and for mixing and arranging songs. LMMS includes instruments based on
+audio samples and various soft sythesizers. It can receive input from a MIDI keyboard.")
+(license license:gpl2+)))
--
2.11.1
Re: [PATCH] gnu: Add lmms
The message is correct, but it lacks returns between "Add lmms." and "*
gnu/packages". Have a look at git log for some examples.
Yeah, that's weird. It's actually inconsistent with my commit log.
Although, mine has only one line break instead of two, which I noticed
after you mentioned this. Either way I'm wrong, but I'm not sure
why the format-patch dropped it. I will figure that out and fix it.
+ (sha256
+(base32
+"1g76z7ha3hd53vbqaq9n1qg6s3lw8zzaw51iny6y2bz0j1xqwcsr"
There's a tab in the indentation, please use spaces.
+(build-system cmake-build-system)
+(arguments `(#:tests? #f ; No tests to run.
+#:validate-runpath? #f))
There's a tab here too, and it should rather look like this:
(arguments
`(#:tests? #f
#:validate-runpath? #f))
Why do you need to disable runpath validation?
The build was failing on the validate runpath phase, but I noticed
that the package did exist in the store and was working. The failure
was something to do with a library in a subdirectory of /lib being
dependent on another library in its same directory. But it seems
only /lib itself is in the runpath. I guess the libraries can still
find each other, but they are not in the runpath. I actually meant
to ask about this, so I'm glad you caught it. Is there a better fix
for this situation? I guess I should at least put a comment in there
to explain it.
+(native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
Indentation is off by one (inputs should be aligned with
native-inputs).
+(description "LMMS is a digital audio workstation. It includes
tools for sequencing melodies and beats and for mixing and arranging
songs. It includes instruments based on audio samples and various soft
sythesizers. It can receive input from a MIDI keyboard.")
This line is way too long, please break it. Also please use two spaces
between sentences.
I missed the two spaces rule. I'll fix the long line, too.
I was having problems with guix lint, but I will be sure get that
working before I submit something again.
Ok, this is my first review, I tried to get it right but I probably
forgot something (I still can't get my own patches right on the first
try :p). Running "guix lint lmms" would have saved you the last comment
;). I can't try it now, but I'll test your patch (or an updated
version)
this evening.
I will submit an updated version so you can do that tonight.
Thanks for the feedback.
-Rodger Fox
[PATCH] gnu: Add lmms
Here is another package. I think I got the commit message right this
time. Let me know if I missed anything.From 8e2757bee584f4686e02da512662fb512b05c037 Mon Sep 17 00:00:00 2001
From: Rodger Fox <thylak...@openmailbox.org>
Date: Wed, 22 Feb 2017 15:08:30 -0800
Subject: [PATCH] gnu: Add lmms. * gnu/packages/music.scm (lmms): New variable.
---
gnu/packages/music.scm | 38 ++
1 file changed, 38 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 730d981e6..924fb8109 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -9,6 +9,7 @@
;;; Copyright © 2016 John J. Foerch <jjfoe...@earthlink.net>
;;; Copyright © 2016 Alex Griffin <a...@ajgrf.com>
;;; Copyright © 2017 ng0 <contact@cryptolab.net>
+;;; Copyright © 2017 Rodger Fox <thylak...@openmailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2818,3 +2819,40 @@ collections and wantlists, inventory, and orders.")
conversions between time and pulses, tempo map handling and more. The only dependencies
are a C compiler and glib. Full API documentation and examples are included.")
(license license:bsd-2)))
+
+(define-public lmms
+ (package
+(name "lmms")
+(version "1.1.3")
+(source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/LMMS/lmms/archive/v;
+ version ".tar.gz"))
+ (sha256
+(base32
+ "1g76z7ha3hd53vbqaq9n1qg6s3lw8zzaw51iny6y2bz0j1xqwcsr"
+(build-system cmake-build-system)
+(arguments `(#:tests? #f ; No tests to run.
+ #:validate-runpath? #f))
+(native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
+ `(("sdl" ,sdl)
+ ("qt" ,qt-4)
+ ("fltk" ,fltk)
+ ("libogg" ,libogg)
+ ("libsamplerate" ,libsamplerate)
+ ("fluidsynth" ,fluidsynth)
+ ("libvorbis" ,libvorbis)
+ ("alsa-lib" ,alsa-lib)
+ ("portaudio" ,portaudio)
+ ("ladspa" ,ladspa)
+ ("libsndfile1" ,libsndfile)
+ ("libxft" ,libxft)
+ ("freetype2" ,freetype)
+ ("fftw3f" ,fftwf)))
+(home-page "https://lmms.io/;)
+(synopsis "Music composition tool")
+(description "LMMS is a digital audio workstation. It includes tools for sequencing melodies and beats and for mixing and arranging songs. It includes instruments based on audio samples and various soft sythesizers. It can receive input from a MIDI keyboard.")
+(license license:gpl2+)))
--
2.11.1
Re: Memory Usage
On 2017-02-22 11:51 am, ng0 wrote: On 17-02-22 11:37:11, Rodger Fox wrote: What is the typical memory usage of a GuixSD system? There's no such thing as a typical system. It depends on what you run, 300 open browser tabs will lead to more RAM used for example. I understand. I didn't mean to leave that as the whole of my question. I elaborated more on my situation. I have stopped Xorg, networking, and the guix daemon. I was still at over 5GiB. I'm watching a video, write in an IRC client, and run some other background applications and I'm at 3.5 GiB RAM. So that seems to confirm my suspicion that something is wrong with my system. I am way over that mark with basically nothing running. As well, I checked another system I have that runs Arch Linux and I found that with full gnome-desktop and several extra services running, it is around 4GiB. I was wondering if it was just something strange about the Guix binaries. Anyway, I'm just looking for ideas. I know it's a pretty vague problem. It just makes me wonder if my system is compromised somehow. I think I will try a fresh install to see if it changes anything. I can't seem to get mine below 5GiB, according to top. This is when I stop Xorg and most system services, including networking and such, and just log in to a plain terminal with nothing but top running. Is this normal? The numbers listed per process in top don't even add up to that, but it reports the total being high. Also, icecat uses a 1000m and gnome-terminal uses 500m. This seems wrong to me, but I'm not sure. In my session right now it is reporting over 14GiB of memory use. I don't know why it should be so high. -Rodger
Memory Usage
What is the typical memory usage of a GuixSD system? I can't seem to get mine below 5GiB, according to top. This is when I stop Xorg and most system services, including networking and such, and just log in to a plain terminal with nothing but top running. Is this normal? The numbers listed per process in top don't even add up to that, but it reports the total being high. Also, icecat uses a 1000m and gnome-terminal uses 500m. This seems wrong to me, but I'm not sure. In my session right now it is reporting over 14GiB of memory use. I don't know why it should be so high. -Rodger
Re: Leaving the guix project
I suggest we drop this thread. It belongs elsewhere. Pj. +1
[PATCH] update pioneers to latest version.
This is a simple version update. I attached the patch file.
From a5c2bd3bd51ef98549ca6cf51c26f395704fac91 Mon Sep 17 00:00:00 2001
From: Rodger Fox <thylak...@openmailbox.org>
Date: Fri, 17 Feb 2017 20:01:37 -0800
Subject: [PATCH] updated pioneers to latest version.
---
gnu/packages/games.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index bfbb6bae5..1d6a12a0f 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -15,7 +15,7 @@
;;; Copyright © 2015, 2016, 2017 Alex Kost <alez...@gmail.com>
;;; Copyright © 2015 Paul van der Walt <p...@denknerd.org>
;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayi...@gmail.com>
-;;; Copyright © 2016 Rodger Fox <thylak...@openmailbox.org>
+;;; Copyright © 2016, 2017 Rodger Fox <thylak...@openmailbox.org>
;;; Copyright © 2016 Manolis Fragkiskos Ragkousis <manolis...@gmail.com>
;;; Copyright © 2016, 2017 ng0 <contact@cryptolab.net>
;;; Copyright © 2016 Albin Söderqvist <al...@fripost.org>
@@ -2082,14 +2082,14 @@ are only two levels to play with, but they are very addictive.")
(define-public pioneers
(package
(name "pioneers")
-(version "15.3")
+(version "15.4")
(source (origin
(method url-fetch)
(uri (string-append "http://downloads.sourceforge.net/pio/;
"pioneers-" version ".tar.gz"))
(sha256
(base32
-"128s718nnraiznbg2rajjqb7cfkdg24hy6spdd9narb4f4dsbbv9"
+"1p1d18hrfmqcnghip3shkzcs5qkz6j99jvkdkqfi7pqdvjc323cs"
(build-system gnu-build-system)
(inputs `(("gtk+" ,gtk+)
("librsvg" ,librsvg)
--
2.11.1
