Re: [PATCH] gnu: Add Xfce Notification Daemon.

[Petter]

On Wed, 26 Apr 2017 16:39:19 +0200
Marius Bakke  wrote:
> 
> Takk! Pushed as b63106089a1eb2ac76303886f926f74967879386.
> 
> By the way, patches should now be sent to the new "guix-patc...@gnu.org"
> issue tracker. :-)

Supert! :)

Yes, I realized this a couple of days ago. I'll write an e-mail discussing
the state of this in the online manual.

Best,
Petter


pgpekWAYB0lrT.pgp
Description: OpenPGP digital signature

Re: [PATCH] gnu: Add Xfce Notification Daemon.

[Marius Bakke]

Petter  writes:

> Hi Efraim,
>
> On Mon, 24 Apr 2017 22:22:43 +0300
> Efraim Flashner  wrote:
>
>> The collection of inputs makes me wonder if it should be glib-or-gtk
>> build-system and not "just" gnu-build-system. I don't have a good way to
>> test if its necessary, but I'd look around.
>
> Here's an updated patch using glib-or-gtk-build-system. I've removed
> superfluous inputs, some where even superfluous with the gnu-build-system as
> well, (I initially based the inputs on the build instructions provided with
> the package). It's quite tidy now :)

Takk! Pushed as b63106089a1eb2ac76303886f926f74967879386.

By the way, patches should now be sent to the new "guix-patc...@gnu.org"
issue tracker. :-)


signature.asc
Description: PGP signature

Re: [PATCH] gnu: Add Xfce Notification Daemon.

[Petter]

I forgot to wrap "org.freedesktop.Notifications" in the description in 
@code{..}, as suggested by Marius. Here it is with this as well.


From 922cbeb402ece8dbd0d592489069d7ccda64d702 Mon Sep 17 00:00:00 2001
From: Petter <pet...@mykolab.ch>
Date: Fri, 21 Apr 2017 15:33:22 +0200
Subject: [PATCH] gnu: Add Xfce Notification Daemon.

* gnu/packages/xfce.scm (xfce4-notifyd): New variable.
---
 gnu/packages/xfce.scm | 32 
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index fce47d93c..c8786dd69 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2016 Florian Paul Schmidt <mista.ta...@gmx.net>
 ;;; Copyright © 2016 Kei Kebreau <k...@openmailbox.org>
 ;;; Copyright © 2017 Ricardo Wurmus <rek...@elephly.net>
+;;; Copyright © 2017 Petter <pet...@mykolab.ch>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -26,6 +27,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix utils)
+  #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
@@ -850,3 +852,33 @@ calendar applications.  It also includes a panel clock 
plugin and an
 international clock application capable of simultaneously showing clocks from
 several different time zones.")
 (license gpl2+)))
+
+(define-public xfce4-notifyd
+  (package
+(name "xfce4-notifyd")
+(version "0.3.6")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "http://archive.xfce.org/src/apps/;
+  name "/" (version-major+minor version) "/"
+  name "-" version ".tar.bz2"))
+  (sha256
+   (base32
+"1ybcfqfynr33g5hp2lgq17s8qyx7rq6fd2iwrpwcvm6kml6prjpl"
+(build-system glib-or-gtk-build-system)
+(native-inputs
+ `(("intltool" ,intltool)
+   ("pkg-config" ,pkg-config)))
+(inputs
+ `(("libxfce4ui" ,libxfce4ui)
+   ("libnotify" ,libnotify)))
+(home-page "https://goodies.xfce.org/projects/applications/xfce4-notifyd;)
+(synopsis "Show notification bubbles on Xfce")
+(description
+ "The Xfce Notify Daemon (xfce4-notifyd for short) is a smallish program
+that implements the “server-side” portion of the Freedesktop desktop
+notifications specification.  Applications that wish to pop up a notification
+bubble in a standard way can implicitly make use of xfce4-notifyd to do so by
+sending standard messages over D-Bus using the
+@code{org.freedesktop.Notifications} interface.")
+(license gpl2)))
-- 
2.12.2



pgpGAwn96HKFK.pgp
Description: OpenPGP digital signature

Re: [PATCH] gnu: Add Xfce Notification Daemon.

[Petter]

Hi Efraim,

On Mon, 24 Apr 2017 22:22:43 +0300
Efraim Flashner <efr...@flashner.co.il> wrote:

> The collection of inputs makes me wonder if it should be glib-or-gtk
> build-system and not "just" gnu-build-system. I don't have a good way to
> test if its necessary, but I'd look around.

Here's an updated patch using glib-or-gtk-build-system. I've removed
superfluous inputs, some where even superfluous with the gnu-build-system as
well, (I initially based the inputs on the build instructions provided with
the package). It's quite tidy now :)

Best,
Petter

From 75dfd4702327021481339ce9928ce5be17db45be Mon Sep 17 00:00:00 2001
From: Petter <pet...@mykolab.ch>
Date: Fri, 21 Apr 2017 15:33:22 +0200
Subject: [PATCH] gnu: Add Xfce Notification Daemon.

* gnu/packages/xfce.scm (xfce4-notifyd): New variable.
---
 gnu/packages/xfce.scm | 32 
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index fce47d93c..6ec9f241b 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2016 Florian Paul Schmidt <mista.ta...@gmx.net>
 ;;; Copyright © 2016 Kei Kebreau <k...@openmailbox.org>
 ;;; Copyright © 2017 Ricardo Wurmus <rek...@elephly.net>
+;;; Copyright © 2017 Petter <pet...@mykolab.ch>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -26,6 +27,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix utils)
+  #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
@@ -850,3 +852,33 @@ calendar applications.  It also includes a panel clock 
plugin and an
 international clock application capable of simultaneously showing clocks from
 several different time zones.")
 (license gpl2+)))
+
+(define-public xfce4-notifyd
+  (package
+(name "xfce4-notifyd")
+(version "0.3.6")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "http://archive.xfce.org/src/apps/;
+  name "/" (version-major+minor version) "/"
+  name "-" version ".tar.bz2"))
+  (sha256
+   (base32
+"1ybcfqfynr33g5hp2lgq17s8qyx7rq6fd2iwrpwcvm6kml6prjpl"
+(build-system glib-or-gtk-build-system)
+(native-inputs
+ `(("intltool" ,intltool)
+   ("pkg-config" ,pkg-config)))
+(inputs
+ `(("libxfce4ui" ,libxfce4ui)
+   ("libnotify" ,libnotify)))
+(home-page "https://goodies.xfce.org/projects/applications/xfce4-notifyd;)
+(synopsis "Show notification bubbles on Xfce")
+(description
+ "The Xfce Notify Daemon (xfce4-notifyd for short) is a smallish program
+that implements the “server-side” portion of the Freedesktop desktop
+notifications specification.  Applications that wish to pop up a notification
+bubble in a standard way can implicitly make use of xfce4-notifyd to do so by
+sending standard messages over D-Bus using the org.freedesktop.Notifications
+interface.")
+(license gpl2)))
-- 
2.12.2



pgpIg7INXESP1.pgp
Description: OpenPGP digital signature

Re: [PATCH] gnu: Add Xfce Notification Daemon.

[Efraim Flashner]

On Mon, Apr 24, 2017 at 08:54:41PM +0200, Petter wrote:
> Hei Marius,
> 
> > > +(native-inputs
> > > + `(("intltool" ,intltool)
> > > +   ("pkg-config" ,pkg-config)))
> > > +(propagated-inputs
> > > + `(("glib:bin" ,glib "bin")))  
> > 
> > Do you know why glib:bin needs to be propagated here? Looking at
> > gnome.scm, it's usually a "native-input". If this program requires
> > some of the executables from that package at runtime, it's better to
> > patch it with the absolute paths.
> 
> I don't know. I just saw it done like this in another package in
> xfce.scm.
> 
> Reading up on inputs I see propagated-inputs "will be installed
> alongside the package they belong to". Yeah, let's see if we can avoid
> that.
> 
> I've adjusted the recipe to test with glib:bin as a native-input,
> it builds fine, and a quick remove and install shows no issues either.
> However, the notification system still worked with it removed, so I'm
> not certain the new one is the one used. I will test this further next
> time I boot my system.
> 
> > Other than that looks great! I'd add an @code{...} wrapper around
> > "org.freedesktop.Notifications" in the description, but that can be
> > fixed up before committing, no need for a new patch.
> 
> I'll make sure to add this if I produce a new patch.
> 
> Thanks for the feedback!
> 
> Best,
> Petter

The collection of inputs makes me wonder if it should be glib-or-gtk
build-system and not "just" gnu-build-system. I don't have a good way to
test if its necessary, but I'd look around.


-- 
Efraim Flashner      אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted


signature.asc
Description: PGP signature

Re: [PATCH] gnu: Add Xfce Notification Daemon.

[Petter]

Hei Marius,

> > +(native-inputs
> > + `(("intltool" ,intltool)
> > +   ("pkg-config" ,pkg-config)))
> > +(propagated-inputs
> > + `(("glib:bin" ,glib "bin")))  
> 
> Do you know why glib:bin needs to be propagated here? Looking at
> gnome.scm, it's usually a "native-input". If this program requires
> some of the executables from that package at runtime, it's better to
> patch it with the absolute paths.

I don't know. I just saw it done like this in another package in
xfce.scm.

Reading up on inputs I see propagated-inputs "will be installed
alongside the package they belong to". Yeah, let's see if we can avoid
that.

I've adjusted the recipe to test with glib:bin as a native-input,
it builds fine, and a quick remove and install shows no issues either.
However, the notification system still worked with it removed, so I'm
not certain the new one is the one used. I will test this further next
time I boot my system.

> Other than that looks great! I'd add an @code{...} wrapper around
> "org.freedesktop.Notifications" in the description, but that can be
> fixed up before committing, no need for a new patch.

I'll make sure to add this if I produce a new patch.

Thanks for the feedback!

Best,
Petter


pgpRiM1Od8iDq.pgp
Description: OpenPGP digital signature

Re: [PATCH] gnu: Add Xfce Notification Daemon.

[Marius Bakke]

Hi Petter, thanks a lot for this!

The patch looks good, I only have one question (not very familiar with
gtk packaging either, so please excuse my ignorance).


> * gnu/packages/xfce.scm (xfce4-notifyd): New variable.

[...]

> +(native-inputs
> + `(("intltool" ,intltool)
> +   ("pkg-config" ,pkg-config)))
> +(propagated-inputs
> + `(("glib:bin" ,glib "bin")))

Do you know why glib:bin needs to be propagated here? Looking at
gnome.scm, it's usually a "native-input". If this program requires some
of the executables from that package at runtime, it's better to patch it
with the absolute paths.

Other than that looks great! I'd add an @code{...} wrapper around
"org.freedesktop.Notifications" in the description, but that can be
fixed up before committing, no need for a new patch.

> +(inputs
> + `(("gtk+" ,gtk+)
> +   ("libxfce4util" ,libxfce4util)
> +   ("libxfce4ui" ,libxfce4ui)
> +   ("xfconf" ,xfconf)
> +   ("libnotify" ,libnotify)))
> +(home-page 
> "https://goodies.xfce.org/projects/applications/xfce4-notifyd;)
> +(synopsis "Show notification bubbles on Xfce")
> +(description
> + "The Xfce Notify Daemon (xfce4-notifyd for short) is a smallish program
> +that implements the “server-side” portion of the Freedesktop desktop
> +notifications specification.  Applications that wish to pop up a notification
> +bubble in a standard way can implicitly make use of xfce4-notifyd to do so by
> +sending standard messages over D-Bus using the org.freedesktop.Notifications
> +interface.")
> +(license gpl2)))

It is indeed version 2 only..


signature.asc
Description: PGP signature

Re: [PATCH] gnu: Add Xfce Notification Daemon.

[Petter]

Hi again,

Forgot previously to run `guix lint` on this; added a space between
sentences now.

Also rewrote the synopsis.

Best,
Petter


From 2a31bcfa1b39c9403fb2dab3ab073def3ab8e140 Mon Sep 17 00:00:00 2001
From: Petter <pet...@mykolab.ch>
Date: Fri, 21 Apr 2017 15:33:22 +0200
Subject: [PATCH] gnu: Add Xfce Notification Daemon.

* gnu/packages/xfce.scm (xfce4-notifyd): New variable.
---
 gnu/packages/xfce.scm | 39 +++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index fce47d93c..00d958cc8 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2016 Florian Paul Schmidt <mista.ta...@gmx.net>
 ;;; Copyright © 2016 Kei Kebreau <k...@openmailbox.org>
 ;;; Copyright © 2017 Ricardo Wurmus <rek...@elephly.net>
+;;; Copyright © 2017 Petter <pet...@mykolab.ch>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -850,3 +851,41 @@ calendar applications.  It also includes a panel clock 
plugin and an
 international clock application capable of simultaneously showing clocks from
 several different time zones.")
 (license gpl2+)))
+
+(define-public xfce4-notifyd
+  (package
+(name "xfce4-notifyd")
+(version "0.3.6")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "http://archive.xfce.org/src/apps/;
+  name "/" (version-major+minor version) "/"
+  name "-" version ".tar.bz2"))
+  (sha256
+   (base32
+"1ybcfqfynr33g5hp2lgq17s8qyx7rq6fd2iwrpwcvm6kml6prjpl"
+(build-system gnu-build-system)
+(arguments
+ `(#:configure-flags
+   (list (string-append "--prefix=" %output
+(native-inputs
+ `(("intltool" ,intltool)
+   ("pkg-config" ,pkg-config)))
+(propagated-inputs
+ `(("glib:bin" ,glib "bin")))
+(inputs
+ `(("gtk+" ,gtk+)
+   ("libxfce4util" ,libxfce4util)
+   ("libxfce4ui" ,libxfce4ui)
+   ("xfconf" ,xfconf)
+   ("libnotify" ,libnotify)))
+(home-page "https://goodies.xfce.org/projects/applications/xfce4-notifyd;)
+(synopsis "Show notification bubbles on Xfce")
+(description
+ "The Xfce Notify Daemon (xfce4-notifyd for short) is a smallish program
+that implements the “server-side” portion of the Freedesktop desktop
+notifications specification.  Applications that wish to pop up a notification
+bubble in a standard way can implicitly make use of xfce4-notifyd to do so by
+sending standard messages over D-Bus using the org.freedesktop.Notifications
+interface.")
+(license gpl2)))
-- 
2.12.2



On Fri, 21 Apr 2017 15:37:45 +0200
Petter <pet...@mykolab.ch> wrote:

> Hi Guix,
> 
> Be extra critical while reviewing this patch, I'm not good at this.
> 
> (Today I learned that a provided DBus service file first takes effect
> after installing. I wasn't having any luck testing directly from
> store. Thanks again wingo!)
> 
> Best,
> Petter

From 2a31bcfa1b39c9403fb2dab3ab073def3ab8e140 Mon Sep 17 00:00:00 2001
From: Petter <pet...@mykolab.ch>
Date: Fri, 21 Apr 2017 15:33:22 +0200
Subject: [PATCH] gnu: Add Xfce Notification Daemon.

* gnu/packages/xfce.scm (xfce4-notifyd): New variable.
---
 gnu/packages/xfce.scm | 39 +++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index fce47d93c..00d958cc8 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2016 Florian Paul Schmidt <mista.ta...@gmx.net>
 ;;; Copyright © 2016 Kei Kebreau <k...@openmailbox.org>
 ;;; Copyright © 2017 Ricardo Wurmus <rek...@elephly.net>
+;;; Copyright © 2017 Petter <pet...@mykolab.ch>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -850,3 +851,41 @@ calendar applications.  It also includes a panel clock plugin and an
 international clock application capable of simultaneously showing clocks from
 several different time zones.")
 (license gpl2+)))
+
+(define-public xfce4-notifyd
+  (package
+(name "xfce4-notifyd")
+(version "0.3.6")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "http://archive.xfce.org/src/apps/;
+  name "/" (version-major+minor version) "/"
+  name "-" version ".tar.bz2"))
+  (sha256
+   (base32
+"1ybcfqfynr33g5hp2lgq17s8qyx7rq6fd2iwrpwcvm6kml6prjpl"
+(build-system gnu-build-system)
+(arguments
+ `(#:con

[PATCH] gnu: Add Xfce Notification Daemon.

[Petter]

Hi Guix,

Be extra critical while reviewing this patch, I'm not good at this.

(Today I learned that a provided DBus service file first takes effect
after installing. I wasn't having any luck testing directly from
store. Thanks again wingo!)

Best,
PetterFrom 4cf9acab0817d2898772830f27c1a11c15926b98 Mon Sep 17 00:00:00 2001
From: Petter <pet...@mykolab.ch>
Date: Fri, 21 Apr 2017 15:33:22 +0200
Subject: [PATCH] gnu: Add Xfce Notification Daemon.

* gnu/packages/xfce.scm (xfce4-notifyd): New variable.
---
 gnu/packages/xfce.scm | 39 +++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index fce47d93c..f0e671259 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2016 Florian Paul Schmidt <mista.ta...@gmx.net>
 ;;; Copyright © 2016 Kei Kebreau <k...@openmailbox.org>
 ;;; Copyright © 2017 Ricardo Wurmus <rek...@elephly.net>
+;;; Copyright © 2017 Petter <pet...@mykolab.ch>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -850,3 +851,41 @@ calendar applications.  It also includes a panel clock plugin and an
 international clock application capable of simultaneously showing clocks from
 several different time zones.")
 (license gpl2+)))
+
+(define-public xfce4-notifyd
+  (package
+(name "xfce4-notifyd")
+(version "0.3.6")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "http://archive.xfce.org/src/apps/;
+  name "/" (version-major+minor version) "/"
+  name "-" version ".tar.bz2"))
+  (sha256
+   (base32
+"1ybcfqfynr33g5hp2lgq17s8qyx7rq6fd2iwrpwcvm6kml6prjpl"
+(build-system gnu-build-system)
+(arguments
+ `(#:configure-flags
+   (list (string-append "--prefix=" %output
+(native-inputs
+ `(("intltool" ,intltool)
+   ("pkg-config" ,pkg-config)))
+(propagated-inputs
+ `(("glib:bin" ,glib "bin")))
+(inputs
+ `(("gtk+" ,gtk+)
+   ("libxfce4util" ,libxfce4util)
+   ("libxfce4ui" ,libxfce4ui)
+   ("xfconf" ,xfconf)
+   ("libnotify" ,libnotify)))
+(home-page "https://goodies.xfce.org/projects/applications/xfce4-notifyd;)
+(synopsis "Lets applications pop up a notification bubble")
+(description
+ "The Xfce Notify Daemon (xfce4-notifyd for short) is a smallish program
+that implements the “server-side” portion of the Freedesktop desktop
+notifications specification. Applications that wish to pop up a notification
+bubble in a standard way can implicitly make use of xfce4-notifyd to do so by
+sending standard messages over D-Bus using the org.freedesktop.Notifications
+interface.")
+(license gpl2)))
-- 
2.12.2

From 4cf9acab0817d2898772830f27c1a11c15926b98 Mon Sep 17 00:00:00 2001
From: Petter <pet...@mykolab.ch>
Date: Fri, 21 Apr 2017 15:33:22 +0200
Subject: [PATCH] gnu: Add Xfce Notification Daemon.

* gnu/packages/xfce.scm (xfce4-notifyd): New variable.
---
 gnu/packages/xfce.scm | 39 +++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index fce47d93c..f0e671259 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2016 Florian Paul Schmidt <mista.ta...@gmx.net>
 ;;; Copyright © 2016 Kei Kebreau <k...@openmailbox.org>
 ;;; Copyright © 2017 Ricardo Wurmus <rek...@elephly.net>
+;;; Copyright © 2017 Petter <pet...@mykolab.ch>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -850,3 +851,41 @@ calendar applications.  It also includes a panel clock plugin and an
 international clock application capable of simultaneously showing clocks from
 several different time zones.")
 (license gpl2+)))
+
+(define-public xfce4-notifyd
+  (package
+(name "xfce4-notifyd")
+(version "0.3.6")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "http://archive.xfce.org/src/apps/;
+  name "/" (version-major+minor version) "/"
+  name "-" version ".tar.bz2"))
+  (sha256
+   (base32
+"1ybcfqfynr33g5hp2lgq17s8qyx7rq6fd2iwrpwcvm6kml6prjpl"
+(build-system gnu-build-system)
+(arguments
+ `(#:configure-flags
+   (list (string-append "--prefix=" %output
+(native-inputs
+ `(("intltool" ,intltool)
+   ("pkg-config" ,pkg-config)))
+(propagated-inputs
+ `(("glib:bin" ,glib "bin&quo