Re: [PATCH] gnu: Add gnushogi and xshogi

2017-02-23 Thread Leo Famulari
On Thu, Feb 23, 2017 at 06:19:19AM +0100, John Darrington wrote:
> On Wed, Feb 22, 2017 at 04:58:07PM -0500, Leo Famulari wrote:
>  On Wed, Feb 22, 2017 at 08:15:04PM +0100, John Darrington wrote:
>  > * gnu/packages/games.scm (gnushogi, xshogi): New variables.
>  
>  > +(define-public xshogi
>  
>  [...]
>  
>  > +;; Contains a copy of GPLv3 but the licence notices simply
>  > +;; state "GNU General Public Licence" without specifying a 
> version.
>  > +(license license:gpl1+)))
>  
>  Section 14 of the GPL says "If the Program does not specify a
>  version number of the GNU General Public License, you may choose any
>  version ever published by the Free Software Foundation."
>  
> You are correct.  That is why I put gpl1+
>  
>  Do we want to use version 1 of the GPL? I don't fully understand the
>  issues with it, but it's an unusual choice.
> 
> I don't have a strong opinion here.  But there is a precedent in Guix, that 
> where upstream permits a package to be distributed under a choice of licences,
> we simply present that choice to our users.  We don't - at least I haven't 
> seen 
> any instances of it - choose a particular one that suits us, unless there is 
> a 
> good reason for doing that.

Okay, that makes sense to me. Please do as you see fit :)


signature.asc
Description: PGP signature


Re: [PATCH] gnu: Add gnushogi and xshogi

2017-02-22 Thread John Darrington
On Wed, Feb 22, 2017 at 04:58:07PM -0500, Leo Famulari wrote:
 On Wed, Feb 22, 2017 at 08:15:04PM +0100, John Darrington wrote:
 > * gnu/packages/games.scm (gnushogi, xshogi): New variables.
 
 > +(define-public xshogi
 
 [...]
 
 > +;; Contains a copy of GPLv3 but the licence notices simply
 > +;; state "GNU General Public Licence" without specifying a version.
 > +(license license:gpl1+)))
 
 Section 14 of the GPL says "If the Program does not specify a
 version number of the GNU General Public License, you may choose any
 version ever published by the Free Software Foundation."
 
You are correct.  That is why I put gpl1+
 
 Do we want to use version 1 of the GPL? I don't fully understand the
 issues with it, but it's an unusual choice.

I don't have a strong opinion here.  But there is a precedent in Guix, that 
where upstream permits a package to be distributed under a choice of licences,
we simply present that choice to our users.  We don't - at least I haven't seen 
any instances of it - choose a particular one that suits us, unless there is a 
good reason for doing that.

J'

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.



signature.asc
Description: Digital signature


Re: [PATCH] gnu: Add gnushogi and xshogi

2017-02-22 Thread Leo Famulari
On Wed, Feb 22, 2017 at 08:15:04PM +0100, John Darrington wrote:
> * gnu/packages/games.scm (gnushogi, xshogi): New variables.

> +(define-public xshogi

[...]

> +;; Contains a copy of GPLv3 but the licence notices simply
> +;; state "GNU General Public Licence" without specifying a version.
> +(license license:gpl1+)))

Section 14 of the GPL says "If the Program does not specify a
version number of the GNU General Public License, you may choose any
version ever published by the Free Software Foundation."

https://www.gnu.org/licenses/gpl.html

Do we want to use version 1 of the GPL? I don't fully understand the
issues with it, but it's an unusual choice.



[PATCH] gnu: Add gnushogi and xshogi

2017-02-22 Thread John Darrington
* gnu/packages/games.scm (gnushogi, xshogi): New variables.
---
 gnu/packages/games.scm | 43 +++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 1d6a12a..50315a6 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -175,6 +175,49 @@ You may even apply photos to the faces instead of colors.  
The game is
 scriptable with Guile.")
 (license license:gpl3+)))
 
+(define-public gnushogi
+  (package
+(name "gnushogi")
+(version "1.4.2")
+(source
+ (origin
+  (method url-fetch)
+  (uri (string-append "mirror://gnu/gnushogi/gnushogi-"
+  version ".tar.gz"))
+  (sha256
+   (base32
+"0a9bsl2nbnb138lq0h14jfc5xvz7hpb2bcsj4mjn6g1hcsl4ik0y"
+(arguments `(#:tests? #f)) ;; No check target.
+(build-system gnu-build-system)
+(home-page "http://www.gnu.org/software/gnushogi/";)
+(synopsis "The game of Shogi (Japanese chess)")
+(description  "GNU Shogi is a program that plays the game Shogi (Japanese
+Chess).  It is similar to standard chess but this variant is far more 
complicated.")
+(license license:gpl3+)))
+
+(define-public xshogi
+  (package
+(name "xshogi")
+(version "1.4.2")
+(source
+ (origin
+  (method url-fetch)
+  (uri (string-append "mirror://gnu/gnushogi/xshogi-"
+  version ".tar.gz"))
+  (sha256
+   (base32
+"1dns0nhymak44by18sv48m4xb2skiwbi2i3nb9hl6w9iwd2i2brf"
+(build-system gnu-build-system)
+(inputs
+ `(("libxaw" ,libxaw)
+   ("libxt" ,libxt)))
+(home-page "http://www.gnu.org/software/gnushogi/";)
+(synopsis "User interface for @code{gnushogi}")
+(description  "A graphical user interface for the package 
@code{gnushogi}.")
+;; Contains a copy of GPLv3 but the licence notices simply
+;; state "GNU General Public Licence" without specifying a version.
+(license license:gpl1+)))
+
 (define-public abbaye
   (package
 (name "abbaye")
-- 
2.1.4