Re: [PATCH] gnu: Add guildhall.

[Ludovic Courtès]

Ricardo Wurmus  skribis:

> Ludovic Courtès  writes:
>
>> Ricardo Wurmus  skribis:
>>
>>> * gnu/packages/guile.scm (guildhall): New variable.
>>
>> [...]
>>
>>> +   `(;; FIXME: tests fail for unknown reason.  They seem to try to load
>>> + ;; the bash executable as a Scheme file.  See bug report at
>>> + ;; https://github.com/ijp/guildhall/issues/22
>>> + #:tests? #f
>>
>> I think that’s because Makefile.am has:
>>
>>   TESTS_ENVIRONMENT = $(GUILE) …
>>
>> whereas it should instead do (assuming test files have the .scm
>> extension):
>>
>>   SCM_LOG_DRIVER = $(GUILE) …
>>
>> and have ‘TESTS_ENVIRONMENT’ contain only environment variables.
>>
>> See
>> 
>> for an example of the modification that is needed.
>
> Interesting.  Do you want me to patch this in our package or should I
> just forward this info to upstream and have them fix it?  (There’s an
> open uncommented bug report about this.)

You could do both, but at least report it upstream since it’s easily
fixed.

TIA!
Ludo’.

Re: [PATCH] gnu: Add guildhall.

[Ricardo Wurmus]

Ludovic Courtès  writes:

> Ricardo Wurmus  skribis:
>
>> * gnu/packages/guile.scm (guildhall): New variable.
>
> [...]
>
>> +   `(;; FIXME: tests fail for unknown reason.  They seem to try to load
>> + ;; the bash executable as a Scheme file.  See bug report at
>> + ;; https://github.com/ijp/guildhall/issues/22
>> + #:tests? #f
>
> I think that’s because Makefile.am has:
>
>   TESTS_ENVIRONMENT = $(GUILE) …
>
> whereas it should instead do (assuming test files have the .scm
> extension):
>
>   SCM_LOG_DRIVER = $(GUILE) …
>
> and have ‘TESTS_ENVIRONMENT’ contain only environment variables.
>
> See
> 
> for an example of the modification that is needed.

Interesting.  Do you want me to patch this in our package or should I
just forward this info to upstream and have them fix it?  (There’s an
open uncommented bug report about this.)

> Also, maybe add a ‘package-for-guile-2.2’ variant if that works (which
> seems unlikely…).

Okay.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Re: [PATCH] gnu: Add guildhall.

[Ludovic Courtès]

Ricardo Wurmus  skribis:

> * gnu/packages/guile.scm (guildhall): New variable.

[...]

> +   `(;; FIXME: tests fail for unknown reason.  They seem to try to load
> + ;; the bash executable as a Scheme file.  See bug report at
> + ;; https://github.com/ijp/guildhall/issues/22
> + #:tests? #f

I think that’s because Makefile.am has:

  TESTS_ENVIRONMENT = $(GUILE) …

whereas it should instead do (assuming test files have the .scm
extension):

  SCM_LOG_DRIVER = $(GUILE) …

and have ‘TESTS_ENVIRONMENT’ contain only environment variables.

See

for an example of the modification that is needed.

Also, maybe add a ‘package-for-guile-2.2’ variant if that works (which
seems unlikely…).

Thanks!

Ludo’.

[PATCH] gnu: Add guildhall.

[Ricardo Wurmus]

* gnu/packages/guile.scm (guildhall): New variable.
---
 gnu/packages/guile.scm | 50 +-
 1 file changed, 49 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index 7ce668368..61f62cc24 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -3,7 +3,7 @@
 ;;; Copyright © 2014, 2015 Mark H Weaver 
 ;;; Copyright © 2015, 2017 Christopher Allan Webber 
 ;;; Copyright © 2016 Alex Sassmannshausen 
-;;; Copyright © 2016 Ricardo Wurmus 
+;;; Copyright © 2016, 2017 Ricardo Wurmus 
 ;;; Copyright © 2016 Erik Edrosa 
 ;;; Copyright © 2016 Eraim Flashner 
 ;;; Copyright © 2016 Alex Kost 
@@ -321,6 +321,54 @@ applicable."
 (files '("lib/guile/2.0/site-ccache"
  "share/guile/site/2.0")))
 
+;; There has not been any release yet.
+(define-public guildhall
+  (let ((commit "2fe2cc539f4b811bbcd69e58738db03eb5a2b778")
+(revision "1"))
+(package
+  (name "guildhall")
+  (version (string-append "0-" revision "." (string-take commit 9)))
+  (source (origin
+(method git-fetch)
+(uri (git-reference
+  (url "https://github.com/ijp/guildhall.git";)
+  (commit commit)))
+(file-name (string-append name "-" version "-checkout"))
+(sha256
+ (base32
+  "115bym7bg66h3gs399yb2vkzc2ygriaqsn4zbrg8f054mgy8wzn1"
+  (build-system gnu-build-system)
+  (arguments
+   `(;; FIXME: tests fail for unknown reason.  They seem to try to load
+ ;; the bash executable as a Scheme file.  See bug report at
+ ;; https://github.com/ijp/guildhall/issues/22
+ #:tests? #f
+ #:phases
+ (modify-phases %standard-phases
+   (add-before 'configure 'autogen
+ (lambda _
+   (zero? (system* "sh" "autogen.sh")))
+  (inputs
+   `(("guile" ,guile-2.0)))
+  (native-inputs
+   `(("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("texinfo" ,texinfo)))
+  (synopsis "Package manager for Guile")
+  (description
+   "Guildhall is a package manager written for Guile Scheme.  A guild is
+an association of independent craftspeople.  A guildhall is where they meet.
+This Guildhall aims to make a virtual space for Guile wizards and journeyfolk
+to share code.
+
+On a practical level, Guildhall lets you share Scheme modules and programs
+over the internet, and install code that has been shared by others.  Guildhall
+can handle dependencies, so when a program requires several libraries, and
+each of those has further dependencies, all of the prerequisites for the
+program can be installed in one go.")
+  (home-page "https://github.com/ijp/guildhall";)
+  (license gpl3+
+
 
 ;;;
 ;;; Extensions.
-- 
2.11.0