Re: [PATCH] gnu: font-gnu-unifont: Call mkfontdir for pcf output
Hi, All, Alex Kost writes: > Danny Milosavljevic (2017-02-14 18:56 +0100) wrote: > >> Hi, >> >>> One problem of this solution is that some font packages (for example, >>> fonts-misc-misc) already have fonts.dir, to avoid conflict, it is better >>> to remove fonts.dir in all font packages and generate fonts.dir in >>> fonts-dir-file, I think that is good. But I don't know whether others >>> think that is a good idea. >> >> If it can happen that multiple packages install to share/fonts/ >> (certainly true for share/fonts/truetype and probably true for other >> -directories) and fonts.dir then is conflicting (and doesn't >> ever contain all the entries of the directory), I think that your idea >> is very good (and how it was done before is dead wrong). > > I completely agree; removing all "fonts.dir" and "fonts.alias" files > from packages and regenerating them at profile time looks like a good > idea to me. Good to know this. I will implement it as this. Best Regards, Huang, Ying
Re: [PATCH] gnu: font-gnu-unifont: Call mkfontdir for pcf output
Danny Milosavljevic (2017-02-14 18:56 +0100) wrote: > Hi, > >> One problem of this solution is that some font packages (for example, >> fonts-misc-misc) already have fonts.dir, to avoid conflict, it is better >> to remove fonts.dir in all font packages and generate fonts.dir in >> fonts-dir-file, I think that is good. But I don't know whether others >> think that is a good idea. > > If it can happen that multiple packages install to share/fonts/ > (certainly true for share/fonts/truetype and probably true for other > -directories) and fonts.dir then is conflicting (and doesn't > ever contain all the entries of the directory), I think that your idea > is very good (and how it was done before is dead wrong). I completely agree; removing all "fonts.dir" and "fonts.alias" files from packages and regenerating them at profile time looks like a good idea to me. -- Alex
Re: [PATCH] gnu: font-gnu-unifont: Call mkfontdir for pcf output
Hi, > One problem of this solution is that some font packages (for example, > fonts-misc-misc) already have fonts.dir, to avoid conflict, it is better > to remove fonts.dir in all font packages and generate fonts.dir in > fonts-dir-file, I think that is good. But I don't know whether others > think that is a good idea. If it can happen that multiple packages install to share/fonts/ (certainly true for share/fonts/truetype and probably true for other -directories) and fonts.dir then is conflicting (and doesn't ever contain all the entries of the directory), I think that your idea is very good (and how it was done before is dead wrong).
Re: [PATCH] gnu: font-gnu-unifont: Call mkfontdir for pcf output
"Huang, Ying" writes: > Hi, Wenwu, > > Thanks for comments! > > iyzs...@member.fsf.org (宋文武) writes: > >> huang_ying_cari...@163.com writes: >> >>> * gnu/packages/fonts.scm (font-gnu-unifont): call mkfontdir for pcf output. >>> >>> Signed-off-by: "Huang, Ying" >>> --- >>> gnu/packages/fonts.scm | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm >>> index 1f6d1d0c3..088a6bec9 100644 >>> --- a/gnu/packages/fonts.scm >>> +++ b/gnu/packages/fonts.scm >>> @@ -671,13 +671,15 @@ languages, plus Greek and Cyrillic.") >>> (string-append "PCFDEST=" pcf) >>> (string-append "CONSOLEDEST=" psf) >>> "install") >>> + (system* "mkfontdir" pcf) >> >> This will create 'share/fonts/misc/fonts.dir' in the 'pcf' output of >> font-gnu-unifont package. When multiple packages have this file, >> collisions occour and then I guess it won't work as expected. > > I think so too. > >> The right >> place to create this file is the 'fonts-dir-file' hook in profiles.scm, >> currently it does 'mkfontscale' and 'mkfontdir' only for truetype fonts >> under 'share/fonts/truetype', which can be extended for each directory >> under 'share/fonts'. What do you think? > > I think that is better. I have thought about that before. But I didn't > know whether that is necessary in general at that time. One problem of this solution is that some font packages (for example, fonts-misc-misc) already have fonts.dir, to avoid conflict, it is better to remove fonts.dir in all font packages and generate fonts.dir in fonts-dir-file, I think that is good. But I don't know whether others think that is a good idea. Best Regards, Huang, Ying
Re: [PATCH] gnu: font-gnu-unifont: Call mkfontdir for pcf output
Hi, Wenwu, Thanks for comments! iyzs...@member.fsf.org (宋文武) writes: > huang_ying_cari...@163.com writes: > >> * gnu/packages/fonts.scm (font-gnu-unifont): call mkfontdir for pcf output. >> >> Signed-off-by: "Huang, Ying" >> --- >> gnu/packages/fonts.scm | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm >> index 1f6d1d0c3..088a6bec9 100644 >> --- a/gnu/packages/fonts.scm >> +++ b/gnu/packages/fonts.scm >> @@ -671,13 +671,15 @@ languages, plus Greek and Cyrillic.") >> (string-append "PCFDEST=" pcf) >> (string-append "CONSOLEDEST=" psf) >> "install") >> + (system* "mkfontdir" pcf) > > This will create 'share/fonts/misc/fonts.dir' in the 'pcf' output of > font-gnu-unifont package. When multiple packages have this file, > collisions occour and then I guess it won't work as expected. I think so too. > The right > place to create this file is the 'fonts-dir-file' hook in profiles.scm, > currently it does 'mkfontscale' and 'mkfontdir' only for truetype fonts > under 'share/fonts/truetype', which can be extended for each directory > under 'share/fonts'. What do you think? I think that is better. I have thought about that before. But I didn't know whether that is necessary in general at that time. Best Regards, Huang, Ying
Re: [PATCH] gnu: font-gnu-unifont: Call mkfontdir for pcf output
huang_ying_cari...@163.com writes: > * gnu/packages/fonts.scm (font-gnu-unifont): call mkfontdir for pcf output. > > Signed-off-by: "Huang, Ying" > --- > gnu/packages/fonts.scm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm > index 1f6d1d0c3..088a6bec9 100644 > --- a/gnu/packages/fonts.scm > +++ b/gnu/packages/fonts.scm > @@ -671,13 +671,15 @@ languages, plus Greek and Cyrillic.") > (string-append "PCFDEST=" pcf) > (string-append "CONSOLEDEST=" psf) > "install") > + (system* "mkfontdir" pcf) This will create 'share/fonts/misc/fonts.dir' in the 'pcf' output of font-gnu-unifont package. When multiple packages have this file, collisions occour and then I guess it won't work as expected. The right place to create this file is the 'fonts-dir-file' hook in profiles.scm, currently it does 'mkfontscale' and 'mkfontdir' only for truetype fonts under 'share/fonts/truetype', which can be extended for each directory under 'share/fonts'. What do you think?
[PATCH] gnu: font-gnu-unifont: Call mkfontdir for pcf output
* gnu/packages/fonts.scm (font-gnu-unifont): call mkfontdir for pcf output.
Signed-off-by: "Huang, Ying"
---
gnu/packages/fonts.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 1f6d1d0c3..088a6bec9 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -671,13 +671,15 @@ languages, plus Greek and Cyrillic.")
(string-append "PCFDEST=" pcf)
(string-append "CONSOLEDEST=" psf)
"install")
+ (system* "mkfontdir" pcf)
;; Move Texinfo file to the right place.
(mkdir (string-append bin "/share/info"))
(rename-file (string-append bin "/share/unifont/unifont.info.gz")
(string-append bin "/share/info/unifont.info.gz"))
#t))
(inputs
- `(("perl" ,perl))) ; for utilities
+ `(("perl" ,perl) ; for utilities
+ ("mkfontdir" ,mkfontdir)))
(synopsis
"Large bitmap font covering Unicode's Basic Multilingual Plane")
(description
--
2.11.1
