Re: [PATCH 0/5] python2-variants
On Fri, 12 Feb 2016 18:56:25 -0500 Leo Famulari wrote: > > [1] python2-tempest-lib continues to fail to build from source, as > before. > I was hoping that this would magically fix it. :) -- Efraim Flashner אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted pgpXcyyGfmq61.pgp Description: OpenPGP digital signature
Re: [PATCH 0/5] python2-variants
On Wed, Feb 10, 2016 at 10:21:17PM +0100, Ludovic Courtès wrote:
> Leo Famulari skribis:
>
> > These patches apply the new python2-variant system introduced in
> > 1be83341 to python2-{cryptography, jsonschema, wheel, requests}, and
> > then split acme into python-acme and python2-acme.
>
> Neat! Let’s see how many lines of code that saves us. :-)
If we must measure something, that's a good metric ;)
> > As usual, I tested the changes to acme / letsencrypt by renewing the
> > certificates of my webserver [0].
>
> OK. I’m reviewing this series mostly superficially under the assumption
> that you’ve checked that things still build.
This exercise has made me wish I had a continuous integration system to
test the changes. Is it very difficult to set up a Hydra instance?
Thanks to Ludo and Efraim for reviewing this accidentally sloppy patch
series (I guess I was more tired than I realized!).
I took Efraim's suggestions to propagate the "simplifications" up the
graph of problematic python-2 variants, and I folded these commits into
the commit that fixed the package root of the problem of that part of
the graph, as in 57b7b8cd60. These are the "Take the result of
'package-with-python2' directly' log lines.
There were a few cases where I did not propagate the simplification
because the package in question would still be using the "old" system
afterwards [0]. Those packages still work as before [1].
I removed the changes to python2-oauthlib. There were unnecessary for
this patch set and will require the conversion of python2-unittest2.
[0] There are some of these in openstack.scm.
[1] python2-tempest-lib continues to fail to build from source, as
before.
Re: [PATCH 0/5] python2-variants
On Thu, Feb 11, 2016 at 09:07:42PM +0200, Efraim Flashner wrote:
> On Tue, 9 Feb 2016 03:10:58 -0500
> Leo Famulari wrote:
>
> > These patches apply the new python2-variant system introduced in
> > 1be83341 to python2-{cryptography, jsonschema, wheel, requests}, and
> > then split acme into python-acme and python2-acme.
> >
> > As usual, I tested the changes to acme / letsencrypt by renewing the
> > certificates of my webserver [0].
> >
> > I'm not 100% confident in the style of these changes, or in the
> > selection of packages I updated, aside from this being the minimum
> > number of packages to update in order to split acme in two. But it seems
> > that it's not necessary to update the full graph of packages touched by
> > these changes.
> >
> > Feedback?
> >
> > [0]
> > It turns out that my server can't build python2-cryptography from
> > source. I guess that 1 GB RAM is not enough. So I learned how to use
> > `guix archive` :)
>
> I've never had to use guix archive. Is it something where having more swap
> would've helped?
I built python2-cryptography on my workstation and then used `guix
archive` to transfer the result to the tiny server. It was very easy to
follow the instructions :)
>
> >
> > Leo Famulari (5):
> > gnu: python-cryptography: Define 'python2-variant'.
> > gnu: python-jsonschema: Define 'python2-variant'.
> > gnu: python-wheel: Define 'python2-variant'.
> > gnu: python-requests: Define 'python2-variant'.
> > gnu: Split acme into python-acme and python2-acme.
> >
> > gnu/packages/python.scm | 47
> > +++
> > gnu/packages/tls.scm| 34 ++
> > 2 files changed, 37 insertions(+), 44 deletions(-)
> >
>
>
>
> --
> Efraim Flashner אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted
Re: [PATCH 0/5] python2-variants
On Tue, 9 Feb 2016 03:10:58 -0500
Leo Famulari wrote:
> These patches apply the new python2-variant system introduced in
> 1be83341 to python2-{cryptography, jsonschema, wheel, requests}, and
> then split acme into python-acme and python2-acme.
>
> As usual, I tested the changes to acme / letsencrypt by renewing the
> certificates of my webserver [0].
>
> I'm not 100% confident in the style of these changes, or in the
> selection of packages I updated, aside from this being the minimum
> number of packages to update in order to split acme in two. But it seems
> that it's not necessary to update the full graph of packages touched by
> these changes.
>
> Feedback?
>
> [0]
> It turns out that my server can't build python2-cryptography from
> source. I guess that 1 GB RAM is not enough. So I learned how to use
> `guix archive` :)
I've never had to use guix archive. Is it something where having more swap
would've helped?
>
> Leo Famulari (5):
> gnu: python-cryptography: Define 'python2-variant'.
> gnu: python-jsonschema: Define 'python2-variant'.
> gnu: python-wheel: Define 'python2-variant'.
> gnu: python-requests: Define 'python2-variant'.
> gnu: Split acme into python-acme and python2-acme.
>
> gnu/packages/python.scm | 47 +++
> gnu/packages/tls.scm| 34 ++
> 2 files changed, 37 insertions(+), 44 deletions(-)
>
--
Efraim Flashner אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
pgphCyH5ADsjE.pgp
Description: OpenPGP digital signature
Re: [PATCH 0/5] python2-variants
Leo Famulari skribis:
> These patches apply the new python2-variant system introduced in
> 1be83341 to python2-{cryptography, jsonschema, wheel, requests}, and
> then split acme into python-acme and python2-acme.
Neat! Let’s see how many lines of code that saves us. :-)
> As usual, I tested the changes to acme / letsencrypt by renewing the
> certificates of my webserver [0].
OK. I’m reviewing this series mostly superficially under the assumption
that you’ve checked that things still build.
> * gnu/packages/python.scm (python-cryptography)[properties]: New field.
> (python2-cryptography): Use 'strip-python2-variant'.
OK!
Ludo’.
[PATCH 0/5] python2-variants
These patches apply the new python2-variant system introduced in
1be83341 to python2-{cryptography, jsonschema, wheel, requests}, and
then split acme into python-acme and python2-acme.
As usual, I tested the changes to acme / letsencrypt by renewing the
certificates of my webserver [0].
I'm not 100% confident in the style of these changes, or in the
selection of packages I updated, aside from this being the minimum
number of packages to update in order to split acme in two. But it seems
that it's not necessary to update the full graph of packages touched by
these changes.
Feedback?
[0]
It turns out that my server can't build python2-cryptography from
source. I guess that 1 GB RAM is not enough. So I learned how to use
`guix archive` :)
Leo Famulari (5):
gnu: python-cryptography: Define 'python2-variant'.
gnu: python-jsonschema: Define 'python2-variant'.
gnu: python-wheel: Define 'python2-variant'.
gnu: python-requests: Define 'python2-variant'.
gnu: Split acme into python-acme and python2-acme.
gnu/packages/python.scm | 47 +++
gnu/packages/tls.scm| 34 ++
2 files changed, 37 insertions(+), 44 deletions(-)
--
2.6.3
