Re: [PATCH 1/3] gnu: Add python-pip.

[Mathieu Lirzin]

Cyril Roelandt  writes:

> * gnu/packages/python.scm (python-pip, python2-pip): New variables.
> ---
>  gnu/packages/python.scm | 32 
>  1 file changed, 32 insertions(+)

[...]

> +(home-page "https://pip.pypa.io/";)
> +(synopsis
> +  "The PyPA recommended tool for installing Python packages")
   ^^^

IMO Pypa recommandations are not relevant in Guix context.  What about
something more neutral like “Xenophobic package manager”? ;) Just
kidding.

I would prefer 

(synopsis "Package manager for Python software")

> +(description
> +  "Pip is a package manager for Python software, that finds packages on 
> the
> +Python Package Index (PyPI).")

It would be nice to have a more verbose description, for example
describing its main features...  Sorry I can't help much :)

> +(license license:expat)))
> +
> +(define-public python2-pip
> +  (package-with-python2 python-pip))

Otherwise LGTM!

--
Mathieu Lirzin

[PATCH 1/3] gnu: Add python-pip.

[Cyril Roelandt]

* gnu/packages/python.scm (python-pip, python2-pip): New variables.
---
 gnu/packages/python.scm | 32 
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 798a22f..a8d811e 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -4916,3 +4916,35 @@ printing of sub-tables by specifying a row range.")
 
 (define-public python2-prettytable
   (package-with-python2 python-prettytable))
+
+(define-public python-pip
+  (package
+(name "python-pip")
+(version "7.1.2")
+(source
+ (origin
+   (method url-fetch)
+   (uri (string-append
+ "https://pypi.python.org/packages/source/p/pip/pip-";
+ version ".tar.gz"))
+   (sha256
+(base32
+ "0xx4aypfgchxdknxq7gyqghd8wb221zrzyqlbabzm32jy237j16a"
+(build-system python-build-system)
+(inputs
+  `(("python-setuptools" ,python-setuptools)
+("python-virtualenv" ,python-virtualenv)
+;; Tests
+("python-mock" ,python-mock)
+("python-pytest" ,python-pytest)
+("python-scripttest" ,python-scripttest)))
+(home-page "https://pip.pypa.io/";)
+(synopsis
+  "The PyPA recommended tool for installing Python packages")
+(description
+  "Pip is a package manager for Python software, that finds packages on the
+Python Package Index (PyPI).")
+(license license:expat)))
+
+(define-public python2-pip
+  (package-with-python2 python-pip))
-- 
2.1.4