Re: [PATCH 1/6] gnu: Add python-rst2ansi

[Marius Bakke]

Muriithi Frederick Muriuki  writes:

> * gnu/packages/python.scm (python-rst2ansi): New variable.

Applied, thanks!

I made the synopsis on this package a little more general and trimmed
the description lengths on all of them.

> ---
>  gnu/packages/python.scm | 23 +++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 5b4d2b0..61b34bf 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -35,6 +35,7 @@
>  ;;; Copyright © 2016, 2017 Tobias Geerinckx-Rice 
>  ;;; Copyright © 2016 Thomas Danckaert 
>  ;;; Copyright © 2017 Carlo Zancanaro 
> +;;; Copyright © 2017 Frederick M. Muriithi 
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -12536,3 +12537,25 @@ console.")
>  This implementation is slow (hence the project name) but still useful when
>  faster ones are not available.")
>  (license license:asl2.0)))
> +
> +(define-public python-rst2ansi
> +  (package
> +(name "python-rst2ansi")
> +(version "0.1.5")
> +(source
> + (origin
> +   (method url-fetch)
> +   (uri (pypi-uri "rst2ansi" version))
> +   (sha256
> +(base32
> + "0vzy6gd60l79ff750scl0sz48r1laalkl6md6dwzah4dcadgn5qv"
> +(build-system python-build-system)
> +(propagated-inputs
> + `(("python-docutils" ,python-docutils)))
> +(home-page "https://github.com/Snaipe/python-rst-to-ansi;)
> +(synopsis
> + "Python rst converter to ansi-decorated console output")
> +(description
> + "Python module dedicated to rendering RST (reStructuredText) documents 
> to
> + ansi-escaped strings suitable for display in a terminal.")
> +(license license:expat)))
> -- 
> 2.10.2


signature.asc
Description: PGP signature

[PATCH 1/6] gnu: Add python-rst2ansi

[Muriithi Frederick Muriuki]

* gnu/packages/python.scm (python-rst2ansi): New variable.
---
 gnu/packages/python.scm | 23 +++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5b4d2b0..61b34bf 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -35,6 +35,7 @@
 ;;; Copyright © 2016, 2017 Tobias Geerinckx-Rice 
 ;;; Copyright © 2016 Thomas Danckaert 
 ;;; Copyright © 2017 Carlo Zancanaro 
+;;; Copyright © 2017 Frederick M. Muriithi 
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -12536,3 +12537,25 @@ console.")
 This implementation is slow (hence the project name) but still useful when
 faster ones are not available.")
 (license license:asl2.0)))
+
+(define-public python-rst2ansi
+  (package
+(name "python-rst2ansi")
+(version "0.1.5")
+(source
+ (origin
+   (method url-fetch)
+   (uri (pypi-uri "rst2ansi" version))
+   (sha256
+(base32
+ "0vzy6gd60l79ff750scl0sz48r1laalkl6md6dwzah4dcadgn5qv"
+(build-system python-build-system)
+(propagated-inputs
+ `(("python-docutils" ,python-docutils)))
+(home-page "https://github.com/Snaipe/python-rst-to-ansi;)
+(synopsis
+ "Python rst converter to ansi-decorated console output")
+(description
+ "Python module dedicated to rendering RST (reStructuredText) documents to
+ ansi-escaped strings suitable for display in a terminal.")
+(license license:expat)))
-- 
2.10.2

Re: [PATCH 1/6] gnu: Add python-rst2ansi

[Marius Bakke]

Hi Muriithi,

Thank you for these patches! I will respond to them individually.

They look good for the most part, but need some tiny tweaks that breaks
the patch context. In particular, descriptions should end with a period,
but if I add that to one patch, the next does not apply!

Normally I would simply amend these commits while applying them, so
please excuse the nit-picking.

Could you also add a copyright notice for yourself at the top of
python.scm with the first commit?

Muriithi Frederick Muriuki  writes:

> * gnu/packages/python.scm (python-rst2ansi): New variable.
> ---
>  gnu/packages/python.scm | 23 +++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index d53eea1..b57e9a7 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -12536,3 +12536,26 @@ console.")
>  This implementation is slow (hence the project name) but still useful when
>  faster ones are not available.")
>  (license license:asl2.0)))
> +
> +(define-public python-rst2ansi
> +  (package
> +(name "python-rst2ansi")
> +(version "0.1.5")
> +(source
> + (origin
> +   (method url-fetch)
> +   (uri (pypi-uri "rst2ansi" version))
> +   (sha256
> +(base32
> + "0vzy6gd60l79ff750scl0sz48r1laalkl6md6dwzah4dcadgn5qv"
> +(build-system python-build-system)
> +(native-inputs
> + `(("python-docutils" ,python-docutils)))

This should be a propagated-input, since rst2ansi needs docutils at
runtime.

> +(home-page
> + "https://github.com/Snaipe/python-rst-to-ansi;)

The newline here is not necessary.

> +(synopsis
> + "Python rst converter to ansi-decorated console output")

"Convert RST to ANSI-decorated console output".

> +(description
> + "Python module dedicated to rendering RST (reStructuredText) documents 
> to
> + ansi-escaped strings suitable for display in a terminal")

All descriptions should end with a "." as mentioned above.
`guix lint python-rst2ansi` should warn about this.


signature.asc
Description: PGP signature

[PATCH 1/6] gnu: Add python-rst2ansi

[Muriithi Frederick Muriuki]

* gnu/packages/python.scm (python-rst2ansi): New variable.
---
 gnu/packages/python.scm | 23 +++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index d53eea1..b57e9a7 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -12536,3 +12536,26 @@ console.")
 This implementation is slow (hence the project name) but still useful when
 faster ones are not available.")
 (license license:asl2.0)))
+
+(define-public python-rst2ansi
+  (package
+(name "python-rst2ansi")
+(version "0.1.5")
+(source
+ (origin
+   (method url-fetch)
+   (uri (pypi-uri "rst2ansi" version))
+   (sha256
+(base32
+ "0vzy6gd60l79ff750scl0sz48r1laalkl6md6dwzah4dcadgn5qv"
+(build-system python-build-system)
+(native-inputs
+ `(("python-docutils" ,python-docutils)))
+(home-page
+ "https://github.com/Snaipe/python-rst-to-ansi;)
+(synopsis
+ "Python rst converter to ansi-decorated console output")
+(description
+ "Python module dedicated to rendering RST (reStructuredText) documents to
+ ansi-escaped strings suitable for display in a terminal")
+(license license:expat)))
-- 
2.1.4