Re: [PATCH 10/96] gnu: Add ocamlmod.

2017-01-15 Thread David Craven 
You're the boss :)

Currently have to study for exams, then I'll be working on adding a
system test for efi which will involve a bunch of work - building
coreboot - add tianocore payload and making qemu flags more
configurable (the idea being that we can add system tests for uboot
using the coreboot uboot payload too). rustc needs adapting to the new
cargo based rustbuild system...

Re: [PATCH 10/96] gnu: Add ocamlmod.

2017-01-04 Thread Leo Famulari 
On Wed, Jan 04, 2017 at 10:02:29PM +0100, Ludovic Courtès wrote:
> Hello!
> 
> David Craven  skribis:
> 
> > If you take a little more care with the commit message conventions and
> > coding style, we might be able to convince Ludo to give you commit
> > access, since you are clearly our local ocaml expert :)
> 
> Sounds like a good idea to me!
> 
> Julien: could you create a Savannah account and upload the OpenPGP key
> that you’re going to use to sign commits?
> 
> Like Dave suggest, you’re welcome to take another look at the commit log
> conventions and all that, I think you’re almost there.  ;-)
> 
>   https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html

And make sure to read 'HACKING'! :)

Re: [PATCH 10/96] gnu: Add ocamlmod.

2017-01-04 Thread Ludovic Courtès 
Hello!

David Craven  skribis:

> If you take a little more care with the commit message conventions and
> coding style, we might be able to convince Ludo to give you commit
> access, since you are clearly our local ocaml expert :)

Sounds like a good idea to me!

Julien: could you create a Savannah account and upload the OpenPGP key
that you’re going to use to sign commits?

Like Dave suggest, you’re welcome to take another look at the commit log
conventions and all that, I think you’re almost there.  ;-)

  https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html

Thanks,
Ludo’.

Re: [PATCH 10/96] gnu: Add ocamlmod.

2017-01-04 Thread David Craven 
> If you take a little more care with the commit message conventions and
> coding style, we might be able to convince Ludo to give you commit
> access, since you are clearly our local ocaml expert :)

Not that I have any say in this and apologize if I'm overstepping...

Re: [PATCH 10/96] gnu: Add ocamlmod.

2017-01-04 Thread David Craven 
> The thing is tests are passed during 'build. This is activated by the 
> --enable-tests argument, that is enabled by #:tests? #t.

Ah I see. Then it makes sense. I was a bit hasty with this. I already
pushed the first 20 packages. Sorry about that, I'll change it back.

If you take a little more care with the commit message conventions and
coding style, we might be able to convince Ludo to give you commit
access, since you are clearly our local ocaml expert :)

Re: [PATCH 10/96] gnu: Add ocamlmod.

2017-01-04 Thread julien lepiller 

Le 2017-01-04 16:00, David Craven a écrit :
+(arguments `(#:phases (modify-phases %standard-phases (delete 
'check


The standard way of doing this is with #:tests? #f.


The thing is tests are passed during 'build. This is activated by the 
--enable-tests argument, that is enabled by #:tests? #t. This is only to 
disable passing tests twice. With #:tests? #f, no test is run. So, what 
should we do? Maybe change ocaml-build-system to have #:tests? only 
modify the phases, and not the configure argument, and having a 
separated #:test-argument? to add the argument to configure?

Re: [PATCH 10/96] gnu: Add ocamlmod.

2017-01-04 Thread David Craven 
+(arguments `(#:phases (modify-phases %standard-phases (delete 'check

The standard way of doing this is with #:tests? #f.

[PATCH 10/96] gnu: Add ocamlmod.

2017-01-03 Thread Julien Lepiller 
* gnu/packages/ocaml.scm (ocamlmod): New variable.
---
 gnu/packages/ocaml.scm | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 1de96c760..1900cfc70 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -801,3 +801,18 @@ other XUnit testing frameworks.")
 JAR format.  It provides functions for reading from and writing to compressed
 files in these formats.")
 (license license:lgpl2.1)))
+
+(define-public ocamlmod
+  (package
+(name "ocamlmod")
+(version "0.0.8")
+(home-page "https://forge.ocamlcore.org/projects/ocamlmod/";)
+(source (ocaml-forge-origin name version 1544
+   "1w0w8lfyymvk300dv13gvhrddpcyknvyp4g2yvq2vaw7khkhjs9g"))
+(build-system ocaml-build-system)
+(native-inputs `(("ounit" ,ocaml-ounit)))
+; tests are done during build
+(arguments `(#:phases (modify-phases %standard-phases (delete 'check
+(synopsis "Generate modules from OCaml source files")
+(description "Generate modules from OCaml source files.")
+(license license:lgpl2.1))); with an exception
-- 
2.11.0