Re: Fix for librsvg 2.40 on core-updates
Am Mon, Apr 10, 2023 at 07:00:16PM + schrieb Kaelyn: > I just mailed https://issues.guix.gnu.org/62758 to add a snippet to fix the > build error. I used a similar approach as the existing snippet for fixing a > format overflow error. (I also forgot to set the subject prefix to "PATCH > core-updates" on the git send-mail command line.). Thanks a lot, this looks like a good fix. I have just pushed it. Andreas
Re: Fix for librsvg 2.40 on core-updates
Hi Kaelyn, On Mon, Apr 10, 2023 at 12:00 PM Kaelyn wrote: > > I also forgot to set the subject prefix to "PATCH core-updates" I took the liberty to retitle the bug for you. [1] (The exclamation error, in turn, was an error on my part.) You can do it too, via the Debbugs control server. [2] Kind regards Felix Lechner [1] https://debbugs.gnu.org/cgi/bugreport.cgi?msg=10;bug=62758 [2] https://debbugs.gnu.org/server-control.html
Re: Fix for librsvg 2.40 on core-updates
--- Original Message --- On Saturday, April 8th, 2023 at 3:55 PM, Kaelyn wrote: > > --- Original Message --- > On Saturday, April 8th, 2023 at 9:52 AM, Andreas Enge andr...@enge.fr wrote: > > > > > Hello, > > > > Am Fri, Apr 07, 2023 at 04:53:15PM + schrieb Kaelyn: > > > > > On core-updates, librsvg-2.40 fails to compile due to a single failing > > > test (I've confirmed the failure on x86_64 and i686, though the package > > > is only used/needed on non-x86_64 systems for gtk+ and others; it also > > > affects wine and wine-staging on x86_64 as they are 32-bit packages). I > > > was able to track down the test failure to a text rendering difference > > > between Pango 1.48 and 1.50, which led to the text being one pixel line > > > higher between the reference and output images. On Monday I submitted > > > https://issues.guix.gnu.org/62646 which adds a phase to librsvg-2.40 to > > > adjust the output Y coordinate of the SVG transformation matrix by one > > > for the failing test so that it passes with Pango 1.50. > > > > thanks a lot, I added a copyright line for you and pushed. > > > Thank you! (I often forget the copyright line, so thanks for that as well.) > > > Wine still fails to build due to autogen not building on i686: > > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../autoopts > > -DPKGDATADIR=\"/gnu/store/6i60j0fxdsg4qwymas4ymfqlv1azidnc-autogen-5.18.16/share/autogen\" > > -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -Wall -Werror > > -Wcast-align -Wmissing-prototypes -Wpointer-arith -Wshadow > > -Wstrict-prototypes -Wwrite-strings -Wstrict-aliasing=3 -Wextra > > -Wno-cast-qual -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -c > > libopts.c -fPIC -DPIC -o .libs/libopts_la-libopts.o > > In file included from libopts.c:48: > > usage.c: In function ‘prt_extd_usage.isra’: > > usage.c:736:38: error: ‘s ’ directive output may be truncated writing 2 > > bytes into a region of size between 0 and 9 [-Werror=format-truncation=] > > 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); > > | ^~~ > > usage.c:736:9: note: ‘snprintf’ output between 9 and 18 bytes into a > > destination of size 12 > > 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); > > | ^~ > > > > Just in case you wish to continue investigating :) > > > I probably will. :) My goal has been to build my home and system profiles > from core-updates, including wine64-staging. I just mailed https://issues.guix.gnu.org/62758 to add a snippet to fix the build error. I used a similar approach as the existing snippet for fixing a format overflow error. (I also forgot to set the subject prefix to "PATCH core-updates" on the git send-mail command line.). Cheers, Kaelyn
Re: Fix for librsvg 2.40 on core-updates
--- Original Message --- On Saturday, April 8th, 2023 at 9:52 AM, Andreas Enge wrote: > > > Hello, > > Am Fri, Apr 07, 2023 at 04:53:15PM + schrieb Kaelyn: > > > On core-updates, librsvg-2.40 fails to compile due to a single failing test > > (I've confirmed the failure on x86_64 and i686, though the package is only > > used/needed on non-x86_64 systems for gtk+ and others; it also affects wine > > and wine-staging on x86_64 as they are 32-bit packages). I was able to > > track down the test failure to a text rendering difference between Pango > > 1.48 and 1.50, which led to the text being one pixel line higher between > > the reference and output images. On Monday I submitted > > https://issues.guix.gnu.org/62646 which adds a phase to librsvg-2.40 to > > adjust the output Y coordinate of the SVG transformation matrix by one for > > the failing test so that it passes with Pango 1.50. > > > thanks a lot, I added a copyright line for you and pushed. Thank you! (I often forget the copyright line, so thanks for that as well.) > > Wine still fails to build due to autogen not building on i686: > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../autoopts > -DPKGDATADIR=\"/gnu/store/6i60j0fxdsg4qwymas4ymfqlv1azidnc-autogen-5.18.16/share/autogen\" > -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -Wall -Werror > -Wcast-align -Wmissing-prototypes -Wpointer-arith -Wshadow > -Wstrict-prototypes -Wwrite-strings -Wstrict-aliasing=3 -Wextra > -Wno-cast-qual -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -c > libopts.c -fPIC -DPIC -o .libs/libopts_la-libopts.o > In file included from libopts.c:48: > usage.c: In function ‘prt_extd_usage.isra’: > usage.c:736:38: error: ‘s ’ directive output may be truncated writing 2 bytes > into a region of size between 0 and 9 [-Werror=format-truncation=] > 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); > | ^~~ > usage.c:736:9: note: ‘snprintf’ output between 9 and 18 bytes into a > destination of size 12 > 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); > | ^~ > > Just in case you wish to continue investigating :) I probably will. :) My goal has been to build my home and system profiles from core-updates, including wine64-staging. Cheers, Kaelyn > > Andreas
Re: Fix for librsvg 2.40 on core-updates
Hello, Am Fri, Apr 07, 2023 at 04:53:15PM + schrieb Kaelyn: > On core-updates, librsvg-2.40 fails to compile due to a single failing test > (I've confirmed the failure on x86_64 and i686, though the package is only > used/needed on non-x86_64 systems for gtk+ and others; it also affects wine > and wine-staging on x86_64 as they are 32-bit packages). I was able to track > down the test failure to a text rendering difference between Pango 1.48 and > 1.50, which led to the text being one pixel line higher between the reference > and output images. On Monday I submitted https://issues.guix.gnu.org/62646 > which adds a phase to librsvg-2.40 to adjust the output Y coordinate of the > SVG transformation matrix by one for the failing test so that it passes with > Pango 1.50. thanks a lot, I added a copyright line for you and pushed. Wine still fails to build due to autogen not building on i686: libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../autoopts -DPKGDATADIR=\"/gnu/store/6i60j0fxdsg4qwymas4ymfqlv1azidnc-autogen-5.18.16/share/autogen\" -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -Wall -Werror -Wcast-align -Wmissing-prototypes -Wpointer-arith -Wshadow -Wstrict-prototypes -Wwrite-strings -Wstrict-aliasing=3 -Wextra -Wno-cast-qual -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -c libopts.c -fPIC -DPIC -o .libs/libopts_la-libopts.o In file included from libopts.c:48: usage.c: In function ‘prt_extd_usage.isra’: usage.c:736:38: error: ‘s ’ directive output may be truncated writing 2 bytes into a region of size between 0 and 9 [-Werror=format-truncation=] 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); | ^~~ usage.c:736:9: note: ‘snprintf’ output between 9 and 18 bytes into a destination of size 12 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); | ^~ Just in case you wish to continue investigating :) Andreas
Fix for librsvg 2.40 on core-updates
Hi, On core-updates, librsvg-2.40 fails to compile due to a single failing test (I've confirmed the failure on x86_64 and i686, though the package is only used/needed on non-x86_64 systems for gtk+ and others; it also affects wine and wine-staging on x86_64 as they are 32-bit packages). I was able to track down the test failure to a text rendering difference between Pango 1.48 and 1.50, which led to the text being one pixel line higher between the reference and output images. On Monday I submitted https://issues.guix.gnu.org/62646 which adds a phase to librsvg-2.40 to adjust the output Y coordinate of the SVG transformation matrix by one for the failing test so that it passes with Pango 1.50. Cheers, Kaelyn
