Re: [PATCH] Patchseries: perl-www-opensearch and dependencies.

2016-09-05 Thread Efraim Flashner 
On Thu, Aug 18, 2016 at 11:09:23AM +, ng0 wrote:
> Hi,
> 
> Eric Bavier  writes:
> 
> > On Sun, 14 Aug 2016 17:19:10 +
> > ng0  wrote:
> >
> >> This patch series adds perl-www-opensearch and the 13 patches leading to
> >> it (the dependencies).
> >
> > Thanks for all the patches!  Comments dispersed throughtout:
> >
> >> 
> [...]
> >
> > Otherwise LGTM!
> >
> > `~Eric
> 
> Thanks for reviewing. All the problems are addressed, and some
> additional changes to move comments when no test can be run are moved to
> save lines.
> 
> 
> -- 
> ng0
> For non-prism friendly talk find me on http://www.psyced.org

Patches pushed!


-- 
Efraim Flashner      אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted


signature.asc
Description: PGP signature

Re: [PATCH] Patchseries: perl-www-opensearch and dependencies.

2016-09-03 Thread ng0 
Hi,

should I send these patches in separate emails with git send-email for a
simpler review?

ng0  writes:

> Hi,
>
> Eric Bavier  writes:
>
>> On Sun, 14 Aug 2016 17:19:10 +
>> ng0  wrote:
>>
>>> This patch series adds perl-www-opensearch and the 13 patches leading to
>>> it (the dependencies).
>>
>> Thanks for all the patches!  Comments dispersed throughtout:
>>
>>> 
> [...]
>>
>> Otherwise LGTM!
>>
>> `~Eric
>
> Thanks for reviewing. All the problems are addressed, and some
> additional changes to move comments when no test can be run are moved to
> save lines.
>
> From 5f3065a36e27ddafdfd0c56b3b29838e0bf15228 Mon Sep 17 00:00:00 2001
> From: ng0 
> Date: Sun, 14 Aug 2016 12:42:12 +
> Subject: [PATCH 01/14] gnu: Add perl-uri-template.
>
> * gnu/packages/web.scm (perl-uri-template): New variable.
> ---
>  gnu/packages/web.scm | 24 
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 29055c3..986bfcc 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -2964,6 +2964,30 @@ URI::Find::Schemeless.  For a command-line interface, 
> urifind is provided.")
>  methods for WebSocket URIs as it does for HTTP URIs.")
>  (license (package-license perl
>  
> +(define-public perl-uri-template
> +  (package
> +(name "perl-uri-template")
> +(version "0.22")
> +(source (origin
> +  (method url-fetch)
> +  (uri (string-append 
> "mirror://cpan/authors/id/B/BR/BRICAS/URI-Template-"
> +  version ".tar.gz"))
> +  (sha256
> +   (base32
> +"08kjjb4c0v9gqfrfnj1wkivylxl05finn11ra64dj136fhmnyrbg"
> +(build-system perl-build-system)
> +(inputs
> + `(("perl-uri" ,perl-uri)))
> +(native-inputs
> + `(("perl-test-pod-coverage" ,perl-test-pod-coverage)
> +   ("perl-test-pod" ,perl-test-pod)
> +   ("perl-json" ,perl-json)))
> +(home-page "http://search.cpan.org/dist/URI-Template;)
> +(synopsis "Object for handling URI templates")
> +(description "This perl module provides a wrapper around URI templates 
> as described in
> +RFC 6570.")
> +(license (package-license perl
> +
>  (define-public perl-www-curl
>(package
>  (name "perl-www-curl")
> -- 
> 2.9.3
>
> From 97dd97c46ec0d77cab6df66595b60cacab5e4234 Mon Sep 17 00:00:00 2001
> From: ng0 
> Date: Sun, 14 Aug 2016 13:02:00 +
> Subject: [PATCH 02/14] gnu: Add perl-class-errorhandler.
>
> * gnu/packages/perl.scm (perl-class-errorhandler): New variable.
> ---
>  gnu/packages/perl.scm | 21 +
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index aef92f4..4e3d1fa 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -700,6 +700,27 @@ subclasses and can be overridden.")
>  type for perl.")
>  (license (package-license perl
>  
> +(define-public perl-class-errorhandler
> +  (package
> +(name "perl-class-errorhandler")
> +(version "0.04")
> +(source (origin
> +  (method url-fetch)
> +  (uri (string-append "mirror://cpan/authors/id/T/TO/TOKUHIROM/"
> +  "Class-ErrorHandler-" version ".tar.gz"))
> +  (sha256
> +   (base32
> +"00j5f0z4riyq7i95jww291dpmbn0hmmvkcbrh7p0p8lpqz7jsb9l"
> +(build-system perl-build-system)
> +(home-page "http://search.cpan.org/dist/Class-ErrorHandler;)
> +(synopsis "Base class for error handling")
> +(description
> + "@code{Class::ErrorHandler} provides an error-handling mechanism that 
> is generic
> +enough to be used as the base class for a variety of OO classes.  Subclasses 
> inherit
> +its two error-handling methods, error and errstr, to communicate error 
> messages back
> +to the calling program.")
> +(license (package-license perl
> +
>  (define-public perl-class-factory-util
>(package
>  (name "perl-class-factory-util")
> -- 
> 2.9.3
>
> From c32d61f5ee7be18c9c25bc02f17d1b7d404e4928 Mon Sep 17 00:00:00 2001
> From: ng0 
> Date: Sun, 14 Aug 2016 13:13:18 +
> Subject: [PATCH 03/14] gnu: Add perl-datetime-format-mail.
>
> * gnu/packages/perl.scm (perl-datetime-format-mail): New variable.
> ---
>  gnu/packages/perl.scm | 21 +
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index 4e3d1fa..db941fb 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -1792,6 +1792,27 @@ to create DateTime objects, with some custom tweaks to 
> smooth out the rough
>  edges (mainly concerning timezone detection and selection).")
>  (license (package-license perl
>  
> +(define-public

Re: [PATCH] Patchseries: perl-www-opensearch and dependencies.

2016-08-18 Thread ng0 
Hi,

Eric Bavier  writes:

> On Sun, 14 Aug 2016 17:19:10 +
> ng0  wrote:
>
>> This patch series adds perl-www-opensearch and the 13 patches leading to
>> it (the dependencies).
>
> Thanks for all the patches!  Comments dispersed throughtout:
>
>> 
[...]
>
> Otherwise LGTM!
>
> `~Eric

Thanks for reviewing. All the problems are addressed, and some
additional changes to move comments when no test can be run are moved to
save lines.

>From 5f3065a36e27ddafdfd0c56b3b29838e0bf15228 Mon Sep 17 00:00:00 2001
From: ng0 
Date: Sun, 14 Aug 2016 12:42:12 +
Subject: [PATCH 01/14] gnu: Add perl-uri-template.

* gnu/packages/web.scm (perl-uri-template): New variable.
---
 gnu/packages/web.scm | 24 
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 29055c3..986bfcc 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -2964,6 +2964,30 @@ URI::Find::Schemeless.  For a command-line interface, urifind is provided.")
 methods for WebSocket URIs as it does for HTTP URIs.")
 (license (package-license perl
 
+(define-public perl-uri-template
+  (package
+(name "perl-uri-template")
+(version "0.22")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "mirror://cpan/authors/id/B/BR/BRICAS/URI-Template-"
+  version ".tar.gz"))
+  (sha256
+   (base32
+"08kjjb4c0v9gqfrfnj1wkivylxl05finn11ra64dj136fhmnyrbg"
+(build-system perl-build-system)
+(inputs
+ `(("perl-uri" ,perl-uri)))
+(native-inputs
+ `(("perl-test-pod-coverage" ,perl-test-pod-coverage)
+   ("perl-test-pod" ,perl-test-pod)
+   ("perl-json" ,perl-json)))
+(home-page "http://search.cpan.org/dist/URI-Template;)
+(synopsis "Object for handling URI templates")
+(description "This perl module provides a wrapper around URI templates as described in
+RFC 6570.")
+(license (package-license perl
+
 (define-public perl-www-curl
   (package
 (name "perl-www-curl")
-- 
2.9.3

>From 97dd97c46ec0d77cab6df66595b60cacab5e4234 Mon Sep 17 00:00:00 2001
From: ng0 
Date: Sun, 14 Aug 2016 13:02:00 +
Subject: [PATCH 02/14] gnu: Add perl-class-errorhandler.

* gnu/packages/perl.scm (perl-class-errorhandler): New variable.
---
 gnu/packages/perl.scm | 21 +
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index aef92f4..4e3d1fa 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -700,6 +700,27 @@ subclasses and can be overridden.")
 type for perl.")
 (license (package-license perl
 
+(define-public perl-class-errorhandler
+  (package
+(name "perl-class-errorhandler")
+(version "0.04")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "mirror://cpan/authors/id/T/TO/TOKUHIROM/"
+  "Class-ErrorHandler-" version ".tar.gz"))
+  (sha256
+   (base32
+"00j5f0z4riyq7i95jww291dpmbn0hmmvkcbrh7p0p8lpqz7jsb9l"
+(build-system perl-build-system)
+(home-page "http://search.cpan.org/dist/Class-ErrorHandler;)
+(synopsis "Base class for error handling")
+(description
+ "@code{Class::ErrorHandler} provides an error-handling mechanism that is generic
+enough to be used as the base class for a variety of OO classes.  Subclasses inherit
+its two error-handling methods, error and errstr, to communicate error messages back
+to the calling program.")
+(license (package-license perl
+
 (define-public perl-class-factory-util
   (package
 (name "perl-class-factory-util")
-- 
2.9.3

>From c32d61f5ee7be18c9c25bc02f17d1b7d404e4928 Mon Sep 17 00:00:00 2001
From: ng0 
Date: Sun, 14 Aug 2016 13:13:18 +
Subject: [PATCH 03/14] gnu: Add perl-datetime-format-mail.

* gnu/packages/perl.scm (perl-datetime-format-mail): New variable.
---
 gnu/packages/perl.scm | 21 +
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 4e3d1fa..db941fb 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -1792,6 +1792,27 @@ to create DateTime objects, with some custom tweaks to smooth out the rough
 edges (mainly concerning timezone detection and selection).")
 (license (package-license perl
 
+(define-public perl-datetime-format-mail
+  (package
+(name "perl-datetime-format-mail")
+(version "0.403")
+(source (origin
+  (method url-fetch)
+  (uri (string-append "mirror://cpan/authors/id/B/BO/BOOK/"
+  "DateTime-Format-Mail-" version ".tar.gz"))
+  (sha256
+   (base32
+

Re: [PATCH] Patchseries: perl-www-opensearch and dependencies.

2016-08-15 Thread Eric Bavier 
On Sun, 14 Aug 2016 17:19:10 +
ng0  wrote:

> This patch series adds perl-www-opensearch and the 13 patches leading to
> it (the dependencies).

Thanks for all the patches!  Comments dispersed throughtout:

> 
> 
> From 32adba9d07c73aee701861817b530a8a54ce065d Mon Sep 17 00:00:00 2001
> From: ng0 
> Date: Sun, 14 Aug 2016 12:42:12 +
> Subject: [PATCH 02/15] gnu: Add perl-uri-template.
> 
> * gnu/packages/web.scm (perl-uri-template): New variable.
> ---
>  gnu/packages/web.scm | 24 
>  1 file changed, 24 insertions(+)
> 
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 9106295..d596d83 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -2959,6 +2959,30 @@ URI::Find::Schemeless.  For a command-line interface, 
> urifind is provided.")
>  methods for WebSocket URIs as it does for HTTP URIs.")
>  (license (package-license perl
>  
> +(define-public perl-uri-template
> +  (package
> +(name "perl-uri-template")
> +(version "0.22")
> +(source (origin
> +  (method url-fetch)
> +  (uri (string-append 
> "mirror://cpan/authors/id/B/BR/BRICAS/URI-Template-"
> +  version ".tar.gz"))
> +  (sha256
> +   (base32
> +"08kjjb4c0v9gqfrfnj1wkivylxl05finn11ra64dj136fhmnyrbg"
> +(build-system perl-build-system)
> +(inputs
> + `(("perl-uri" ,perl-uri)))
> +(native-inputs
> + `(("perl-test-pod-coverage" ,perl-test-pod-coverage)
> +   ("perl-test-pod" ,perl-test-pod)
> +   ("perl-json" ,perl-json)))
> +(home-page "http://search.cpan.org/dist/URI-Template;)
> +(synopsis "Object for handling URI templates (RFC 6570)")

I would leave mention of the RFC out of the synopsis.

> +(description "This perl module provides a wrapper around URI templates 
> as described in
> +RFC 6570.")
> +(license (package-license perl
> +
>  (define-public perl-www-curl
>(package
>  (name "perl-www-curl")
> -- 
> 2.9.2
> 
> 
> From 57880ce0893fbdd1107225b0a119aa0193ecbfc3 Mon Sep 17 00:00:00 2001
> From: ng0 
> Date: Sun, 14 Aug 2016 13:02:00 +
> Subject: [PATCH 03/15] gnu: Add perl-class-errorhandler.
> 
> * gnu/packages/perl.scm (perl-class-errorhandler): New variable.
> ---
>  gnu/packages/perl.scm | 21 +
>  1 file changed, 21 insertions(+)
> 
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index aef92f4..ee49f16 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -700,6 +700,27 @@ subclasses and can be overridden.")
>  type for perl.")
>  (license (package-license perl
>  
> +(define-public perl-class-errorhandler
> +  (package
> +(name "perl-class-errorhandler")
> +(version "0.04")
> +(source (origin
> +  (method url-fetch)
> +  (uri (string-append "mirror://cpan/authors/id/T/TO/TOKUHIROM/"
> +  "Class-ErrorHandler-" version ".tar.gz"))
> +  (sha256
> +   (base32
> +"00j5f0z4riyq7i95jww291dpmbn0hmmvkcbrh7p0p8lpqz7jsb9l"
> +(build-system perl-build-system)
> +(home-page "http://search.cpan.org/dist/Class-ErrorHandler;)
> +(synopsis "Base class for error handling")
> +(description
> + "Class::ErrorHandler provides an error-handling mechanism that is 
> generic enough
 ^
Wrap class names in texinfo "@code{...}", everywhere.

> +to be used as the base class for a variety of OO classes.  Subclasses 
> inherit its
> +two error-handling methods, error and errstr, to communicate error messages 
> back
> +to the calling program.")
> +(license (package-license perl
> +
>  (define-public perl-class-factory-util
>(package
>  (name "perl-class-factory-util")
> -- 
> 2.9.2
> 
[...]
> 
> From 30ecbeb69e87140d2d11deb86b06126e69100f11 Mon Sep 17 00:00:00 2001
> From: ng0 
> Date: Sun, 14 Aug 2016 13:55:21 +
> Subject: [PATCH 07/15] gnu: Add perl-uri-fetch.
> 
> * gnu/packages/web.scm (perl-uri-fetch): New variable.
> ---
>  gnu/packages/web.scm | 25 +
>  1 file changed, 25 insertions(+)
> 
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 5970df5..38ca8ff 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -2940,6 +2940,31 @@ represent \"Uniform Resource Identifier references\" 
> as specified in RFC 2396
>  and updated by RFC 2732.")
>  (home-page "http://search.cpan.org/dist/URI/;)))
>  
> +(define-public perl-uri-fetch
> +  (package
> +(name "perl-uri-fetch")
> +(version "0.13")
> +(source (origin
> +  (method url-fetch)
> +  (uri (string-append "mirror://cpan/authors/id/N/NE/NEILB/"
> +  "URI-Fetch-" version ".tar.gz"))
> +  (sha256
> +