Re: [PATCH] Update entr to 3.6
On Thu, Sep 08, 2016 at 05:28:06AM -0400, Matthew Jordan wrote: > Good Day, > > Sorry for late reply been a bit busy with work. About this package, do > I still need to send seperate patches for the move and the update or has > this patch already been applied? > > Thanks, > Matthew. > > The update to 3.6 has been applied separately, moving it to shells.scm has not. -- Efraim Flashner אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted signature.asc Description: PGP signature
Re: [PATCH] Update entr to 3.6
Good Day, Sorry for late reply been a bit busy with work. About this package, do I still need to send seperate patches for the move and the update or has this patch already been applied? Thanks, Matthew. Efraim Flashner writes: > On Sun, Aug 21, 2016 at 12:18:15PM -0400, Matthew Jordan wrote: >> Good Day, >> >> This patch moves entr to the shellutils file. And updates the version. >> > > This looks good, but it should be two patches, one to update entr and a > second to move it to shellutils.scm. Can you send an updated patch? > > Thanks.
Re: [PATCH] Update entr to 3.6
On Sun, Aug 21, 2016 at 12:18:15PM -0400, Matthew Jordan wrote: > Good Day, > > This patch moves entr to the shellutils file. And updates the version. > > From 4cae2720568bab62785bd48ae0536a49eafabb81 Mon Sep 17 00:00:00 2001 > From: "Matthew O'N.S Jordan" > Date: Sat, 20 Aug 2016 11:32:25 -0400 > Subject: [PATCH] gnu: Modify entr > > * gnu/packages/shellutils.scm (entr): Updated package version. > * gnu/packages/entr.scm (entr): Removed file. > --- > gnu/local.mk| 1 - > gnu/packages/entr.scm | 66 > - > gnu/packages/shellutils.scm | 43 + I took the update part of this patch and applied it alone. Moving packages around has some drawbacks. Notably, users will have to adjust their module imports anywhere they use the affected packages. Also, these changes tend to create annoying merge conflicts between the master branch and any *-updates branches we may be using. Thanks for paying attention to this package!
Re: [PATCH] Update entr to 3.6
On Sun, Aug 21, 2016 at 12:18:15PM -0400, Matthew Jordan wrote: > Good Day, > > This patch moves entr to the shellutils file. And updates the version. > This looks good, but it should be two patches, one to update entr and a second to move it to shellutils.scm. Can you send an updated patch? Thanks. -- Efraim Flashner אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted signature.asc Description: PGP signature
