Re: [PATCH] gnu: Add Prosody service.

[Clément Lassieur]

> I would suggest moving the gnu/packages change to a separate patch, but
> apart from that I don’t have anything to add to Hartmut’s comment.
>
> Could you send updated patches?

Here they are.

> I suppose you confirmed with ‘guix system vm’ or similar that it works
> as intended.  Could you consider writing a system test for Prosody?  The
> (gnu tests mail) and (gnu tests ssh) modules provide relatively simple
> examples to start from.

It works on my GuixSD server.  I'll start to write a system test.

Thank you all for the review!

Re: [PATCH] gnu: Add Prosody service.

[Clément Lassieur]

>> Am 04.01.2017 um 22:55 schrieb Clément Lassieur:
>
>>> +;;; Commentary:
>>> +;;;
>>> +;;; Messaging services.
>>> +;;;
>>> +;;; Code:
>> […]
>>> +;;; messaging.scm ends here
>>
>> I'd leave this comment away. It is of now use. We had a loner discussion
>> about this here on the list in autum.
>
> ... which came to no real result, so these end comments are
> perfectly fine and up to the person who contributes the file
> first. So Clément, decide wether you want it or not.

I'll remove it then.

Re: [PATCH] gnu: Add Prosody service.

[Ludovic Courtès]

Hi Clément,

Clément Lassieur  skribis:

> * gnu/services/messaging.scm: New file.
> * gnu/services/configuration.scm: New exported procedures.
> * gnu/packages/messaging.scm (prosody)[arguments]: Add 'fix-makefile'
>   phase.
>   In 'wrap-programs' phase, add 'openssl' and 'coreutils' to 'PATH'.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add gnu/services/messaging.scm.
> * doc/guix.texi (Messaging Services): New section.

Great work!

I would suggest moving the gnu/packages change to a separate patch, but
apart from that I don’t have anything to add to Hartmut’s comment.

Could you send updated patches?

I suppose you confirmed with ‘guix system vm’ or similar that it works
as intended.  Could you consider writing a system test for Prosody?  The
(gnu tests mail) and (gnu tests ssh) modules provide relatively simple
examples to start from.

Thank you!

Ludo’.

Re: [PATCH] gnu: Add Prosody service.

[Clément Lassieur]

> Am 04.01.2017 um 22:55 schrieb Clément Lassieur:
>> +(define %default-modules-enabled
>> +  '("roster"
>> +"saslauth"
>> +"tls"
>> +"dialback"
>> +"disco"
>> +"private"
>> +"vcard"
>> +"version"
>> +"uptime"
>> +"time"
>> +"ping"
>> +"pep"
>> +"register"
>> +"admin_adhoc"))
>
> I suggest adding omemo (axelotl encryption) here, since this is one of
> the most important new features for XMPP.

Omemo only depends on PEP, which is enabled by default. So it should
work.

>> + "Multi-user chat (MUC) is Prosody's module for allowing you to create
>> +hosted chatrooms/conferences for XMPP users.
>> +
>> +General information on setting up and using MUC chatrooms can be found in 
>> our
>> +\"Chatrooms\" documentation (@url{http://prosody.im/doc/chatrooms}), which 
>> you
>> +should read if you are new to XMPP chatrooms.
>
> s/MUC chatrooms/ multi-user chatrooms/
> s/our/the/

Ok.

Re: [PATCH] gnu: Add Prosody service.

[ng0]

Hartmut Goebel  writes:

> Hi,
>
> Thanks for this service :-)
>
> Am 04.01.2017 um 22:55 schrieb Clément Lassieur:

>> +;;; Commentary:
>> +;;;
>> +;;; Messaging services.
>> +;;;
>> +;;; Code:
> […]
>> +;;; messaging.scm ends here
>
> I'd leave this comment away. It is of now use. We had a loner discussion
> about this here on the list in autum.

... which came to no real result, so these end comments are
perfectly fine and up to the person who contributes the file
first. So Clément, decide wether you want it or not.

Thanks for being faster than myself in creating this service
module. I'll just wait with psyced-service until this is in
master.

> -- 
> Regards
> Hartmut Goebel
>
> | Hartmut Goebel  | h.goe...@crazy-compilers.com   |
> | www.crazy-compilers.com | compilers which you thought are impossible |
>
>
>

-- 
♥Ⓐ  ng0
PGP keys and more: https://n0is.noblogs.org/ http://ng0.chaosnet.org

Re: [PATCH] gnu: Add Prosody service.

[Hartmut Goebel]

Hi,

Thanks for this service :-)

Am 04.01.2017 um 22:55 schrieb Clément Lassieur:
> +(define %default-modules-enabled
> +  '("roster"
> +"saslauth"
> +"tls"
> +"dialback"
> +"disco"
> +"private"
> +"vcard"
> +"version"
> +"uptime"
> +"time"
> +"ping"
> +"pep"
> +"register"
> +"admin_adhoc"))

I suggest adding omemo (axelotl encryption) here, since this is one of
the most important new features for XMPP.

> + "Multi-user chat (MUC) is Prosody's module for allowing you to create
> +hosted chatrooms/conferences for XMPP users.
> +
> +General information on setting up and using MUC chatrooms can be found in our
> +\"Chatrooms\" documentation (@url{http://prosody.im/doc/chatrooms}), which 
> you
> +should read if you are new to XMPP chatrooms.

s/MUC chatrooms/ multi-user chatrooms/
s/our/the/

> +;;; Commentary:
> +;;;
> +;;; Messaging services.
> +;;;
> +;;; Code:
[…]
> +;;; messaging.scm ends here

I'd leave this comment away. It is of now use. We had a loner discussion
about this here on the list in autum.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel  | h.goe...@crazy-compilers.com   |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: [PATCH] gnu: Add prosody service

[Clément Lassieur]

> Which version of the patch should we review? :)

Oh...  I accidentally sent the patches with my professional address, but
it took a long time to get into the list, so I thought it did not work
and sent a second set of patches with my real address.

Please do not answer the mails sent with my professional address.

way1: http://lists.gnu.org/archive/html/guix-devel/2016-11/msg01074.html
way2: http://lists.gnu.org/archive/html/guix-devel/2016-11/msg01075.html

> If you are using `git format-patch` or `git send-email`, you can use
> --subject-prefix to version your patches.
>
> For example:
>
> $ git send-email --cover-letter -n --thread=shallow --subject-prefix=v2 master

Yes, next time I'll do this.  Sorry for the confusion.

Re: [PATCH] gnu: Add prosody service

[Leo Famulari]

On Sat, Nov 26, 2016 at 06:20:12PM +0100, Clément Lassieur wrote:
> From: Clément Lassieur 

Hi, thanks for working on this!

> 
> ---
>  gnu/local.mk   |   1 +
>  gnu/packages/messaging.scm |   3 +
>  gnu/services/messaging.scm | 787 
> +
>  3 files changed, 791 insertions(+)
>  create mode 100644 gnu/services/messaging.scm

Which version of the patch should we review? :)

If you are using `git format-patch` or `git send-email`, you can use
--subject-prefix to version your patches.

For example:

$ git send-email --cover-letter -n --thread=shallow --subject-prefix=v2 master