Re: [PATCH 0/1] GRUB: Use Parted in tests

2016-05-23 Thread Leo Famulari 
On Mon, May 23, 2016 at 11:29:00PM +0200, Ludovic Courtès wrote:
> Efraim Flashner  skribis:
> 
> > On Sun, May 22, 2016 at 07:28:36PM -0400, Leo Famulari wrote:
> >> Leo Famulari (1):
> >>   gnu: grub: Re-enable test.
> >> 
> >>  gnu/packages/grub.scm | 7 ++-
> >>  1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > It looks good to me
> 
> +1

Thanks for the reviews. Pushed as 7febe3a28.

Re: [PATCH 0/1] GRUB: Use Parted in tests

2016-05-23 Thread Ludovic Courtès 
Efraim Flashner  skribis:

> On Sun, May 22, 2016 at 07:28:36PM -0400, Leo Famulari wrote:
>> I noticed that we disable a test in GRUB's test suite because it
>> required Parted and (presumably) had not packaged it yet.
>> 
>> I added it to native-inputs and successfully built GRUB on x86_64 and
>> i686.
>> 
>> Leo Famulari (1):
>>   gnu: grub: Re-enable test.
>> 
>>  gnu/packages/grub.scm | 7 ++-
>>  1 file changed, 2 insertions(+), 5 deletions(-)
>> 
>> -- 
>> 2.8.2
>> 
>
> It looks good to me

+1

Thanks!

Ludo’.

Re: [PATCH 0/1] GRUB: Use Parted in tests

2016-05-23 Thread Efraim Flashner 
On Sun, May 22, 2016 at 07:28:36PM -0400, Leo Famulari wrote:
> I noticed that we disable a test in GRUB's test suite because it
> required Parted and (presumably) had not packaged it yet.
> 
> I added it to native-inputs and successfully built GRUB on x86_64 and
> i686.
> 
> Leo Famulari (1):
>   gnu: grub: Re-enable test.
> 
>  gnu/packages/grub.scm | 7 ++-
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> -- 
> 2.8.2
> 

It looks good to me

-- 
Efraim Flashner  אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted


signature.asc
Description: PGP signature