Re: [PATCH 0/5] Improve the pypi updater.

2016-07-25 Thread Ludovic Courtès
Cyril Roelandt  skribis:

> On 07/22/2016 11:22 PM, Ludovic Courtès wrote:
>> Neat!  So the test dependencies go to ‘inputs’ instead of
>> ‘propagated-inputs’, right?  That can definitely save time and avoid
>> errors.
>> 
>
> Indeed, the runtime dependencies are propagated inputs, and the test
> dependencies are native inputs. This is what we currently do when
> writing packages "by hand".

OK.

>> Is there an example package that illustrates this?
>
> Anything from OpenStack :-D

Like ‘guix import pypi hacking’ or other packages found in
openstack.scm, right?

Thanks,
Ludo’.



Re: [PATCH 0/5] Improve the pypi updater.

2016-07-23 Thread Cyril Roelandt
On 07/22/2016 11:22 PM, Ludovic Courtès wrote:
> Neat!  So the test dependencies go to ‘inputs’ instead of
> ‘propagated-inputs’, right?  That can definitely save time and avoid
> errors.
> 

Indeed, the runtime dependencies are propagated inputs, and the test
dependencies are native inputs. This is what we currently do when
writing packages "by hand".

> Is there an example package that illustrates this?

Anything from OpenStack :-D

Cyril.



Re: [PATCH 0/5] Improve the pypi updater.

2016-07-22 Thread Ludovic Courtès
Hello!

Cyril Roelandt  skribis:

> A couple of minor improvements, and a huge one: we should now be able to
> automatically compute the test requirements of our Python packages!

Neat!  So the test dependencies go to ‘inputs’ instead of
‘propagated-inputs’, right?  That can definitely save time and avoid
errors.

Is there an example package that illustrates this?

> * guix/import/pypi.scm (maybe-inputs): Pass INPUT-TYPE as a parameter.
> * guix/import/pypi.scm (make-pypi-sexp): Use this parameter.

Nitpick: no need to repeat the file name.

> * tests/pypi.scm ("pypi->guix-package", "pypi->guix-package, wheels"): Update
> accordingly.

LGTM!

Thanks,
Ludo’.



Re: [PATCH 0/5] Improve the pypi updater.

2016-07-17 Thread Hartmut Goebel
Am 16.07.2016 um 17:23 schrieb Cyril Roelandt:
> and a huge one: we should now be able to
> automatically compute the test requirements of our Python packages!
Could you please add some documentation to the manual, too? Thanks.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel  | h.goe...@crazy-compilers.com   |
| www.crazy-compilers.com | compilers which you thought are impossible |