Re: [PATCH 03/16] gnu: Add python-promise.

2016-09-11 Thread Efraim Flashner 
On Sun, Sep 11, 2016 at 09:41:10PM +0200, David Craven wrote:
> > +(define-public python2-promise
> > +  (let ((promise (package-with-python2
> > +   (strip-python2-variant python-promise
> > +(package (inherit promise)
> > +  (arguments (substitute-keyword-arguments (package-arguments promise)
> > +   ((#:tests? _) #t)))
> 
> I've seen this in a few of your patches. Why do tests fail with python
> but not with python-2?

In this one the tests require python-futures, which is python2 only. I
tried adding python2-futures anyway to the native-inputs but
unsuprisingly it didn't help with the tests. The right fix is to have
upstream change it so that it says (something like)

tests:
  require:
"pytest" ,(version < '3' "futures");

but I need to read up more on my python syntax to suggest a patch.

-- 
Efraim Flashner      אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted


signature.asc
Description: PGP signature

Re: [PATCH 03/16] gnu: Add python-promise.

2016-09-11 Thread David Craven 
> +(define-public python2-promise
> +  (let ((promise (package-with-python2
> +   (strip-python2-variant python-promise
> +(package (inherit promise)
> +  (arguments (substitute-keyword-arguments (package-arguments promise)
> +   ((#:tests? _) #t)))

I've seen this in a few of your patches. Why do tests fail with python
but not with python-2?