Re: [PATCH 12/13] gnu: Add xmonad.

[Siniša Biđin]

On 2015-09-11 10:38, Eric Bavier wrote:

I've pushed a modified commit that generates the .desktop files for
xmonad, and adds the package instead to gnu/packages/wm.scm.


Great!


This Xmonad's mod-q does not work as expected, but that isn't a problem
if you like the default configuration ;).  Anyhow, some more work will
need to be done to support reconfiguration.  I had thought
GHC_PACKAGE_PATH would do what we need, but it doesn't seem to do what
I had thought.  Perhaps creating a custom package database for xmonad
to use would work.


I believe mod-q works fine for me with the following set:

profile=$HOME/.guix-profile
export GHC_PACKAGE_PATH=$profile/lib/ghc-7.8.4/package.conf.d/:

Note the trailing colon. (I haven't yet tried this out with the new
version you just pushed, so it's very possible this doesn't help.)

About creating custom package databases: my xmonad.hs imports packages
other than xmonad and xmonad-contrib, so my GHC_PACKAGE_PATH would in
that case still need to contain the $profile's package database.

Siniša

Re: [PATCH 12/13] gnu: Add xmonad.

[Eric Bavier]

On Mon, 31 Aug 2015 17:52:36 +0200
l...@gnu.org (Ludovic Courtès) wrote:

> Siniša Biđin  skribis:
> 
> > On 2015-08-23 22:47, Eric Bavier wrote:
> >> I had to replace "Exec=/etc/X11/Session/xmonad" with "Exec=xmonad"
> >> in this xmonad.desktop file in order to launch an xmonad session from
> >> Slim.  Does this seem right?
> >
> > Definitely!
> 
> [...]
> 
> >> Does it make sense to fetch this file
> >> from gentoo.org and then modify it? or should we rather just
> >> generate it
> >> ourselves?  What do you/others think?
> >
> > I had followed ratpoison's example (also using gentoo.org), but it does
> > feel dirty. I'm fine with generating it or having it stored in guix's
> > repo,
> > but couldn't find an example of any other package doing the same.
> 
> I think “generating” it (or having it as a string literal) in the source
> is preferable.
> 
> >>> +(propagated-inputs
> >>> + `(("ghc-mtl" ,ghc-mtl)
> >>> +   ("ghc-utf8-string" ,ghc-utf8-string)
> >>> +   ("ghc-extensible-exceptions" ,ghc-extensible-exceptions)
> >>> +   ("ghc-x11" ,ghc-x11)))
> >>
> >> Do these inputs need to be propagated?  I can start up an xmonad
> >> session without propagating these inputs.  Do they need to be available
> >> for xmonad's 'mod-q' (i.e. restarting xmonad/loading a new config)?
> >
> > I think so, yes. For one, since xmonad is an executable and a library,
> > if
> > we don't propagate, "ghc-pkg list" will report it as broken.
> 
> Makes sense to me.
> 
> Could you post an updated patch that addresses these two things?

I've pushed a modified commit that generates the .desktop files for
xmonad, and adds the package instead to gnu/packages/wm.scm.

This Xmonad's mod-q does not work as expected, but that isn't a problem
if you like the default configuration ;).  Anyhow, some more work will
need to be done to support reconfiguration.  I had thought
GHC_PACKAGE_PATH would do what we need, but it doesn't seem to do what
I had thought.  Perhaps creating a custom package database for xmonad
to use would work.

Thanks again for the patch, and sorry for the delay in getting it
pushed!
`~Eric

Re: [PATCH 12/13] gnu: Add xmonad.

[Eric Bavier]

On Mon, 31 Aug 2015 17:52:36 +0200
l...@gnu.org (Ludovic Courtès) wrote:

> Siniša Biđin  skribis:
> 
> > On 2015-08-23 22:47, Eric Bavier wrote:
> >> I had to replace "Exec=/etc/X11/Session/xmonad" with "Exec=xmonad"
> >> in this xmonad.desktop file in order to launch an xmonad session from
> >> Slim.  Does this seem right?
> >
> > Definitely!
> 
> [...]
> 
> >> Does it make sense to fetch this file
> >> from gentoo.org and then modify it? or should we rather just
> >> generate it
> >> ourselves?  What do you/others think?
> >
> > I had followed ratpoison's example (also using gentoo.org), but it does
> > feel dirty. I'm fine with generating it or having it stored in guix's
> > repo,
> > but couldn't find an example of any other package doing the same.
> 
> I think “generating” it (or having it as a string literal) in the source
> is preferable.
> 
> >>> +(propagated-inputs
> >>> + `(("ghc-mtl" ,ghc-mtl)
> >>> +   ("ghc-utf8-string" ,ghc-utf8-string)
> >>> +   ("ghc-extensible-exceptions" ,ghc-extensible-exceptions)
> >>> +   ("ghc-x11" ,ghc-x11)))
> >>
> >> Do these inputs need to be propagated?  I can start up an xmonad
> >> session without propagating these inputs.  Do they need to be available
> >> for xmonad's 'mod-q' (i.e. restarting xmonad/loading a new config)?
> >
> > I think so, yes. For one, since xmonad is an executable and a library,
> > if
> > we don't propagate, "ghc-pkg list" will report it as broken.
> 
> Makes sense to me.
> 
> Could you post an updated patch that addresses these two things?

BTW, attached is the current state of the patch that I have.  It
addresses the first item here (installing the xsession file).

For the second, I was toying with the idea of wrapping the xmonad
executable to provide both the ghc binary and the needed modules
(transitive propagated inputs, similar in style to what's done with
git-email currently, and for which I have an outstanding patch).  The
intent, IMO, would be to support xmonad's "reconfiguration".  I've not
used xmonad much before, but this appears to involve basically a
rebuild of the xmonad binary.  I'm not sure that just propagating the
input modules would be enough to support this.  It's also somewhat
unfortunate that the build would happen in a relatively polluted
environment.  Anyhow, sharing my current patch in case anyone else
wanted to play with it.

`~Eric

From c916b7849d0b866c64258443fea1909e4785d961 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sini=C5=A1a=20Bi=C4=91in?= 
Date: Tue, 18 Aug 2015 22:40:14 +0200
Subject: [PATCH 1/2] gnu: Add xmonad.

* gnu/packages/xmonad.scm (xmonad): New variable.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Signed-off-by: Eric Bavier 
---
 gnu-system.am   |  1 +
 gnu/packages/xmonad.scm | 94 +
 2 files changed, 95 insertions(+)
 create mode 100644 gnu/packages/xmonad.scm

diff --git a/gnu-system.am b/gnu-system.am
index 130ae36..4c34da3 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -330,6 +330,7 @@ GNU_SYSTEM_MODULES =\
   gnu/packages/xfig.scm\
   gnu/packages/xiph.scm\
   gnu/packages/xml.scm\
+  gnu/packages/xmonad.scm			\
   gnu/packages/xnee.scm\
   gnu/packages/xdisorg.scm			\
   gnu/packages/xorg.scm\
diff --git a/gnu/packages/xmonad.scm b/gnu/packages/xmonad.scm
new file mode 100644
index 000..01828c9
--- /dev/null
+++ b/gnu/packages/xmonad.scm
@@ -0,0 +1,94 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Siniša Biđin 
+;;; Copyright © 2015 Eric Bavier 
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see .
+
+(define-module (gnu packages xmonad)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix licenses)
+  #:use-module (guix build-system haskell)
+  #:use-module (gnu packages haskell))
+
+(define-public xmonad
+  (package
+(name "xmonad")
+(version "0.11.1")
+(source
+ (origin
+   (method url-fetch)
+   (uri (string-append
+ "http://hackage.haskell.org/package/xmonad/xmonad-;
+ version
+ ".tar.gz"))
+   (sha256
+(base32 "1pfjssamiwpwjp1qqkm9m9p9s35pv381m0cwg6jxg0ppglibzq1r"
+(build-system 

Re: [PATCH 12/13] gnu: Add xmonad.

[Ludovic Courtès]

Siniša Biđin  skribis:

> On 2015-08-23 22:47, Eric Bavier wrote:
>> I had to replace "Exec=/etc/X11/Session/xmonad" with "Exec=xmonad"
>> in this xmonad.desktop file in order to launch an xmonad session from
>> Slim.  Does this seem right?
>
> Definitely!

[...]

>> Does it make sense to fetch this file
>> from gentoo.org and then modify it? or should we rather just
>> generate it
>> ourselves?  What do you/others think?
>
> I had followed ratpoison's example (also using gentoo.org), but it does
> feel dirty. I'm fine with generating it or having it stored in guix's
> repo,
> but couldn't find an example of any other package doing the same.

I think “generating” it (or having it as a string literal) in the source
is preferable.

>>> +(propagated-inputs
>>> + `(("ghc-mtl" ,ghc-mtl)
>>> +   ("ghc-utf8-string" ,ghc-utf8-string)
>>> +   ("ghc-extensible-exceptions" ,ghc-extensible-exceptions)
>>> +   ("ghc-x11" ,ghc-x11)))
>>
>> Do these inputs need to be propagated?  I can start up an xmonad
>> session without propagating these inputs.  Do they need to be available
>> for xmonad's 'mod-q' (i.e. restarting xmonad/loading a new config)?
>
> I think so, yes. For one, since xmonad is an executable and a library,
> if
> we don't propagate, "ghc-pkg list" will report it as broken.

Makes sense to me.

Could you post an updated patch that addresses these two things?

TIA, and sorry for the delay!

Ludo’.

Re: [PATCH 12/13] gnu: Add xmonad.

[Eric Bavier]

On Tue, 18 Aug 2015 22:40:14 +0200
Siniša Biđin sin...@bidin.eu wrote:

 * gnu/packages/xmonad.scm (xmonad, xmonad.desktop): New variables.
 * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
 ---
  gnu-system.am   |  1 +
  gnu/packages/xmonad.scm | 78 
 +
  2 files changed, 79 insertions(+)
  create mode 100644 gnu/packages/xmonad.scm
[...]
 +(define xmonad.desktop
 +  (origin
 +(method url-fetch)
 +(uri (string-append
 +  https://sources.gentoo.org/cgi-bin/viewvc.cgi/;
 +  gentoo-x86/x11-wm/xmonad/files/xmonad.desktop?revision=1.3))
 +(file-name xmonad.desktop)
 +(sha256 (base32 
 0jx3pqv62hjz0nnfxml2b3qiw2nzslwnva466xh28k23mpissj6s

I had to replace Exec=/etc/X11/Session/xmonad with Exec=xmonad
in this xmonad.desktop file in order to launch an xmonad session from
Slim.  Does this seem right?  Does it make sense to fetch this file
from gentoo.org and then modify it? or should we rather just generate it
ourselves?  What do you/others think?

 +
 +(define-public xmonad
 +  (package
 +(name xmonad)
 +(version 0.11.1)
 +(source
 +  (origin
 +(method url-fetch)
 +(uri (string-append
 +  http://hackage.haskell.org/package/xmonad/xmonad-;
 +  version
 +  .tar.gz))
 +(sha256
 + (base32 1pfjssamiwpwjp1qqkm9m9p9s35pv381m0cwg6jxg0ppglibzq1r
 +(build-system haskell-build-system)
 +(arguments
 + '(#:phases
 +   (alist-cons-after
 +'install 'install-xsession
 +(lambda _
 +(let* ((file  (assoc-ref %build-inputs xmonad.desktop))
 +   (xsessions (string-append %output /share/xsessions))
 +   (target(string-append xsessions /xmonad.desktop)))
 +  (mkdir-p xsessions)
 +  (copy-file file target)))
 +%standard-phases)))
 +(inputs
 + `((xmonad.desktop ,xmonad.desktop)))
 +(propagated-inputs
 + `((ghc-mtl ,ghc-mtl)
 +   (ghc-utf8-string ,ghc-utf8-string)
 +   (ghc-extensible-exceptions ,ghc-extensible-exceptions)
 +   (ghc-x11 ,ghc-x11)))

Do these inputs need to be propagated?  I can start up an xmonad
session without propagating these inputs.  Do they need to be available
for xmonad's 'mod-q' (i.e. restarting xmonad/loading a new config)?

`~Eric

Re: [PATCH 12/13] gnu: Add xmonad.

[Siniša Biđin]

On 2015-08-23 22:47, Eric Bavier wrote:

I had to replace Exec=/etc/X11/Session/xmonad with Exec=xmonad
in this xmonad.desktop file in order to launch an xmonad session from
Slim.  Does this seem right?


Definitely!

I didn't test it thoroughly enough: I've been running xmonad via an
xsession file and managed to accidentally avoid the issue.


Does it make sense to fetch this file
from gentoo.org and then modify it? or should we rather just generate 
it

ourselves?  What do you/others think?


I had followed ratpoison's example (also using gentoo.org), but it does
feel dirty. I'm fine with generating it or having it stored in guix's 
repo,

but couldn't find an example of any other package doing the same.


+(propagated-inputs
+ `((ghc-mtl ,ghc-mtl)
+   (ghc-utf8-string ,ghc-utf8-string)
+   (ghc-extensible-exceptions ,ghc-extensible-exceptions)
+   (ghc-x11 ,ghc-x11)))


Do these inputs need to be propagated?  I can start up an xmonad
session without propagating these inputs.  Do they need to be available
for xmonad's 'mod-q' (i.e. restarting xmonad/loading a new config)?


I think so, yes. For one, since xmonad is an executable and a library, 
if

we don't propagate, ghc-pkg list will report it as broken. Manually
calling ghc --make on xmonad.hs (or other modules using XMonad) will
fail, and I'm assuming mod-q will also (but I confess I haven't tested:
I felt avoiding a broken package in ghc's package database was enough of
a reason for propagating the dependencies).

Siniša