Re: [PATCH 4/6] gnu: Add python-pycosat

2017-02-09 Thread Marius Bakke
Muriithi Frederick Muriuki  writes:

> * gnu/packages/python.scm (python-pycosat): New variable.

Applied! This software bundles the "picosat" C program, so I added a
TODO note for removing it (we try to unbundle software and use Guix
versions wherever feasible).

> ---
>  gnu/packages/python.scm | 21 +
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 9e17caf..e9df67c 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -12604,3 +12604,24 @@ faster ones are not available.")
>  (description "DDT (Data-Driven Tests) allows you to multiply one test 
> case by running
>   it with different test data, and make it appear as multiple test cases.")
>  (license license:expat)))
> +
> +(define-public python-pycosat
> +  (package
> +(name "python-pycosat")
> +(version "0.6.1")
> +(source
> + (origin
> +   (method url-fetch)
> +   (uri (pypi-uri "pycosat" version))
> +   (sha256
> +(base32
> + "1kl3wh1f47rc712n4bmwplbx3fqz3x9i1b587jrbpmvdva4c8f6l"
> +(build-system python-build-system)
> +(home-page
> + "https://github.com/ContinuumIO/pycosat";)
> +(synopsis "Bindings to picosat (a SAT solver)")
> +(description
> + "This package provides efficient Python bindings to @code{picosat} on 
> the C level,
> + i.e. when importing pycosat, the @code{picosat} solver becomes part of the 
> Python process
> + itself.  @code{picosat} is a Boolean Satisfiability Problem (SAT) solver")
> +(license license:expat)))
> -- 
> 2.10.2


signature.asc
Description: PGP signature


Re: [PATCH 4/6] gnu: Add python-pycosat

2017-02-09 Thread Frederick Muriithi
On Thu, Feb 9, 2017 at 1:35 AM, Marius Bakke  wrote:
>
> Does this package not need "picosat" as input? Or is it bundled?
>

I used `./pre-inst-env guix environment guix --pure -- ./pre-inst-env
guix build --rounds=3 python-pycosat` to build the package, and it
built successfully without requiring picosat as an input, and hence I
submitted the patch as it was.
I will fix the remaining issues and resubmit the patch


-- 
Frederick M. Muriithi



Re: [PATCH 4/6] gnu: Add python-pycosat

2017-02-08 Thread Marius Bakke
Muriithi Frederick Muriuki  writes:

> * gnu/packages/python.scm (python-pycosat): New variable.
> ---
>  gnu/packages/python.scm | 20 
>  1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 44704b2..170107a 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -12605,3 +12605,23 @@ faster ones are not available.")
>   it with different test data, and make it appear as multiple test cases")
>  (license (license:non-copyleft
>"https://github.com/txels/ddt/blob/master/LICENSE.md";
> +
> +(define-public python-pycosat
> +  (package
> +(name "python-pycosat")
> +(version "0.6.1")
> +(source
> + (origin
> +   (method url-fetch)
> +   (uri (pypi-uri "pycosat" version))
> +   (sha256
> +(base32
> + "1kl3wh1f47rc712n4bmwplbx3fqz3x9i1b587jrbpmvdva4c8f6l"
> +(build-system python-build-system)
> +(home-page
> + "https://github.com/ContinuumIO/pycosat";)
> +(synopsis "Bindings to picosat (a SAT solver)")
> +(description
> + "This package provides efficient Python bindings to picosat on the C 
> level, i.e.
> + when importing pycosat, the picosat solver becomes part of the Python 
> process itself")

Does this package not need "picosat" as input? Or is it bundled?

Please also use @code{picosat} here, and preferably an explanation of
the SAT acronym :)

> +(license license:expat)))
> -- 
> 2.1.4


signature.asc
Description: PGP signature