Re: [PATCH 4/8] gnu: Add viewnior.

[Ludovic Courtès]

Marius Bakke  skribis:

> Alex Kost  writes:
>
>> Efraim Flashner (2016-11-21 23:00 +0200) wrote:
>>
>>> * gnu/packages/viewnior.scm (viewnior): New file.
>>
>> Not related to this patch: I think we should find a place for the image
>> viewers, as currently we have feh, sxiv and geeqie (plus this
>> 'viewnior') that are placed in their own files.
>
> I think image.scm should do fine for these.

That could work.  Or, alternately, image-viewers.scm (image.scm already
contains 28 packages, which makes it the 28th file in number of packages
per M-x guix-locations.)

Ludo’.

Re: [PATCH 4/8] gnu: Add viewnior.

[Marius Bakke]

Alex Kost  writes:

> Efraim Flashner (2016-11-21 23:00 +0200) wrote:
>
>> * gnu/packages/viewnior.scm (viewnior): New file.
>
> Not related to this patch: I think we should find a place for the image
> viewers, as currently we have feh, sxiv and geeqie (plus this
> 'viewnior') that are placed in their own files.

I think image.scm should do fine for these.


signature.asc
Description: PGP signature

Re: [PATCH 4/8] gnu: Add viewnior.

[Alex Kost]

Efraim Flashner (2016-11-21 23:00 +0200) wrote:

> * gnu/packages/viewnior.scm (viewnior): New file.

Not related to this patch: I think we should find a place for the image
viewers, as currently we have feh, sxiv and geeqie (plus this
'viewnior') that are placed in their own files.

As for the patch, it looks good to me; I didn't know about this viewer,
thanks!

> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> ---
>  gnu/local.mk  |  1 +
>  gnu/packages/viewnior.scm | 78 
> +++
>  2 files changed, 79 insertions(+)
>  create mode 100644 gnu/packages/viewnior.scm
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 430d05f..43a3991 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -372,6 +372,7 @@ GNU_SYSTEM_MODULES =  \
>%D%/packages/valgrind.scm  \
>%D%/packages/version-control.scm   \
>%D%/packages/video.scm \
> +  %D%/packages/viewnior.scm  \
>%D%/packages/vim.scm   \
>%D%/packages/vpn.scm   \
>%D%/packages/vtk.scm   \
> diff --git a/gnu/packages/viewnior.scm b/gnu/packages/viewnior.scm
> new file mode 100644
> index 000..526d51a
> --- /dev/null
> +++ b/gnu/packages/viewnior.scm
> @@ -0,0 +1,78 @@
> +;;; Copyright © 2016 Efraim Flashner 
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see .
> +
> +(define-module (gnu packages viewnior)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix download)
> +  #:use-module (guix packages)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages base)
> +  #:use-module (gnu packages geeqie)
> +  #:use-module (gnu packages glib)
> +  #:use-module (gnu packages gnome)
> +  #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages pkg-config))
> +
> +(define-public viewnior
> +  (package
> +(name "viewnior")
> +(version "1.6")
> +(source
> +  (origin
> +(method url-fetch)
> +(uri (string-append "https://github.com/xsisqox/Viewnior/archive/";
> +name "-" version ".tar.gz"))
> +(sha256
> + (base32
> +  "18309qjgwak3kn228z3p3nx7yxasqgzx69v3rgc23hf161nky0c9"
> +(build-system gnu-build-system)
> +(arguments
> + '(#:phases
> +   (modify-phases %standard-phases
> + (add-after 'unpack 'autogen
> +   (lambda _
> + (zero? (system* "sh" "autogen.sh")))
> +(native-inputs
> + `(("automake" ,automake)
> +   ("autoconf" ,autoconf)
> +   ("intltool" ,intltool)
> +   ("glib" ,glib "bin") ; glib-genmarshal
> +   ("gnome-common" ,gnome-common)
> +   ("libtool" ,libtool)
> +   ("pkg-config" ,pkg-config)
> +   ("shared-mime-info" ,shared-mime-info)
> +   ("which" ,which)))
> +(inputs
> + `(("exiv2" ,exiv2)
> +   ("gdk-pixbuf" ,gdk-pixbuf)
> +   ("gtk+-2" ,gtk+-2)))
> +(home-page "http://siyanpanayotov.com/project/viewnior/";)
> +(synopsis "Simple, fast and elegant image viewer")
> +(description "Viewnior is an image viewer program.  Created to be simple,
> +fast and elegant.  Its minimalistic interface provides more screenspace for
> +your images.  Among its features are:
> +@enumerate
> +@item Fullscreen & Slideshow
> +@item Rotate, flip, crop, save, delete images
> +@item Animation support
> +@item Browse only selected images
> +@item Navigation window
> +@item Set image as wallpaper (Gnome 2, Gnome 3, XFCE, LXDE, FluxBox, 
> Nitrogen)
> +@item Simple interface
> +@item EXIF and IPTC metadata
> +@item Configurable mouse actions
> +@end enumerate\n")
> +(license license:gpl3+)))

-- 
Alex