Re: [PATCH v4] gnu: emacs: Update to 27.1.
Hi Pierre, thank you for working on this! Pierre Neidhardt writes: > Looks like an upstream issue: > > https://github.com/Wilfred/helpful/issues/248 This thread is getting hard to follow, should we open a specific bug on bug-guix? WDYT? -- Giovanni Biscuolo Xelera IT Infrastructures signature.asc Description: PGP signature
Re: [PATCH v4] gnu: emacs: Update to 27.1.
Looks like an upstream issue: https://github.com/Wilfred/helpful/issues/248 -- Pierre Neidhardt https://ambrevar.xyz/ signature.asc Description: PGP signature
Re: [PATCH v4] gnu: emacs: Update to 27.1.
emacs-helpful still seems to be broken on master. Any idea? I'll try to fix it later today. -- Pierre Neidhardt https://ambrevar.xyz/ signature.asc Description: PGP signature
Re: [PATCH v4] gnu: emacs: Update to 27.1.
Hi Morgan, Morgan Smith wrote: > It seems I am taking some credit for Jack Hill's patch. I simply took > Jack's patch (labeled as patch v3 in the debbugs thread) and attempted > to build it with my personal config. Indeed, I see that now. Sorry for the mistake. I suppose it happened because it was presented to me as "the patch Morgan submitted", but it would have been better if I had taken the time to read the bug report more carefully. Also, I regret if my comments on the preliminary patch made anyone feel badly. To be clear, there's no shame in submitting an unfinished patch for review. On the contrary, it is a *very* useful contribution. In this case, it makes sense to start by updating the main 'emacs' package, and to worry about the other variants later. There's no fault in that. The only fault here lies with me. I should have looked more carefully for prior work, and I probably also pushed it prematurely. > (Also just my 2 cents, we should have upgraded emacs-next to 27.1 and > only upgraded emacs a week later. Emacs deserves more care than most > packages due to its dependence on so many other packages. Not trying to > shame anyone, just something to think of for next time.) Agreed, or perhaps 'emacs' itself should have been updated on a separate branch. In the past, when this was a smaller community and there were far fewer emacs packages in Guix, I did major updates of Emacs a few times without causing any obvious problems, but that was a different time. It's also possible that Emacs 27 was a more disruptive update than usual. Thanks very much for your comments and contributions. Best regards, Mark
Re: [PATCH v4] gnu: emacs: Update to 27.1.
Mark H Weaver writes: [...] > Pierre Neidhardt wrote: >> I confirm that with Mark's commit >> emacs-clojure-mode I've filed bug#43090 with a trivial patch for emacs-clojure-mode, no need to revert Emacs 27.1 for this bug IMHO. > and emacs-elisp-refs are also broken. is there a specific bug report for this plz? there is also bug#43093 for emacs-ess can we coordinate our efforts in order to avoid to revert emacs 27.1 by tagging relevant [1] open emacs packages bugs as critical? [2] [...] Thanks! Gio' [1] can we define "relevant" as: all bugs that breaks a previously compiling emacs package? [2] https://issues.guix.gnu.org/search?query=subject%3Aemacs+is%3Aopen+severity%3Acritical -- Giovanni Biscuolo Xelera IT Infrastructures signature.asc Description: PGP signature
Re: [PATCH v4] gnu: emacs: Update to 27.1.
Hello!
It seems I am taking some credit for Jack Hill's patch. I simply took
Jack's patch (labeled as patch v3 in the debbugs thread) and attempted
to build it with my personal config. I noticed that it wouldn't build
properly since emacs wanted libxaw and emacs-no-x wanted some image
librarys (libtiff, libjpeg, etc). The only contributions I made, where
to add libxaw to emacs and to add the configure flags to emacs-no-x. I
made these changes and posted them as patch v4. However, the patch Mark
committed does build for me so you can ignore my contributions (which
weren't well thought out to begin with).
The rest of your questions should be directed to Jack.
(Also just my 2 cents, we should have upgraded emacs-next to 27.1 and
only upgraded emacs a week later. Emacs deserves more care than most
packages due to its dependence on so many other packages. Not trying to
shame anyone, just something to think of for next time.)
Thanks,
Morgan
On 8/28/20 2:57 PM, Mark H Weaver wrote:
> Looking now, here are the main differences I see between our patches:
>
> * I found that I had to remove the 'restore-emacs-pdump' phase from most
> of the other emacs variants, namely the ones that use
> 'gnu-build-system', because otherwise the inherited
> 'restore-emacs-pdump' phase would fail. Morgan's patch seems not to
> consider most of the other emacs variants, and I'm not sure if they
> were tested. I briefly tested all of them except for 'guile-emacs'.
>
> * Morgan removed the snippet code that deletes "eshell/esh-groups.el",
> whereas I replaced it with a call to 'find-files' to remove it only if
> present, as the previous comment suggested. I'm not sure if this is
> still needed, though.
>
> * Morgan's patch adds "libxaw" to inputs and "texinfo" to native-inputs.
> What's the rationale for these?
>
> * I added 'pango' to the inputs, because the Emacs NEWS mentioned that
> Pango was used for font rendering when "--with-cairo" is used.
> However, it may be that "pango" finds its way into the build inputs
> without being explicitly mentioned.
>
> * Morgan removed 'libxft' from the inputs of 'emacs', whereas I didn't.
> This was an oversight on my part. However, if we remove it, it's
> possible that we might need to add it back to 'emacs-no-x-toolkit'.
> The references that I see to Pango in the Emacs code are within
> "#ifdef HAVE_GTK3".
>
> * In 'emacs-no-x', my patch removes the new graphical library inputs
> (cairo, pango, and harfbuzz) and the "--with-cairo" flag, whereas
> Morgan's patch leaves "cairo" and "harfbuzz" as inputs, and overwrites
> the inherited configure-flags to be precisely ("--with-jpeg=no"
> "--with-gif=no" "--with-tiff=no"), apparently discarding the inherited
> "--with-modules" and "--disable-build-details" flags.
>
> * Morgan made 'emacs-wide-int' into a deprecated package, whereas I
> thought that it might still be useful. My rationale was this: from a
> brief skim, it looks like '--with-wide-int' might make *immediate*
> integers wider, which for some applications might perform much better
> than the heap-allocated arbitrary-size integers supported by Emacs 27.
> However, I didn't look carefully at this.
>
> * I updated "emacs-exec-path.patch" and removed
> "emacs27-exec-path.patch", whereas Morgan's patch keeps both files and
> possibly leaves "emacs-exec-path.patch" orphaned.
>
> * I updated the patches to apply cleanly to Emacs 27, although this was
> not strictly needed.
>
> * I updated 'notmuch' in the previous commit to a version that builds
> successfully with Emacs 27.
>
> Pierre Neidhardt wrote:
>> I confirm that with Mark's commit
>> emacs-clojure-mode and emacs-elisp-refs are also broken.
>
> Sorry about that. If the Emacs 27 update breaks important packages, it
> might be that reverting it is the proper action. If the maintainers
> decide to do this, I would not object.
>
>Best regards,
>Mark
>
Re: [PATCH v4] gnu: emacs: Update to 27.1.
Hello Guix,
Ludovic Courtès wrote:
> morgan.j.sm...@outlook.com skribis:
>
>> From: Morgan Smith
>>
>> * gnu/packages/emacs.scm (emacs): Update to 27.1.
>> [arguments]: Add --with-cairo and --with-modules to #:configure-flags. Add
>> restore-emacs-pdump phase.
>> [inputs]: Add cairo, libxaw, jansson, gmp, and harfbuzz. Remove imagemagick
>> and libxft.
>> [native-inputs]: Add texlive.
>> (emacs-wide-int): Mark as deprecated package.
>> (emacs-no-x):
>> [arguments]: Add --with-jpeg=no --with-gif=no --with-tiff=no
>> to #:configure-flags.
>
> I see that Mark committed a similar patch just yesterday:
>
>
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=36a09d185343375a5cba370431870f9c4435d623
>
> I suppose Mark hadn’t seen the ongoing discussion.
Indeed, I hadn't. Gah, I'm terribly sorry about this. I had done some
quick web searches for preexisting work on this, but clearly they were
insufficient, and I've never subscribed to the patches list. In the
future, I'll know not to rely on web search engines for this.
> Mark, Morgan: could you see if there’s anything we’re missing from the
> patch Morgan submitted?
Looking now, here are the main differences I see between our patches:
* I found that I had to remove the 'restore-emacs-pdump' phase from most
of the other emacs variants, namely the ones that use
'gnu-build-system', because otherwise the inherited
'restore-emacs-pdump' phase would fail. Morgan's patch seems not to
consider most of the other emacs variants, and I'm not sure if they
were tested. I briefly tested all of them except for 'guile-emacs'.
* Morgan removed the snippet code that deletes "eshell/esh-groups.el",
whereas I replaced it with a call to 'find-files' to remove it only if
present, as the previous comment suggested. I'm not sure if this is
still needed, though.
* Morgan's patch adds "libxaw" to inputs and "texinfo" to native-inputs.
What's the rationale for these?
* I added 'pango' to the inputs, because the Emacs NEWS mentioned that
Pango was used for font rendering when "--with-cairo" is used.
However, it may be that "pango" finds its way into the build inputs
without being explicitly mentioned.
* Morgan removed 'libxft' from the inputs of 'emacs', whereas I didn't.
This was an oversight on my part. However, if we remove it, it's
possible that we might need to add it back to 'emacs-no-x-toolkit'.
The references that I see to Pango in the Emacs code are within
"#ifdef HAVE_GTK3".
* In 'emacs-no-x', my patch removes the new graphical library inputs
(cairo, pango, and harfbuzz) and the "--with-cairo" flag, whereas
Morgan's patch leaves "cairo" and "harfbuzz" as inputs, and overwrites
the inherited configure-flags to be precisely ("--with-jpeg=no"
"--with-gif=no" "--with-tiff=no"), apparently discarding the inherited
"--with-modules" and "--disable-build-details" flags.
* Morgan made 'emacs-wide-int' into a deprecated package, whereas I
thought that it might still be useful. My rationale was this: from a
brief skim, it looks like '--with-wide-int' might make *immediate*
integers wider, which for some applications might perform much better
than the heap-allocated arbitrary-size integers supported by Emacs 27.
However, I didn't look carefully at this.
* I updated "emacs-exec-path.patch" and removed
"emacs27-exec-path.patch", whereas Morgan's patch keeps both files and
possibly leaves "emacs-exec-path.patch" orphaned.
* I updated the patches to apply cleanly to Emacs 27, although this was
not strictly needed.
* I updated 'notmuch' in the previous commit to a version that builds
successfully with Emacs 27.
Pierre Neidhardt wrote:
> I confirm that with Mark's commit
> emacs-clojure-mode and emacs-elisp-refs are also broken.
Sorry about that. If the Emacs 27 update breaks important packages, it
might be that reverting it is the proper action. If the maintainers
decide to do this, I would not object.
Best regards,
Mark
Re: [PATCH v4] gnu: emacs: Update to 27.1.
I confirm that with Mark's commit emacs-clojure-mode and emacs-elisp-refs are also broken. Cheers! -- Pierre Neidhardt https://ambrevar.xyz/ signature.asc Description: PGP signature
Re: [PATCH v4] gnu: emacs: Update to 27.1.
Hi Morgan, Mark, and all, morgan.j.sm...@outlook.com skribis: > From: Morgan Smith > > * gnu/packages/emacs.scm (emacs): Update to 27.1. > [arguments]: Add --with-cairo and --with-modules to #:configure-flags. Add > restore-emacs-pdump phase. > [inputs]: Add cairo, libxaw, jansson, gmp, and harfbuzz. Remove imagemagick > and libxft. > [native-inputs]: Add texlive. > (emacs-wide-int): Mark as deprecated package. > (emacs-no-x): > [arguments]: Add --with-jpeg=no --with-gif=no --with-tiff=no > to #:configure-flags. I see that Mark committed a similar patch just yesterday: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=36a09d185343375a5cba370431870f9c4435d623 I suppose Mark hadn’t seen the ongoing discussion. Mark, Morgan: could you see if there’s anything we’re missing from the patch Morgan submitted? At any rate, thanks a lot for the work everyone put in! Ludo’, a happy Emacs user.
