Re: [PATCH v4 2/3] gnu: Make ldc work again
Leo Famulari writes: > On Tue, Sep 13, 2016 at 09:20:05PM +0200, Ricardo Wurmus wrote: >> >> Leo Famulariwrites: >> >> > On Tue, Sep 13, 2016 at 12:53:39PM -0400, Leo Famulari wrote: >> >> On Tue, Sep 13, 2016 at 12:30:41PM +0200, Danny Milosavljevic wrote: >> >> > * gnu/packages/ldc.scm (ldc): Added substitution. Added zlib input. Fix >> >> > llvm and clang inputs to 3.7. >> >> >> >> LDC built with this patch. I'm currently in the test suite. If it passes >> >> on my computer, I'd like to push this patch unless there are objections. >> > >> > The test suite passed. If there are no more comments in the next day or >> > two, I will push this patch with some edits to the commit message. >> >> The patch looks good to me (aside from the commit message). > > Okay, considering the comments from you and Roel, I pushed with an > altered commit message as 812b3c1f8a3717fd9fc540663912c5e9a144db5b. It built fine here. Thanks for pushing. Kind regards, Roel Janssen
Re: [PATCH v4 2/3] gnu: Make ldc work again
On Tue, Sep 13, 2016 at 09:20:05PM +0200, Ricardo Wurmus wrote: > > Leo Famulariwrites: > > > On Tue, Sep 13, 2016 at 12:53:39PM -0400, Leo Famulari wrote: > >> On Tue, Sep 13, 2016 at 12:30:41PM +0200, Danny Milosavljevic wrote: > >> > * gnu/packages/ldc.scm (ldc): Added substitution. Added zlib input. Fix > >> > llvm and clang inputs to 3.7. > >> > >> LDC built with this patch. I'm currently in the test suite. If it passes > >> on my computer, I'd like to push this patch unless there are objections. > > > > The test suite passed. If there are no more comments in the next day or > > two, I will push this patch with some edits to the commit message. > > The patch looks good to me (aside from the commit message). Okay, considering the comments from you and Roel, I pushed with an altered commit message as 812b3c1f8a3717fd9fc540663912c5e9a144db5b.
Re: [PATCH v4 2/3] gnu: Make ldc work again
Leo Famulariwrites: > On Tue, Sep 13, 2016 at 12:53:39PM -0400, Leo Famulari wrote: >> On Tue, Sep 13, 2016 at 12:30:41PM +0200, Danny Milosavljevic wrote: >> > * gnu/packages/ldc.scm (ldc): Added substitution. Added zlib input. Fix >> > llvm and clang inputs to 3.7. >> >> LDC built with this patch. I'm currently in the test suite. If it passes >> on my computer, I'd like to push this patch unless there are objections. > > The test suite passed. If there are no more comments in the next day or > two, I will push this patch with some edits to the commit message. The patch looks good to me (aside from the commit message). ~~ Ricardo
Re: [PATCH v4 2/3] gnu: Make ldc work again
Leo Famulari writes: > On Tue, Sep 13, 2016 at 12:30:41PM +0200, Danny Milosavljevic wrote: >> * gnu/packages/ldc.scm (ldc): Added substitution. Added zlib input. Fix llvm >> and clang inputs to 3.7. > > LDC built with this patch. I'm currently in the test suite. If it passes > on my computer, I'd like to push this patch unless there are objections. +1. I'm in the test phase as well. Especially because the upgrade to 0.17.1 does not seem to work, I would like to push this patch. Thanks Danny for your work. Kind regards, Roel Janssen
Re: [PATCH v4 2/3] gnu: Make ldc work again
On Tue, Sep 13, 2016 at 12:53:39PM -0400, Leo Famulari wrote: > On Tue, Sep 13, 2016 at 12:30:41PM +0200, Danny Milosavljevic wrote: > > * gnu/packages/ldc.scm (ldc): Added substitution. Added zlib input. Fix > > llvm and clang inputs to 3.7. > > LDC built with this patch. I'm currently in the test suite. If it passes > on my computer, I'd like to push this patch unless there are objections. The test suite passed. If there are no more comments in the next day or two, I will push this patch with some edits to the commit message.
Re: [PATCH v4 2/3] gnu: Make ldc work again
On Tue, Sep 13, 2016 at 12:30:41PM +0200, Danny Milosavljevic wrote: > * gnu/packages/ldc.scm (ldc): Added substitution. Added zlib input. Fix llvm > and clang inputs to 3.7. LDC built with this patch. I'm currently in the test suite. If it passes on my computer, I'd like to push this patch unless there are objections.