Re: Rename oggvorbis.scm to xiph-codecs.scm? (was Re: New package recipe: libopus-1.1)
Andreas Enge andr...@enge.fr skribis: On Thu, Jan 23, 2014 at 11:58:43AM -0500, Thompson, David wrote: On Thu, Jan 23, 2014 at 11:51 AM, Ludovic Courtès l...@gnu.org wrote: Or just xiph.scm? Because not everything is a codec strictly speaking. I like this name best. Done in 54ff0b7. Please correct any errors you find... (As I just restarted hydra and it needs to catch up building core-updates, I tested only that guix still compiles.) Thanks! Ludo’.
Re: New package recipe: libopus-1.1
Sree Harsha Totakura sreehar...@totakura.in skribis: From 23dcddebb12c619e22dac20a6181dfb77df4c876 Mon Sep 17 00:00:00 2001 From: Sree Harsha Totakura sreehar...@totakura.in Date: Thu, 23 Jan 2014 19:38:39 +0100 Subject: [PATCH] gnu: oggvorbis: Add libopus-1.1. * gnu/packages/oggvorbis.scm: Add libopus-1.1. Thanks, applied with minor changes: • Added you as a copyright holder (let me know if that’s not the case); • Changed the package name to “opus”, since that’s what it’s called upstream; • Adjusted to match the xiph.scm rename. Ludo’.
Re: Rename oggvorbis.scm to xiph-codecs.scm? (was Re: New package recipe: libopus-1.1)
Mark H Weaver m...@netris.org skribis: Andreas Enge andr...@enge.fr writes: Actually, it should go into oggvorbis.scm, where we put all xiph codecs. I think that module should be renamed. Maybe xiph-codecs.scm ? Or just xiph.scm? Because not everything is a codec strictly speaking. Ludo’.
Re: New package recipe: libopus-1.1
On 01/22/2014 04:23 PM, Sree Harsha Totakura wrote: Hi, Hello, Attached is a recipe for libopus-1.1. Please include it. Comments inlined. Thank you, Sree 0001-new-package-libopus-1.1.patch From eafeaed576eccd20e108f62dc61d89d2c4be353b Mon Sep 17 00:00:00 2001 From: Sree Harsha Totakurasreehar...@totakura.in Date: Wed, 22 Jan 2014 16:17:18 +0100 Subject: [PATCH] new package: libopus-1.1 Signed-off-by: Sree Harsha Totakurasreehar...@totakura.in --- gnu/packages/opus.scm | 50 + 1 file changed, 50 insertions(+) create mode 100644 gnu/packages/opus.scm diff --git a/gnu/packages/opus.scm b/gnu/packages/opus.scm new file mode 100644 index 000..2102b59 --- /dev/null +++ b/gnu/packages/opus.scm @@ -0,0 +1,50 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2013 Andreas Engeandr...@enge.fr +;;; Please use the right Copyright... +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, seehttp://www.gnu.org/licenses/. + +;; Author: Sree Harsha Totakurasreehar...@totakura.in + ... and remove this. +(define-module (gnu packages opus) + #:use-module (gnu packages) + #:use-module ((guix licenses) +#:renamer (symbol-prefix-proc 'license:)) I do not think you need a #:renamer here. + #:use-module (guix packages) + #:use-module (guix download) + #:use-module (guix build-system gnu)) + +(define-public libopus + (package +(name libopus) +(version 1.1) +(source (origin + (method url-fetch) + (uri (string-append +http://downloads.xiph.org/releases/opus/opus-; version +.tar.gz)) + (sha256 + (base32 +158xprn2086arvdib3vbbygz7z6jqkw2nci7nlywzzwallap0wmr +(build-system gnu-build-system) +(synopsis Libopus - hightly versatile audio codec) s/hightly/highly/ +(description Opus is a totally open, royalty-free, highly versatile audio +codec. Opus is unmatched for interactive speech and music transmission over +the Internet, but is also intended for storage and streaming applications. It +is standardized by the Internet Engineering Task Force (IETF) as RFC 6716 +which incorporated technology from Skype's SILK codec and Xiph.Org's CELT +codec.) +(license license:bsd-3) 'bsd-3' should be enough. +(home-pagehttp://www.opus-codec.org/;))) \ No newline at end of file -- 1.7.10.4 Also, please add the new file to gnu-system.am. Thanks! Cyril Roelandt.
Re: New package recipe: libopus-1.1
Hi, Here is the patch with the suggested commit message. Sree On 01/22/2014 05:37 PM, Mark H Weaver wrote: gnu: Add libopus. * gnu/packages/opus.scm: New file. * gnu-system.am (GNU_SYSTEM_MODULES): Add it. From 18c8bb6e1064ec39982c5350e22c74562fd6ea94 Mon Sep 17 00:00:00 2001 From: Sree Harsha Totakura sreehar...@totakura.in Date: Wed, 22 Jan 2014 18:07:06 +0100 Subject: [PATCH] gnu: Add libopus. * gnu/packages/opus.scm: New file. * gnu-system.am (GNU_SYSTEM_MODULES): Add it. Signed-off-by: Sree Harsha Totakura sreehar...@totakura.in --- gnu-system.am |1 + gnu/packages/opus.scm | 47 +++ 2 files changed, 48 insertions(+) create mode 100644 gnu/packages/opus.scm diff --git a/gnu-system.am b/gnu-system.am index 43f95b3..6a88c45 100644 --- a/gnu-system.am +++ b/gnu-system.am @@ -149,6 +149,7 @@ GNU_SYSTEM_MODULES =\ gnu/packages/onc-rpc.scm \ gnu/packages/openldap.scm \ gnu/packages/openssl.scm \ + gnu/packages/opus.scm\ gnu/packages/package-management.scm \ gnu/packages/parallel.scm \ gnu/packages/parted.scm \ diff --git a/gnu/packages/opus.scm b/gnu/packages/opus.scm new file mode 100644 index 000..fad265e --- /dev/null +++ b/gnu/packages/opus.scm @@ -0,0 +1,47 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2014 Sree Harsha Totakura sreehar...@totakura.in +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see http://www.gnu.org/licenses/. + +(define-module (gnu packages opus) + #:use-module (gnu packages) + #:use-module (guix licenses) + #:use-module (guix packages) + #:use-module (guix download) + #:use-module (guix build-system gnu)) + +(define-public libopus + (package +(name libopus) +(version 1.1) +(source (origin + (method url-fetch) + (uri (string-append +http://downloads.xiph.org/releases/opus/opus-; version +.tar.gz)) + (sha256 + (base32 +158xprn2086arvdib3vbbygz7z6jqkw2nci7nlywzzwallap0wmr +(build-system gnu-build-system) +(synopsis Libopus - highly versatile audio codec) +(description Opus is a totally open, royalty-free, highly versatile audio +codec. Opus is unmatched for interactive speech and music transmission over +the Internet, but is also intended for storage and streaming applications. It +is standardized by the Internet Engineering Task Force (IETF) as RFC 6716 +which incorporated technology from Skype's SILK codec and Xiph.Org's CELT +codec.) +(license bsd-3) +(home-page http://www.opus-codec.org/;))) -- 1.7.10.4 signature.asc Description: OpenPGP digital signature
Re: New package recipe: libopus-1.1
Hello Sree, thanks for the patch, and congratulations for your first guix package (which I did not try out yet, I simply assumed it worked...). Actually, it should go into oggvorbis.scm, where we put all xiph codecs. Could you please do so and drop the new file, also from gnu-system.am? I am not sure about the Signed-off-by: Sree Harsha Totakura sreehar...@totakura.in field; normally you are simply the author, no need to add it (and when Ludovic applies patches coming from the list, he normally signs them off). Andreas
Re: New package recipe: libopus-1.1
Andreas Enge andr...@enge.fr skribis: thanks for the patch, and congratulations for your first guix package (which I did not try out yet, I simply assumed it worked...). Indeed, cool. :-) And thanks to the other people for the reviews! Actually, it should go into oggvorbis.scm, where we put all xiph codecs. Could you please do so and drop the new file, also from gnu-system.am? Agreed. I am not sure about the Signed-off-by: Sree Harsha Totakura sreehar...@totakura.in field; normally you are simply the author, no need to add it (and when Ludovic applies patches coming from the list, he normally signs them off). Right. Note to the reviewers: feel free to push a patch that looks good to you and uncontroversial, per the guidelines in ‘HACKING’. Don’t be shy. ;-) Ludo’.
Re: New package recipe: libopus-1.1
Sree Harsha Totakura sreehar...@totakura.in skribis: +(synopsis Libopus - highly versatile audio codec) One last thing: please don’t repeat the package name in the synopsis (there have been exceptions to this rule but we’ll fix them over time.) As you can see there are a bunch of conventions, but hopefully it will be easy to adjust and won’t be too much of a burden. Thank you! Ludo’.
