Re: Rewriting inputs and ’arguments’ after patch #43578

2020-10-05 Thread zimoun
Hi Ludo,

On Mon, 5 Oct 2020 at 15:46, Ludovic Courtès  wrote:

> > Therefore, it is not possible to rewrite this “inputs“ (using the patch
> > [1]), as the dry-run shows:
> >
> > $ guix build emacs-magit --with-input=emacs-no-x=emacs-next -n
>
> AFAICS, it’s working as expected:
>
> --8<---cut here---start->8---
> $ guix gc --references $(guix build emacs-magit 
> --with-input=emacs-no-x=emacs-next -d --no-grafts) |grep emacs-next
> /gnu/store/8ffjg2961x30171i24pl7j9wafcbli2b-emacs-next-28.0.50.1-0.2ea3466.drv
> $ guix gc --references $(guix build emacs-magit 
> --with-input=emacs-no-x=emacs-next -d --no-grafts) |grep emacs-no-x
> --8<---cut here---end--->8---

Hum?  I believe what I see... I am sure about my previous example and
your example also speaks by itself...  Therefore, the most probable
seems to be a mistake between my keyboard and my chair. :-)
Sorry for the noise.

> Now, there dependencies in the graph that depend on ‘emacs-minimal’
> instead of ‘emacs-no-x’, so you’d probably also need to replace those.

Yep!  That's the point of 'package-with-emacs-next'.

Cheers,
simon



Re: Rewriting inputs and ’arguments’ after patch #43578

2020-10-05 Thread Ludovic Courtès
Hi,

zimoun  skribis:

> Let consider the package ’emacs-magit’.  It does not depend on
> ’emacs-minimal’ but instead the argument is replaced by ’emacs-no-x’,
> see: 
>
>   (build-system emacs-build-system)
>   (arguments
>`(#:emacs ,emacs-no-x;module support is required
>  #:tests? #t
>
>
> which is for example confirmed by “guix graph –path”:
>
> $ guix graph --path emacs-magit emacs-minimal
> guix graph: error: no path from 'emacs-magit@2.90.1-6.7f486d4' to 
> 'emacs-minimal@27.1'
>
> $ guix graph --path emacs-magit emacs-no-x
> emacs-magit@2.90.1-6.7f486d4
> emacs-libgit@20200515-1.0ef8b13
> emacs-no-x@27.1
>
>
>
> Therefore, it is not possible to rewrite this “inputs“ (using the patch
> [1]), as the dry-run shows:
>
> $ guix build emacs-magit --with-input=emacs-no-x=emacs-next -n

AFAICS, it’s working as expected:

--8<---cut here---start->8---
$ guix gc --references $(guix build emacs-magit 
--with-input=emacs-no-x=emacs-next -d --no-grafts) |grep emacs-next
/gnu/store/8ffjg2961x30171i24pl7j9wafcbli2b-emacs-next-28.0.50.1-0.2ea3466.drv
$ guix gc --references $(guix build emacs-magit 
--with-input=emacs-no-x=emacs-next -d --no-grafts) |grep emacs-no-x
--8<---cut here---end--->8---

Now, there dependencies in the graph that depend on ‘emacs-minimal’
instead of ‘emacs-no-x’, so you’d probably also need to replace those.

HTH,
Ludo’.