[hackers] [lsw][patch] Better handling of window title with non-ascii chars

[Julien Steinhauser]

Hello

I've seen window title with non-ascii chars incorrectly displayed,
using Xutf8TextPropertyToTextList instead of XmbTextPropertyToTextList
as in the diff below fixed it.

Regards

Julien

diff --git a/lsw.c b/lsw.c
index fc40fef..9a5bee1 100644
--- a/lsw.c
+++ b/lsw.c
@@ -55,7 +55,7 @@ getname(Window win) {
if(!XGetTextProperty(dpy, win, , netwmname) || prop.nitems == 0)
if(!XGetWMName(dpy, win, ) || prop.nitems == 0)
return "";
-   if(!XmbTextPropertyToTextList(dpy, , , ) && n > 0) {
+   if(!Xutf8TextPropertyToTextList(dpy, , , ) && n > 0) {
strncpy(buf, list[0], sizeof buf);
XFreeStringList(list);
} else

Re: [hackers] [st] st-alpha-0.7.diff not working

[vinícius mota]

No. It seems there is only one configuration file for st in gentoo, which
is /etc/portage/savedconfig/x11-terms/st-0.7. So in the other two patches
for ST that I have installed, namely clipboard and scrollback, the patch
only required changes in config.def.h, which I always assumed to be
/etc/portage/savedconfig/x11-terms/st-0.7, and it worked for those patches
flawlessly. For st-alpha I first had to understand how to handle config.mk,
which is why I made this post in gentoo wiki, and eventually I did
understood. But I just did not get any transparency on despite of the
insallation of st-alpha occurring without any erros or warnings, the
terminal just became gray. In your version of the patch, however, there
seems to be another configuration file to be edited besides config.def.h,
which is st.h. That was what I was asking you, because there is no other
configuration file for st in Gentoo which is not
/etc/portage/savedconfig/x11-terms/st-0.7.

On Wed, Nov 22, 2017 at 2:20 PM, Martin Kühne  wrote:

> So you used savedconfig because it was mentioned in [0]?
>
> cheers!
> mar77i
>
> [0] https://wiki.gentoo.org/wiki/St
>
>

Re: [hackers] [st] st-alpha-0.7.diff not working

[Martin Kühne]

So you used savedconfig because it was mentioned in [0]?

cheers!
mar77i

[0] https://wiki.gentoo.org/wiki/St

Re: [hackers] [st] st-alpha-0.7.diff not working

[vinícius mota]

Thank you again Martin for your reply.

Just to be clear: I ain't complaining about your work, and I am certainly
not complaining about any suckless tools. If anything I became a big
enthusiast of suckless tools, both because of its simplicity and
"lightness": right now I migrate all my window managers to DWM and changed
all terminals to ST, and I am using dmenu and slock as well. Also, I am not
handing off any responsibility at all, all I am doing is asking for some
guidance, if it is possible. If I properly understood your last comment you
are confused with the fact that I am able to run Gentoo, which is not a
distro for beginners, but at the same time I am failing miserably to
understand something that fells very basic and simple to you. You are
totally correct, I have been using RedHat and Fedora for the last 20 years
but decided to use Gentoo instead to force me to learn a lot about coding
and computation in general. So yes, the way the patches are implemented has
been very difficult for me to understand, as you can see here
https://forums.gentoo.org/viewtopic.php?p=8143538#8143538, but I am
interested in learning anyway, and eventually I know I will. So thank you
again for your replies, I won't bother you any more.

On Wed, Nov 22, 2017 at 1:19 PM, Martin Kühne  wrote:

> You appear to be in a very unique dilemma. You have three different
> pieces of the puzzle that don't fit together, as both the patch from
> the site as well as my own branch fails for you. Then you hand off
> your responsibility over which software version you use to your
> distribution, but come to us to complain over a tool that does nothing
> but delete and insert lines of code, the whole concept of which
> appears to be voodoo to you. Then you tell us you're running Gentoo.
> What in the reality's name is going on.
>
> Use. The. Latest. Git. Commit:
>
> 0ac685fc015362e749bf82cfaa3cfe2dd9b305f0
>
> cheers!
> mar77i
>
>

Re: [hackers] [st] st-alpha-0.7.diff not working

[Martin Kühne]

You appear to be in a very unique dilemma. You have three different
pieces of the puzzle that don't fit together, as both the patch from
the site as well as my own branch fails for you. Then you hand off
your responsibility over which software version you use to your
distribution, but come to us to complain over a tool that does nothing
but delete and insert lines of code, the whole concept of which
appears to be voodoo to you. Then you tell us you're running Gentoo.
What in the reality's name is going on.

Use. The. Latest. Git. Commit:

0ac685fc015362e749bf82cfaa3cfe2dd9b305f0

cheers!
mar77i