Re: [hackers][sbase][PATCH] Fix build errors on some ARM64 Linux systems
On Mon, Aug 27, 2018 at 09:21:33PM +0200, Hiltjo Posthuma wrote: > On Mon, Aug 27, 2018 at 09:37:24PM +0300, Platon Ryzhikov wrote: > > These changes are required on Arch Linux ARM to build sbase. This does not > > affect x86 build. > > --- > > ls.c | 1 + > > tar.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/ls.c b/ls.c > > index b716aba..9e79fcb 100644 > > --- a/ls.c > > +++ b/ls.c > > @@ -1,6 +1,7 @@ > > /* See LICENSE file for copyright and license details. */ > > #include > > #include > > +#include > > > > #include > > #include > > diff --git a/tar.c b/tar.c > > index a6ead2e..9359bfd 100644 > > --- a/tar.c > > +++ b/tar.c > > @@ -1,6 +1,7 @@ > > /* See LICENSE file for copyright and license details. */ > > #include > > #include > > +#include > > > > #include > > #include > > -- > > 2.18.0 > > > > As reported before this is wrong and probably Linux and glibc-specific. > > Also sort the include names. > > -- > Kind regards, > Hiltjo How does my updated patch from Jul 8 on the previous report for this bug look? Thanks, David
Re: [hackers][sbase][PATCH] Fix build errors on some ARM64 Linux systems
On Mon, Aug 27, 2018 at 09:37:24PM +0300, Platon Ryzhikov wrote: > These changes are required on Arch Linux ARM to build sbase. This does not > affect x86 build. > --- > ls.c | 1 + > tar.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/ls.c b/ls.c > index b716aba..9e79fcb 100644 > --- a/ls.c > +++ b/ls.c > @@ -1,6 +1,7 @@ > /* See LICENSE file for copyright and license details. */ > #include > #include > +#include > > #include > #include > diff --git a/tar.c b/tar.c > index a6ead2e..9359bfd 100644 > --- a/tar.c > +++ b/tar.c > @@ -1,6 +1,7 @@ > /* See LICENSE file for copyright and license details. */ > #include > #include > +#include > > #include > #include > -- > 2.18.0 > As reported before this is wrong and probably Linux and glibc-specific. Also sort the include names. -- Kind regards, Hiltjo
[hackers][sbase][PATCH] Fix build errors on some ARM64 Linux systems
These changes are required on Arch Linux ARM to build sbase. This does not affect x86 build. --- ls.c | 1 + tar.c | 1 + 2 files changed, 2 insertions(+) diff --git a/ls.c b/ls.c index b716aba..9e79fcb 100644 --- a/ls.c +++ b/ls.c @@ -1,6 +1,7 @@ /* See LICENSE file for copyright and license details. */ #include #include +#include #include #include diff --git a/tar.c b/tar.c index a6ead2e..9359bfd 100644 --- a/tar.c +++ b/tar.c @@ -1,6 +1,7 @@ /* See LICENSE file for copyright and license details. */ #include #include +#include #include #include -- 2.18.0
