Re: [hackers] [st][PATCH] Delay redrawals on palette changes

2022-02-18 Thread Hiltjo Posthuma
On Thu, Feb 17, 2022 at 04:00:47PM +0200, Santtu Lakkala wrote:
> Build on auto-sync and only mark window dirty on palette changes and let
> the event handler do the actual draw.
> ---
>  st.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/st.c b/st.c
> index 51049ba..c71fa06 100644
> --- a/st.c
> +++ b/st.c
> @@ -1927,7 +1927,7 @@ strhandle(void)
>   else if (xsetcolorname(defaultfg, p))
>   fprintf(stderr, "erresc: invalid foreground 
> color: %s\n", p);
>   else
> - redraw();
> + tfulldirt();
>   return;
>   case 11:
>   if (narg < 2)
> @@ -1940,7 +1940,7 @@ strhandle(void)
>   else if (xsetcolorname(defaultbg, p))
>   fprintf(stderr, "erresc: invalid background 
> color: %s\n", p);
>   else
> - redraw();
> + tfulldirt();
>   return;
>   case 12:
>   if (narg < 2)
> @@ -1953,7 +1953,7 @@ strhandle(void)
>   else if (xsetcolorname(defaultcs, p))
>   fprintf(stderr, "erresc: invalid cursor color: 
> %s\n", p);
>   else
> - redraw();
> + tfulldirt();
>   return;
>   case 4: /* color set */
>   if (narg < 3)
> @@ -1975,7 +1975,7 @@ strhandle(void)
>* TODO if defaultbg color is changed, borders
>* are dirty
>*/
> - redraw();
> + tfulldirt();
>   }
>   return;
>   }
> -- 
> 2.32.0
> 
> 

Hi Santtu,

Thank you, I pushed the patch to the repo.

-- 
Kind regards,
Hiltjo



[hackers] [st][PATCH] Delay redrawals on palette changes

2022-02-17 Thread Santtu Lakkala
Build on auto-sync and only mark window dirty on palette changes and let
the event handler do the actual draw.
---
 st.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/st.c b/st.c
index 51049ba..c71fa06 100644
--- a/st.c
+++ b/st.c
@@ -1927,7 +1927,7 @@ strhandle(void)
else if (xsetcolorname(defaultfg, p))
fprintf(stderr, "erresc: invalid foreground 
color: %s\n", p);
else
-   redraw();
+   tfulldirt();
return;
case 11:
if (narg < 2)
@@ -1940,7 +1940,7 @@ strhandle(void)
else if (xsetcolorname(defaultbg, p))
fprintf(stderr, "erresc: invalid background 
color: %s\n", p);
else
-   redraw();
+   tfulldirt();
return;
case 12:
if (narg < 2)
@@ -1953,7 +1953,7 @@ strhandle(void)
else if (xsetcolorname(defaultcs, p))
fprintf(stderr, "erresc: invalid cursor color: 
%s\n", p);
else
-   redraw();
+   tfulldirt();
return;
case 4: /* color set */
if (narg < 3)
@@ -1975,7 +1975,7 @@ strhandle(void)
 * TODO if defaultbg color is changed, borders
 * are dirty
 */
-   redraw();
+   tfulldirt();
}
return;
}
-- 
2.32.0