Re: [hackers] [surf] Some cleanup in style. || Christoph Lohmann

2015-02-04 Thread k0ga 
> On Tue, Feb 03, 2015 at 07:52:10PM +0100, FRIGN wrote:
>> On Tue,  3 Feb 2015 17:17:15 +0100 (CET)
>> g...@suckless.org wrote:
>> 
>> > commit b3a4392923b26e81c4faa35907a4a2d071e2275f
>> > Author: Christoph Lohmann <2...@r-36.net>
>> > Date:   Tue Feb 3 17:17:04 2015 +0100
>> > 
>> > Some cleanup in style.
>> 
>> wrong: http://suckless.org/style
> 
> His style fix is correct in respect to the existing code style of surf.
> The style guide is simply a guide.

Yeah, this is the first rule of any code style guide, if a project
has a style, don't change it.

Regards,

Re: [hackers] [surf] Some cleanup in style. || Christoph Lohmann

2015-02-03 Thread Dimitris Papastamos 
On Tue, Feb 03, 2015 at 07:52:10PM +0100, FRIGN wrote:
> On Tue,  3 Feb 2015 17:17:15 +0100 (CET)
> g...@suckless.org wrote:
> 
> > commit b3a4392923b26e81c4faa35907a4a2d071e2275f
> > Author: Christoph Lohmann <2...@r-36.net>
> > Date:   Tue Feb 3 17:17:04 2015 +0100
> > 
> > Some cleanup in style.
> 
> wrong: http://suckless.org/style

His style fix is correct in respect to the existing code style of surf.
The style guide is simply a guide.

Re: [hackers] [surf] Some cleanup in style. || Christoph Lohmann

2015-02-03 Thread FRIGN 
On Tue,  3 Feb 2015 17:17:15 +0100 (CET)
g...@suckless.org wrote:

> commit b3a4392923b26e81c4faa35907a4a2d071e2275f
> Author: Christoph Lohmann <2...@r-36.net>
> Date:   Tue Feb 3 17:17:04 2015 +0100
> 
> Some cleanup in style.

wrong: http://suckless.org/style


-- 
FRIGN

[hackers] [surf] Some cleanup in style. || Christoph Lohmann

2015-02-03 Thread git 
commit b3a4392923b26e81c4faa35907a4a2d071e2275f
Author: Christoph Lohmann <2...@r-36.net>
Date:   Tue Feb 3 17:17:04 2015 +0100

Some cleanup in style.

diff --git a/surf.c b/surf.c
index 48f6b39..36f243e 100644
--- a/surf.c
+++ b/surf.c
@@ -292,7 +292,7 @@ buttonrelease(WebKitWebView *web, GdkEventButton *e, GList 
*gl) {
 
 static void
 cleanup(void) {
-   if (diskcache) {
+   if(diskcache) {
soup_cache_flush(diskcache);
soup_cache_dump(diskcache);
}
@@ -715,7 +715,7 @@ loadstatuschange(WebKitWebView *view, GParamSpec *pspec, 
Client *c) {
case WEBKIT_LOAD_FINISHED:
c->progress = 100;
updatetitle(c);
-   if (diskcache) {
+   if(diskcache) {
soup_cache_flush(diskcache);
soup_cache_dump(diskcache);
}