Re: [hackers] [tabbed][PATCH] Fix crashes when nclients == 0 in movetab() and focusurgent()

[Caleb Malchik]

On Sun, May 7, 2017 at 8:28 PM, Quentin Rameau  wrote:
> I'd prefer to check against sel rather than nclients, as it's already
> done throughout the rest of the code.
>
> I'll apply your patch with those changes if that's ok with you.

Sounds good to me.

Re: [hackers] [tabbed][PATCH] Fix crashes when nclients == 0 in movetab() and focusurgent()

[Quentin Rameau]

Hi Caleb,

good catch and thanks for the patch!

> + if (nclients == 0)
> + return;
> +

I'd prefer to check against sel rather than nclients, as it's already
done throughout the rest of the code.

I'll apply your patch with those changes if that's ok with you.

[hackers] [tabbed][PATCH] Fix crashes when nclients == 0 in movetab() and focusurgent()

[Caleb Malchik]

---
 tabbed.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/tabbed.c b/tabbed.c
index 6321575..23c3b47 100644
--- a/tabbed.c
+++ b/tabbed.c
@@ -502,6 +502,9 @@ focusurgent(const Arg *arg)
 {
int c;
 
+   if (nclients == 0)
+   return;
+
for (c = (sel + 1) % nclients; c != sel; c = (c + 1) % nclients) {
if (clients[c]->urgent) {
focus(c);
@@ -785,6 +788,9 @@ movetab(const Arg *arg)
int c;
Client *new;
 
+   if (nclients == 0)
+   return;
+
c = (sel + arg->i) % nclients;
if (c < 0)
c += nclients;
-- 
2.12.2