Hi, I am back from my vacation and I wanted to ask whether somebody has had the chance to look at this. A short ACK that the changes will be reviewed would be much appreciated.
Best, Alexander SAP SE Germany From: Stephan, Alexander Sent: Friday, September 15, 2023 6:39 PM To: haproxy@formilux.org Cc: Menges, Christian Norbert <christian.norbert.men...@sap.com> Subject: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs Hi all, As a follow-up to my last patches that allow to fetch any TLV in the frontend, I have also implemented similar functionality in the backend that allows to send out TLVs of any type. This is an addition to the existing proxy-protocol-v2-option constants like crc32c. Unlike the pre-defined TLVs, generic TLVs, indicated by their type number, have a common behavior. I think the test I've added as well as the documentation should explain best how it works in more detail. To update TLVs in-place in a connection, before forwarding, I have also added a corresponding TCP action. PPv2 is not quite TCP level, but it seems like the best fit. I am very interested in what you think about the changes. Essentially, these are two commits split into four, for easier review (split by component). I will be on vacation the next two weeks, but my colleague Christian Menges will jump in during that time and address your feedback. Thanks and Best, Alexander SAP SE Germany --- Alexander Stephan (4): MEDIUM: server: Parse generic type-value pairs as proxy-v2-options MEDIUM: connection: Send out generically allocated proxy-v2-options LOW: connection: Add TLV update function MEDIUM: tcp-act: Add new set-tlv TCP action for PPv2 TLVs doc/configuration.txt | 43 +++++++ include/haproxy/connection.h | 73 +++++++++++ include/haproxy/server-t.h | 10 ++ .../proxy_protocol_send_generic.vtc | 66 ++++++++++ src/connection.c | 51 +++++++- src/server.c | 76 ++++++++++- src/tcp_act.c | 120 ++++++++++++++++-- 7 files changed, 417 insertions(+), 22 deletions(-) create mode 100644 reg-tests/connection/proxy_protocol_send_generic.vtc -- 2.35.3
